Skip to content
Snippets Groups Projects

SlyEdit: More small tweaks for quote line wrapping to determine ideal places to append a CRLF

Merged Eric Oulashin requested to merge slyedit_quote_line_wrapping_more_tweaks into master
1 unresolved thread

SlyEdit: More small tweaks for quote line wrapping to determine ideal places to append a CRLF

Merge request reports

Pipeline #4642 passed

Pipeline passed for bd10e197 on slyedit_quote_line_wrapping_more_tweaks

Merged by Rob SwindellRob Swindell 1 year ago (Aug 17, 2023 9:11pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Have you considered just using the word_wrap function built into SBBS? It handles quoted lines already.

    • Author Developer

      This actually does use word_wrap (line 2946). The issue I found with word_wrap is that it there are some quoted lines in some messages it doesn't handle very well. word_wrap seems to work relatively well if the quote prefixes are " > ", but if the quote prefix for a section of a message is a bit different (i.e., with author's initials or other characters before the >), word_wrap doesn't seem to take that into account. This word wrap function I wrote looks for different sections in the message with various quote prefixes and uses word_wrap() on each section (without that section's prefix) and then prepends the prefix back onto that section.

      I've seen some more variation in quote prefixes on FSXNet. For instance, some messages are quoted with "-> ", and some have multiple things where people have quoted lines that have been already quoted (such as "-> Av> ", or " Bu> cl> "). In messages with such quote prefixes, especially multiple different prefixes for different quoted sections, word_wrap often didn't preserve some of those quote prefixes in front of the quoted sections of the messages.

    • Author Developer

      Also, if a message has multiple quoted sections with different prefixes for each section, that's an instance where word_wrap() doesn't seem to account for the quote prefixes and could include the prefixes in the wrapped text

    • Okay, I just wanted to make sure use of word_wrap() as being considered (or done).

      I haven't really observed the issues you're describing while using fseditor.js, but I'm also usually using it at 80 columns and maybe that's why.

    • Author Developer

      Do you mean an 80-column terminal, or wrapping at 80 columns? I do use an 80-column terminal most of the time.

      Edited by Eric Oulashin
    • Please register or sign in to reply
  • merged

  • Rob Swindell mentioned in commit 3b643e76

    mentioned in commit 3b643e76

  • Rob Swindell mentioned in commit 535d6b66

    mentioned in commit 535d6b66

Please register or sign in to reply
Loading