Skip to content
Snippets Groups Projects

Fix for js.time_limit stuck at 0

Merged Nigel Reed requested to merge mrc_fix_time_limit into master
1 unresolved thread

When setting js.time_limit in mirc-client.js the value sticks throughout the session, which means any other scripts run will also have js.time_limit = 0. This modification stores the value of js.time_limit upon invocation and then resets it when the main loop terminates. While this should be sufficient in most cases, it obviously won't catch something due to an error. These should be rare if not non-existent now.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
377 378 }
378 379 yield();
379 380 }
381 js.time_limit = orig_timelimit;
  • Nigel Reed added 1 commit

    added 1 commit

    • a4d27ca6 - Changed storage of js.time_limit per Rob's suggestion

    Compare with previous version

  • Author Developer

    Changed per your suggestion. Thanks.

  • Rob Swindell enabled an automatic merge when the pipeline for a4d27ca6 succeeds

    enabled an automatic merge when the pipeline for a4d27ca6 succeeds

  • merged

  • Rob Swindell mentioned in commit 7a750b50

    mentioned in commit 7a750b50

  • Rob Swindell mentioned in commit 251f6119

    mentioned in commit 251f6119

  • Please register or sign in to reply
    Loading