Skip to content
Snippets Groups Projects

Add support for binary frames to websocket service

Merged Rick Parrish requested to merge Ree/websocketservice-support-binary into master

websocketservice.js originally only supported text frames, which requires utf-8 encoding/decoding. This adds support for binary frames, which don't need encoding/decoding, so are simpler to work with and slightly faster.

Also change how some error conditions are handled -- shouldn't just log a debug message, they are unrecoverable errors and should be treated as such.

Merge request reports

Pipeline #4694 passed

Pipeline passed for 987f7dba on Ree/websocketservice-support-binary

Approval is optional

Merged by Rob SwindellRob Swindell 1 year ago (Sep 9, 2023 5:27pm UTC)

Merge details

  • Changes merged into master with c9e64372 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading