DDMsgReader: When listing messages via lightbar, check if the subject is UTF-8, which now helps the lightbar menu display the line properly, particularly for UTF-8 terminals

DDMsgReader: When listing messages via lightbar, check if the subject is UTF-8, which now helps the lightbar menu display the line properly, particularly for UTF-8 terminals

assigned to @rswindell

I suspect with this change, textIsUTF8 will always be true. Are you actually seeing messages with subjects that are not valid UTF-8?

All ASCII strings are valid UTF-8, while not all UTF-8 strings are valid ASCII.

You probably mean to write something more like this:

str_is_ascii(str) === false && str_is_utf8(str) === true

Logically that makes sense, though it has the same effect in the message list either way. I've updated it to check this way and pushed my changes, and ran another build pipeline.

added 1 commit

• 5777615e - DDMsgReader: Updated the UTF-8 check for message subjects for the lightbar message list

Compare with previous version

merged

mentioned in commit 0a3bb9f5