DDMsgReader: Sorting of sub-boards when changing to another sub-board (for nelgin). Toggleable behavior to only show sub-boards with new messages in the indexed-mode newscan (for kdi4hw). Internal: Updated for bbs.msg_number and bbs.smb_curmsg being write
DDMsgReader: Sorting of sub-boards when changing to another sub-board (for nelgin). Toggleable behavior to only show sub-boards with new messages in the indexed-mode newscan (for kdi4hw). Internal: Updated for bbs.msg_number and bbs.smb_curmsg being writeable in Synchronet 3.20.
The new configuration option subBoardChangeSorting specifies the sub-board sorting (None, Alphabetical, LatestMsgDateOldestFirst, or LatestMsgDateNewestFirst). This is a default for a user option that users can change for themselves.
The new configuration option indexedModeNewscanOnlyShowSubsWithNewMsgs sets the default setting for this behavior (true or false).
Updated for bbs.msg_number and bbs.smb_curmsg being writeable in Synchronet 3.20 - If these can be changed, there's no need to write the drop file DDML_SyncSMBInfo.txt containing information about the message being replied to etc. for message editors to use
Merge request reports
Activity
assigned to @rswindell
- Resolved by Eric Oulashin
added 1 commit
- 0dae7271 - Added exec/load/user_settings.js, currently with a function to prompt the user...
added 1 commit
- 0fd7999b - DDMsgReader configuratior: Added help text for the 2 new options,...
28 28 require("sbbsdefs.js", 'BBS_OPT_AUTO_LOGON'); 29 29 require("userdefs.js", 'USER_SPIN'); 30 30 require("nodedefs.js", 'NODE_DFLT'); 31 require("gettext.js", 'gettext'); 31 require("user_settings_lib.js", 'prompt_user_for_download_protocol'); // Includes gettext.js changed this line in version 4 of the diff
22624 22897 // pMsgHdr: The message header 22625 // pSubCode: The sub-board code that the message is in 22626 function allowUserToDownloadMessage_NewInterface(pMsgHdr, pSubCode) 22898 // pMsgbaseCode: The internal code for the messagebase that the message is in 22899 function allowUserToDownloadMessage_NewInterface(pMsgHdr, pMsgbaseCode) 22627 22900 { 22628 22901 if (typeof(bbs.download_msg_attachments) !== "function") 22629 22902 return; 22630 if (typeof(pSubCode) !== "string") 22903 if (typeof(pMsgbaseCode) !== "string") 22631 22904 return; 22632 22905 if (typeof(pMsgHdr) !== "object" || typeof(pMsgHdr.number) == "undefined") 22633 22906 return; 22634 22907 22635 var msgBase = new MsgBase(pSubCode); 22908 // If the user doesn't have a download protocol configured, then allow them With the latest changes in SBBS v3.20 (commit ae325308), I don't think you any of this logic - file attachments don't use the user's configured download protocol, by default, so no need to prompt the user to set/change it.
changed this line in version 4 of the diff
added 23 commits
-
0fd7999b...846846fa - 21 commits from branch
master
- 7cccf955 - DDMsgReader: Removed xfer protocol selection when downloading message...
- 15796412 - Merge remote-tracking branch 'origin/master' into dd_msg_reader_v1_96
-
0fd7999b...846846fa - 21 commits from branch
added 4 commits
-
15796412...e7885295 - 3 commits from branch
master
- e3064630 - Merge remote-tracking branch 'origin/master' into dd_msg_reader_v1_96
-
15796412...e7885295 - 3 commits from branch
mentioned in commit 09eae31c