Overhaul LZH code

• Rename variables and macros to be more readable.
• Split encoding and decoding variables into separate structs so they don't all need to be on the stack
• Stop using signed values for anything This also stops depending on left-shifting into the sign bit "working" as expected... something compilers can optimize out
• Use size-based types instead of short/long
• Make the encoded buffer endian-agnostic (convert to little-endian)
• Clean up lzh_update() a bit

assigned to @rswindell

added 1 commit

• a70e0bbf - We don't need malloc(), and the comment was correct.

Compare with previous version

added 30 commits

• a70e0bbf...f06436db - 28 commits from branch master
• 5fd4f866 - Merge branch 'master' into lzh-fixup
• 41691508 - More cleanup, accept a buffer size argument and return error

Compare with previous version

There, nothing left to improve without breaking backward compatibility by supporting more the 4GB.

The Overview (and commit messages) don't mention removing dynamic buffer support? It's fine to remove, I'm sure. This ain't the 640KB days!

Might as well remove the #if 0 block while here

closed