Skip to content
Snippets Groups Projects

webv4 header should show count for unread mail instead of all mail (using new...

Merged Kayz requested to merge mlong/webv4mail into master
1 unresolved thread

webv4 header should show count for unread mail instead of all mail (using new user.stats.unread_mail_waiting)

Merge request reports

Pipeline #1000 passed

Pipeline passed for e3f483a1 on mlong/webv4mail

Merged by Rob SwindellRob Swindell 4 years ago (Dec 12, 2020 7:14am UTC)

Merge details

  • Changes merged into with 91731097.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
6 6 if (user.number < 1 || user.alias == settings.guest) return;
7 7 if (time() - last_run <= frequency) return;
8 8 last_run = time();
9 const count = user.stats.mail_waiting;
9 const count = user.stats.unread_mail_waiting;
  • Ideally, you would make something like this backwards compatible:

    const count = typeof user.stats.unread_mail_waiting === "undefined" ? user.stats.mail_waiting : user.stats.unread_mail_waiting;

    So if someone wanted to, they could run newer ecweb with older sbbs. There may be other reasons preventing use with the current webv4 with older sbbs however.

  • Please register or sign in to reply
  • merged

  • Rob Swindell mentioned in commit 91731097

    mentioned in commit 91731097

  • Please register or sign in to reply
    Loading