update doorscan to work with current synchronet pre/post xtrn modules

Should get Deuce's approval since he wrote this.

added 1 commit

• e7ee31de - Update lbshell.js - don't even need doorscan in here as it can be...

Compare with previous version

assigned to @Deuce and unassigned @rswindell

i don't remember now why i did that, but there are only ever 2 params args we need (0 and 1), will never need more than that. first one is action, second one is external code. not that this would happen, but it does avoid issues if they were to pass the same argument multiple times (either because they didn't know what they were doing, or they actually had a door with an external code "scan", etc.)

There's a lot of why there... why make command-line parsing more limited and harder to extend, why check the truthiness of argv[0] and arv[1] rather than checking if they exist, why hard-code argument numbers when it previously wasn't, etc.

Previously, argv of ["run", "scan"] never executed the doScan() function as i was incremented when run was parsed.

Maybe the question from @Deuce is "Why check the length of argv[0]"?

added 1 commit

• 63912e82 - change arg handling

Compare with previous version

modified

closed

reopened

added 1 commit

• 4fb69a36 - deuce feedback

Compare with previous version

approved this merge request

One thing that's not clear... the title is "update doorscan to work with current synchronet" but there's no indication of how it previously didn't work. A message to that effect in the commit message (wherever that is) would be helpful.

can you even ammend a commit message after its been pushed? rob or you might be able to when he merges it. basically what i was trying to say is it is updated to work with the pre/post xtrn modules

gitlab might use the title of the merge request when you merge it, i'll try that

changed title from update doorscan to work with current synchronet to update doorscan to work with current synchronet pre/post xtrn modules