Skip to content
Snippets Groups Projects

Update letsyncrypt.js

Closed Michael J. Ryan requested to merge tracker1/sbbs:master into master
1 unresolved thread

Makes the hostname and email address used with registration configurable to something other than system.inet_addr. In case system has a different host name than the internet email domain.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Michael J. Ryan added 1 deleted label

    added 1 deleted label

  • @rswindell This seems to address the issue(s) I was having regarding trying to run letsencrypt and it adding in an invalid domain for the system/host.

  • Maintainer

    Possibly this should just switch both to use system.host_name instead of inet_addr. The idea that the system does not know it's own domain name seems highly flawed.

  • Deucе mentioned in issue #207 (closed)

    mentioned in issue #207 (closed)

    • @Deuce I tried that... and it still used the same host as inet_addr not the Hostname specified in sbbs.ini. (at least when run via jsexec, not sure if a timed event would have the same issue).

      I have roughneckbbs.com on a separate server from synchronet... but synchronet is handling mx for the domain. The changes in this pr allowed it to be configured and work as such.

    • Maintainer

      Right, the point is though that separate configuration shouldn't be required. The system should be able to use the web Hostname and be correct (see #207 (closed) for details). Currently that's not supported, but it should be simple to write a JS script or add more JS objects to get that information. You shouldn't need to configure the same thing (ie: web server public hostname) in multiple places (sbbs.ini and letsyncrypt.ini).

      As more and more things generate URLs for the web server, this issue will just get worse.

    • Please register or sign in to reply
  • Maintainer

    Updated and committed as d4bdf4ff

  • closed

Please register or sign in to reply
Loading