Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • dailybuild_linux-x64
  • dailybuild_win32
  • sqlite
  • rip_abstraction
  • dailybuild_macos-armv8
  • dd_file_lister_filanem_in_desc_color
  • mode7
  • dd_msg_reader_are_you_there_warning_improvement
  • c23-playing
  • syncterm-1.3
  • syncterm-1.2
  • test-build
  • hide_remote_connection_with_telgate
  • 638-can-t-control-c-during-a-file-search
  • add_body_to_pager_email
  • mingw32-build
  • cryptlib-3.4.7
  • ree/mastermind
  • new_user_dat
  • sbbs320d
  • syncterm-1.6
  • syncterm-1.5
  • syncterm-1.4
  • sbbs320b
  • syncterm-1.3
  • syncterm-1.2
  • syncterm-1.2rc6
  • syncterm-1.2rc5
  • push
  • syncterm-1.2rc4
  • syncterm-1.2rc2
  • syncterm-1.2rc1
  • sbbs319b
  • sbbs318b
  • goodbuild_linux-x64_Sep-01-2020
  • goodbuild_win32_Sep-01-2020
  • goodbuild_linux-x64_Aug-31-2020
  • goodbuild_win32_Aug-31-2020
  • goodbuild_win32_Aug-30-2020
40 results

logfile.cpp

Blame
    • Rob Swindell's avatar
      5f89c517
      De-duplicate repeated errors logged via sbbs_t::errormsg() by reducing severity · 5f89c517
      Rob Swindell authored
      ... from ERROR to WARNING, so the repeats won't be logged to error.log file
      and won't (normally) be sent as notifications (e.g. emails) to the sysop. The
      duplicates are identified as from the same source file and line number as the
      immediately previous logged error within the last 12 hours. String comparison
      doesn't really work for deduplication since if you look closely, the errors
      usually are *not* exact duplicates (i.e. there's a node number or a socket
      descriptor or something that uniquely identifies the user/client/session).
      Repeated errors don't increment the node's error counter either.
      
      This does not de-duplicate errors logged via other means (e.g. direct calls to
      log()/lputs(),lprintf() with a severity of LOG_ERR or higher), but will
      solve the majority of duplicate errors that can be logged from the terminal
      server.
      
      So this at least partially addresses issue #619.
      5f89c517
      History
      De-duplicate repeated errors logged via sbbs_t::errormsg() by reducing severity
      Rob Swindell authored
      ... from ERROR to WARNING, so the repeats won't be logged to error.log file
      and won't (normally) be sent as notifications (e.g. emails) to the sysop. The
      duplicates are identified as from the same source file and line number as the
      immediately previous logged error within the last 12 hours. String comparison
      doesn't really work for deduplication since if you look closely, the errors
      usually are *not* exact duplicates (i.e. there's a node number or a socket
      descriptor or something that uniquely identifies the user/client/session).
      Repeated errors don't increment the node's error counter either.
      
      This does not de-duplicate errors logged via other means (e.g. direct calls to
      log()/lputs(),lprintf() with a severity of LOG_ERR or higher), but will
      solve the majority of duplicate errors that can be logged from the terminal
      server.
      
      So this at least partially addresses issue #619.