Skip to content
Snippets Groups Projects
Commit 6812da2f authored by Rob Swindell's avatar Rob Swindell :speech_balloon:
Browse files

Fix CID 319174 (Out-of-bounds write) correctly

This Coverity reported issue was previously resolved (incorrectly) with
commit 0c441424 which also introduced a bug that ate all the unexpected
cursor position report characters (causing issue #304).

The correct fix was to compare the response length against the buffer size
minus one, to leave room for the NUL terminator.

While fixing this and issue #304, I noticed that this function was using the
response length ('rsp') as both the state machine state and string length,
which didn't work right if a nearly-matching report/response was received:
the x/y values would have been stripped from the response before stuffing
in the keyboard input buffer. So a bit of a refactor here using a proper
state machine variable.
parent 25b0e6d7
No related branches found
No related tags found
1 merge request!463MRC mods by Codefenix (2024-10-20)
Pipeline #3327 passed
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment