Skip to content
Snippets Groups Projects
Commit b656e19f authored by Rob Swindell's avatar Rob Swindell :speech_balloon:
Browse files

Report error when menu() can't find a display file and P_NOERROR not used

This issue was introduced in commit d02fc1a2 (3 years ago), where menu() would
silenty fail (just return false) if no display file matching the supported
menu/display file types/extensions could be found.

Previous to commit d02fc1a2, we would log a NOTICE-level message and display
a "File not found" message to the user (what sbbs_t::printfile() does), but
since d02fc1a2, we no longer even call printfile() when the file doesn't
exist, so no error was logged or message displayed to the user.

Of course, when using the P_NOERROR mode flag, silent failure is expected and
that's still what happens in that case.
parent 5c269315
Branches
Tags
No related merge requests found
Pipeline #6779 failed
......@@ -282,8 +282,11 @@ bool sbbs_t::menu(const char *code, int mode, JSObject* obj)
}
if(menu_exists(code, next, path))
break;
if(!menu_exists(code, last, path))
if(!menu_exists(code, last, path)) {
if(!(mode & P_NOERROR))
errormsg(WHERE, ERR_CHK, path);
return false;
}
} while(0);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment