Skip to content
Snippets Groups Projects
Commit b8e2c852 authored by Rob Swindell's avatar Rob Swindell :speech_balloon:
Browse files

Add/use sbbs_t::fremove() to remove files with logged error on failure

This should resolve CID 487088: Unchecked return value from library
as well as add some more instrumentation upon unexpected failures removing
files.

Consider: do some callers of this function need to know the success status
(return bool)? That then starts to get into the some callers check and some
don't situation (Coverity issue). For now, this is a void function.

Also, all remove failures are logged as errors. Consider possibly passing
a log level and calling lprintf() instead of errormsg(). errormsg() displays
a notice to the user, which maybe we don't want.
parent 3711e03a
No related branches found
No related tags found
1 merge request!455Update branch with changes from master
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment