- Nov 16, 2016
-
-
rswindell authored
There (will be) the possibilty to cast mutliple votes in a single vote-msg (ballot), when multi-choice polls are introduced later. There were just too many things call vote/votes and it was getting confusing in my own head. So the msg type for messages that contain votes is now "ballot". smb_voted_already() now returns uint16_t (instead of BOOL), returns the votes of the user (for polls) or just 1 for up/downvotes of msgs.
-
- Nov 15, 2016
-
-
rswindell authored
they don't fill your error.log file up.
-
rswindell authored
field can have that line automatically stripped from the displayed header: - The \r\n's were moved from the end of the MsgSubj and MsgAttr strings to the beginning of the MsgAttr and MsgTo strings. Also, fixed the number in the VoteMsgUpDownOrQuit comment. Removed "I'm" from the "Sorry.." vote related strings.
-
rswindell authored
console input on Windows (e.g. the prompt() method no longer worked). This change was related to his JSDoor work, so that might be broken now.
-
rswindell authored
SMBLIB dependency to projects (e.g. filelist) that don't already have it.
-
rswindell authored
invalid conversion from æconst char*Æ to æchar*Æ
-
rswindell authored
-
rswindell authored
- wasn't opening sub-board correctly (now using new smb_open_sub) - for single-hope QWK packets, wasn't setting the sender netaddr (QWK-ID)
-
rswindell authored
"the right way", this will be used to replace a lot of copy/pasta over time.
-
- Nov 13, 2016
-
-
rswindell authored
MsgDownVoteNotice. Also moved the R_Voting string, so the last few voting related strings in the text.dat have been re-arranged (sorry about the thrash) - if you don't have these new 8 lines, the default strings are used and you're fine. When listing messages from the "Reading" prompt, the vote status and Replied attribute flag are now indicated: 'V' = voted up (more than down), 'v' = voted down (more than up), and 'R' = replied-to. Unread/new messages still show a '*' in the A (for attributes) column. Voting via JS still does not automatically send a notice to the poster, that still needs to be worked out.
-
rswindell authored
(new header properties: upvotes and downvotes), regardless of the "include_votes" argument value (default: false). get_all_msg_headers() reads the entire index already, so there's really no performance penalty unless there are actual votes (and even then, very low). The MsgBase.get_msg_header() function will *not* return these vote totals since that would incur a pretty substatial performance hit on that function.
-
rswindell authored
-
rswindell authored
(like save_msg), except you only need a few properties, in order of importarnce: attr: you need to have this set to MSG_UPVOTE, MSG_DOWNVOTE, or MSG_VOTE thread_back or reply_id: either of these must be set to indicate msg to vote on from: name of voter from_net_type and from_net_addr: if applicable
-
rswindell authored
sends a short message (telegram) to the poster of the vote. It also confirms this is not a duplicate vote.
-
rswindell authored
-
rswindell authored
-
rswindell authored
first (performing any reply_id look-up necessary). That functionality was moved to postmsg.cpp->votemsg().
-
rswindell authored
visible in resource view).
-
- Nov 12, 2016
-
-
rswindell authored
-
rswindell authored
- smb_addhashes() could leave the *.hash file open if passed no hashes - smb_hashmsg() should not be hashing votes (unnecessary)
-
rswindell authored
not the sender net *type* (the net-type is passed-in). This did result in a crash when parsing a voting.dat that contained a networked vote. Oops.
-
rswindell authored
pointer.
-
rswindell authored
belong (with the function prototypes).
-
rswindell authored
- get_msg_index() - get_msg_header() - get_all_msg_headers() these functions all accept a new (optonal, last) bool argument "include_votes" which defaults to false. So if for some reason, you want to load votes, just pass an additional 'true' argument. ToDo: polls and vote tallying. At least for now, existing JS stuff that uses the MsgBase object won't get messed up by the new voting messages.
-
rswindell authored
replied to. This may be used later for thread loading optimization (no need to load headers if there are no replies) - but for now, at least there will be a "Replied" attr value displayed in the message header indicating that the message was replied to. This attribute was previously only used in the "mail" base (for personal email/netmail). Also, I think I fixed what could have been an infinite loop if there was SMB corruption: if a message's thread_next value pointed back (to an earlier message, with a lower message number), we could have been caught in an infinite loop looking for the last message in the thread. This is just a theoretical problem and never reported, but apparently possible with just the right kind of corruption of the msgbase header.
-
- Nov 11, 2016
- Nov 10, 2016
-
-
rswindell authored
These messages would actually already be ignored due to the lack of a message body, but by checking the message attributes (and redundant msg 'type'), the msg headers for votes & polls aren't even loaded into memory. SBBSecho v2 should work just fine with msg bases that contain votes or polls as well.
-
rswindell authored
-
rswindell authored
- Sub-boards can be disalbled for voting in SCFG Removed un-implemented "kill msg when read" sub-board option.
-
rswindell authored
- Users can be restricted from voting with the 'V' restriction - Sub-boards can be disalbled for voting in SCFG - VOTING.DAT can be include/excluded from QWK packets via user cfg (when a VOTING.DAT is received in a REP, the user cfg flag is auto-set) - Adds several new text.dat lines (if not present in yours, uses the default) What's not yet implemented: - Notification of votes on your posted messages - Method to view/audit all votes - Polling - Any special handling to auto-exclude votes from msg-related JavaScripts
-
rswindell authored
Using msg attributes to indicate polls and up/down votes since attributes are stored in the index and enables fast vote tabulating/searching.
-
- Nov 08, 2016
-
-
rswindell authored
The beginnings of an SMB-based voting system - very experimental: The concept is that a "vote" message can be used to reply to: 1. A normal message, as either an upvote or a downvote, ala social media 2. A poll, polls can either allow a single choice answer or multiple answers Vote messages won't be visible as normal messages (e.g. when reading messages online) and SMB processing software (e.g. SBBSecho) should ignore these messages because they have no body text. Polls are going to need more work, but the idea is to have the poll question as a single (newly defined) hfield and the possible answers as dfields.
-
rswindell authored
mode for a specified message base (mail or sub-board). This logic exists in many other files and can now be consolidated using this single function.
-
rswindell authored
Use fopen/fprintf (buffered writes) rather than open/write. Use safe_snprintf() and SAFEPRINTF for safe string formatting. Use a variable for line-endings (in preparation for support for Unix-style log files for those sysops that prefer them). hacklog() now supports a NULL 'text' argument.
-
rswindell authored
loginFailure() now handles a NULL password argument correctly.
-
- Oct 19, 2016
- Oct 17, 2016