Fixes a stale non-zero error_count retained topic.

Pretty much any From field that contains an '@' in the username portion
was subject to comparison to the full email address, but clearly some of
these rejected emails were not forge attempts:

'Chris @ StubHub' vs 'events@mail.stubhub.com'
'Eric S. Raymond (@esr)' vs 'gitlab@mg.gitlab.com'

Fixed by requiring that the sender name is actually a well-formed Internet
email address using smb_netaddr_type(), which was also recently improved to
be more accurate.

Unrelated change: include reverse-path (email address for bounces) in
ILLEGALLY-LONG body and header line log messages (usually SPAM from what
I can tell).

... instead of undefined, to match what the documentation already stated.

smb_netaddr_type():
- if passed NULL or a string that begins with whitespace, now returns NET_NONE.
- if passed a string that begins with '@', now returns NET_UNKNOWN.
- if the user.name portion of an otherwise value Internet email address
  contains a space, now returns NET_NONE.

smb_get_net_type_by_addr()
- if passed a string that begins with '@', now returns NET_UNKNOWN.
- if passed a string with space following '@', will now return NET_UNKNOWN.
- if passed a string without a dot following '@', will never return NET_INTERNET.

Unrelated change: Add the missing FILE attribute to smb_msgattrstr()

Fix 2 issues with commit 680e30d8:
1. Need to replace @-code globally, otherwise only the first @-code was replaced
2. Need to strip the leading and trailing @'s from the code before passing to bbs.atcode() - fix for issue #527

SMTP commands have a shorter limit (510 versus 998) and the body text line limit needed to account for dot-stuffing. 

And some trailing white-space

Log a warning message and send a "500 Line too long" before disconnecting any SMTP client that sends lines > 998 characters in length. Technically, we can handle lines up to 1023 characters, but then we could get out of sync with the client if it sends exactly 1023 chars and then a new-line char (which we would interpret as a blank line, separating the message header and body) - so just punt the client who doesn't obey the rules of the protocol.

Update newuserdefaults() to use the new sysop-configured Chat and QWK new user settings/values (commit 56b8fd86).

Use newuserdefaults() in newuser.cpp and makeuser.c, eliminating a lot of copy/pasta.

ddfilelister: Now supports being used as a loadable module for Scan Dirs and List Files (applicable for Synchronet 3.20+)

See merge request !260

Added chat-settings to SCFG->System->New User Values->Toggle Options
Added new menu: SCFG->System->New User Values->QWK Packet Settings

Moved SCFG->System->New User Values->Question Toggles to:
      SCFG->System->New User Prompts...

This fixes issue #11

This includes a new JS bbs method: bbs.chat_sec()

And the old command shells written in Baja now call the PCMS
chat_section function, as they used to, rather than hard-coding the
name of the module to execute.

Most sysops didn't know it, but if exec/feedback.* existed, it would be
executed just before any user sent an email to the sysop (user #1),
excluding new user validation requests:
- make this module name configurable and loadable from mods
- support JS module here (exit(1) to abort the feedback)
- invoke for email being sent to *any* sysop (not just user #1)
- don't invoke the module when sending *from* a sysop account

This fixes issue #16

This fixes issue #525

Thanks to Nelgin for providing the test platform.

Apparently the cwd is changed back after ever command is invoked.

You want to replace the built-in batch file transfer menu with your own
loadable module across all command shells? Now you can.

<nelgin> git -C /home/bbs/sbbs/repo remote set-url origin https://gitlab.synchro.net/main/sbbs.git
<nelgin> Unknown option: -C
<nelgin> using GNUMakefile on CentOS 7

This partially reverts commit 34909899

Apparently I missed this in commit bcce78c6.

Many dynamically-generated (e.g residential) hostnames are much > 30
chars. And we can now increase user.tab fields fairly arbitrarily, so
let's. :-)

Also rename LEN_COMP to LEN_HOST. Some day I'll change all the user_t
comp references to 'host', but not today.

Reversed the order of the pwmod date and the password itself.
The number of chars of the user's password displayed depends on the
terminal width. e.g. on an 80 column terminal, 18 chars will be
displayed. If the user's password is longer than what can be displayed,
this is indicated with a trailing "..". Wider displays (e.g. 132 column)
can display all 40 chars of a user's password.

This fixes issue #442

When passwords aren't displayed (due to sysop configuration), show
"<hidden>" instead of "XXXXXXXX" to make that more clear.

Reversed the order of the pwmod date and the password itself.
The number of chars of the user's password displayed depends on the
terminal width. e.g. on an 80 column terminal, 18 chars will be
displayed. If the user's password is longer than what can be displayed,
this is indicated with a trailing "..". Wider displays (e.g. 132 column)
can display all 40 chars of a user's password.

This fixes issue #442

When passwords aren't displayed (due to sysop configuration), show
"<hidden>" instead of "XXXXXXXX" to make that more clear.

Pass argument of 'true' to clear upload queue, otherwise download queue
is cleared.

This fixes issue #488

We don't yet really work with a 0-byte main.ini file, but this gets
us a little closer.

and prefixes, suffixes.

I'm using this on cvs.synchro.net along with an override.conf file in
/etc/systemd/system/ircd.service.d/

[Service]
ExecStart=
ExecStart=/sbbs/exec/jsexec -A -L7 -hcvs.synchro.net ircd.js -a cvs.synchro.net
LimitCORE=infinity

My /etc/resolv.conf was wiped by Network Manager (gee, thanks), so
ircd.js was throwing the following unhelpful exceptions when starting
up:
Feb 25 13:47:51 git jsexec[19108]: !JavaScript : uncaught exception: Unable to create any sockets
Feb 25 13:47:51 git jsexec[19108]: !JavaScript : uncaught exception: Unable to create any sockets

First, instead of throwing a string, throw an Error object so we can
actually know where the exception ocurred. Please, everyone, throw Errors
not Strings.

Second, throw a different more helpful exception if there are no nameservers
specified in the DNS constructor or configured on the system.

ddfilelister: Now supports being used as a loadable module for Scan Dirs and List Files (applicable for Synchronet 3.20+)

DDMsgReader: Ctrl-C can now cancel message scans, and message scan status text is word-wrapped for the terminal width

Closes #522 and #523

See merge request !259

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Ctrl-C can now cancel message scans, and message scan status text is word-wrapped for the terminal width

They were too hard for me to read before, being all high intensity.

Remove the (now) unnecessary explicit initializations (e.g. to zero, blank, etc.) from the sbbs_t constructor.

Fixes issue #311

Also clarify "Internet e-mail" address (unrelated)

Apparently Paul made some changes (nobody reports these things).