flags set manually in SCFG.

(messages which contain the RESCANNED control line) to downlinks.

Also renamed pkt_to_pkt() to write_to_pkts().

"Conditional jump or move depends on uninitialised value(s)"
Thanks, Nelgin.

If the ctrl/ssl.cert file did not exist, the various TLS/SSL services would
fail to create it and (sometimes) log the "creating SSL context" error.
This problem was introduced with rev 1.30 (Mar-9) and the fix/patch
provided by Deuce via irc. Thanks to Psi-Jack for the bug report.

(previuosly) silently fail - in the sendmail_negotiate() and pop3_thread().
If get_ssl_cert() can return -1 withOUT setting the estr argument to a
non-NULL value, then we could still have silent failures (TBD).

(out of disk space?).

properties to msg_area object. See NMAIL_* in sbbsdefs.js for the bit values.

- finduser() method no longer prints "Unknown user" upon failure (the calling
  script can do this if/when it wants).
- read_mail() method now accepts an optional 3rd argumnet (loadmail_mode)
  which may be used to load *only* un-read mail (for example), see LM_* in
  sbbsdefs.js

Pass the lm_mode as a 4th argument to any readmail mod (if one is installed) -
this correlates with the LM_* mode flag values (0 is normal/usual).

File attachments can also be in a file/####.out directory (e.g. outbound
Internet email attachments), so try deleting from there too when deleting
mail with attachments.

- similar to what we do in netmail() with the WM_NETMAIL flag.
If you call writemsg() without WM_EMAIL set, it tries to use the subnum as an
index into the sub-board array and will crash.

var text = load({}, 'text.js');

(not the absense), so we need to call it twice to find out if there are
any unread messages for the user.

Change the 'Edit Author's user account' command to '!' (for now).

user.dat file open (for read operations only). Writing still opens and
closes the user.dat for each property/field modification.

made their display conditional on mailer-type being set to FLO/BSO.
Added a help menu to the BinkP Settings menu (under Linked Nodes).

more control over SBBS-initiated netmail source/origin addresses.

user choose which address to use as the source address when composing a netmail
message (the default being the most appropriate for the dest zone/net). This
change only works with SBBSecho v3.05 or later.
Some other incremental and safety improvements to sbbs_t::netmail() too.
FTN netmail file attachments needs some more work however (the "FA:" subject
prefix trick) - just remove it?

If the SMB header contains a source FTN address, use that as the origin address
of the netmail and do not look-up a local AKA match for the destination address.
Also, fix what appears to have been a (currently harmless) bug in
smsg_to_echostat_msg(): the msg.from_net.addr is not an ASCIIZ string when
net.type == NET_FIDO. Currently, source FTN addresses aren't set in echomail
message headers, where the echostats come from. Could just remove
these 2 lines.

When the local system has multiple AKAs for the same zone and we are picking a
origin/source address suitable for the destination address, pick the AKA that
matches both the zone and net of the destination address first (if there is
such a local AKA). It's the same logic used in sbbs_t::netmail() to display
the originating address, so the AKA picking logic now matches what is shown
to the netmail author and what SBBSecho will actually use.

(apparently this is a pseudo-standard supported by fastecho and other
"old-school" tossers) - per mark lewis' request.

existing tear/origin lines and don't add a new origin line.

"expand fields" could be misinterpretted (e.g. as 'false') if less than 3
args were passed to the function. Apparently you can NOT assume that argv[argc]
is undefined and would fail a JSVAL_IS_BOOLEAN test. In the reported problem,
MsgBase.get_msg_header() was being called with 2 arguments (from newslink.js)
and the if(JSVAL_IS_BOOLEAN(argv[n])) test, when n was 2, would eval to true
and then argv[n] evalulated as false, which would cause a message with no
message ID to not have one dynamically created, which would then cause the
message to fail to post to an NNTP server due to malformed Message-ID (a
missing message "id" property would end up being included in the newsgropu
article header as "Message-ID: undefined").

get_msg_index() had a similar potential issue, also fixed.

Also, use a stack pointer if the passed failed pointer is NULL.

length, just delete it (don't rename to *.?_?).

new contents,
Instead truncate to the new length after writing the new contents. This should
make the files more tolerant of "out of disk space" situations and reduce
the risk of lost data (0-byte files) due to low/no free disk space.

instead truncate to the new length after writing the contents. This should
make mail.sid files more tolerant of "out of disk space" situations and reduce
the risk of lost data (0-byte mail.sid files) due to low/no free disk space.

thus fixsmb) to fail, but just before exiting, fixsmb would delete the .lock
file (whoops). The msgbase.lock file means something else is rebuilding this
base (e.g. smbutil) and thus we can't just go deleting the .lock file, unless
we (fixmsb) was the one that created it.

left-justified server prefix), e.g. "term" now added for terminal server
errors.

- Using NOTCICE (not INFO) log level.
- Move the protocol name after Node X and remove the colon.

(e.g. warnings and errors).
Also, stripped trailing white-space from many lines (editor setting).

Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1) ...
from output_thread
Don't set ssh_mode=true until the ssh_session has been created successfully.

Also added some more debug output with regards to Cryptlib session number.

parameter 1' (-1) ... from output_thread

Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1)
 ... from output_thread

The bbs_thread() sets the global/server sbbs ssh_mode to false and ssh_session
to 0 (the "parameter 1" value used in the cryptlib function calls in
output_thread) but was doing this without owning the ssh_mutex, so the
output_thread had a race condition where it would check ssh_mode=true and
then use grab the ssh_mutex and use ssh_session in a few cryptlib function
calls. The fix for the bbs_thread() to grab the ssh_mutex before setting
ssh_mode to false and ssh_session to 0 and have the output_thread() re-check
the ssh_mode after grabbing the ssh_mutex and not call any cryptlib
functions if ssh_mode was set to false while waiting for the mutex.

The cause would have been more obvious if the various cryptlib error/log
messages contained the cryptlib session ID value (which was 0 in this case).

WARNING.
Also fixed a couple of typos in strings.

missing, but also now logging when renaming (or failing to rename) bad
received .REP packet files.

packet errors, no need to save such REP packets as .bad files.