Non-root users don't have write access to /var/run by default,
so don't use that as the default location of the pid file.

Some legacy Baja source files !INCLUDE SBBSDEFS.INC, but the filename is now
sbbsdefs.inc, which does not match on case-sensitive filesystems (e.g. Linux)
e.g.
BBSLISTR.ZIP:!INCLUDE SBBSDEFS.INC
FORSALE1.ZIP:!INCLUDE SBBSDEFS.INC
FWISH10.ZIP:!INCLUDE SBBSDEFS.INC
GUESS20.ZIP:!INCLUDE SBBSDEFS.INC
NU_SYNC.ZIP:!INCLUDE SBBSDEFS.INC
ONELINE1.ZIP:!INCLUDE SBBSDEFS.INC
ni-sbbs.zip:!INCLUDE SBBSDEFS.INC

This issue was reported via DOVE-Net by Rick Smith.

Automatically runs when main.ini new_install=true or the '-w' option is
passed to SCFG.

This doesn't ask all the same questions as the SBBSCTRL Config Wizard, but
it's a good start.

getdirsize() is maxed out at size_t, so return that type

This fixes issue #516

When changes are made using SCFG on these files, a 'git diff' is now helpful and readable to
see what changed.

The order of sections and keys change as a result.

Some extraneous stuff created by upgrade_to_v320.js was removed and some numeric values change
from hex to decimal encoding.

Resolve the QWKnet hub 'days' key in msgs.ini being written as -1

Not that most of these values should ever exceed 32767, but might as well

min_dspace is an *unsigned* short, so saving 65535 (the default) was converting
the signed decimal representation when saving file.ini.

Following the (now proper) naming introduced in commit 27bd91f6

upgrade_to_v320.js sets these values to just "0", so let's not thrash on the
format.

Resulted from upgrade_to_v320.js typo

SlyEdit: Small fix for sysop checking (didn't catch it in the earlier refactor)

See merge request !256

This appeared in the ChromeOS taskbar, so now it'll say
"Synchronet Configuration" instead.

The old NM_NO_NUM flag is unused/deprecated.

This fixes the issue (#515) that was introduced 9 months ago
(after the v3.19b release) with commit 77d72d0e.

Also:
	movefile() will now log an error message if addfile() fails.
	Fix the message logged when the file is successfully moved.

SlyEdit: For sysops, when importing a file, SlyEdit can optionally send immediately (if not, edit the message before sending). Useful for posting ANSI files

See merge request !255

js_init was assuming that startup != NULL

Fixes issue #398

SlyEdit: For sysops, when importing a file, SlyEdit can optionally send immediately (if not, edit the message before sending). Useful for posting ANSI files

Paul Hayton (fsxNet admin) had this idea. This seems to do the trick.

It does use the listed IBN (BinkP) address as a fall-back if the INA and ITN
addresses aren't specified, which may not be desireable.
So maybe that should be a command-line option to enable as desired. <shrug>

1) Unreachable return without a lock in sdl_useR_func_ret() (harmless)
2) LOR in handling SDL_USEREVENT
   - vstatlock was obtained inside of win_mutex which should never
     be done... this could (and likely does) result in a deadlock
     when using SDL mode.

New (optional) keys in ctrl/sbbs.ini (with defaults):
[BBS]
DefaultTermWidth=80
DefaultTermHeight=24

This fixes issue (feature request) #491

The default value is the same as the previously hard-coded value: 15 minutes.

Increase this value to prompt the sysop for the system password less frequently, decrease for more frequent.

This fixes issue #407.

The security-related options were really spread around and this menu was
getting very overloaded (the list of Toggle Options had grown huge), so now
most of the content is actually under the new "Security Options" sub-menu.

This does make a bunch of previous instructions/docs slightly out of sync
(e.g. SCFG->System->Security Level Values should now be
SCFG->System->Security Options->Security Level Values), but I think sysops
will still find stuff just fine.

This re-org will allow me to add more options that I've wanted to but needed
better organization and structuring to do so logically and clearly.

Using the memcmp() trick to detect changes in the configuration.

No new settings/option were added in this commit.

Off-by-one bug caused the comparison of only the first 3 chars of the proposed password against "QWE", "ASD", and "!@#" rather than the 4 character pattern match as intended.

These lines should be removed anyway since this can be easily achieved via password.can (as intended), but I couldn't help myself but to fix this ancient bug.

DDMsgReader: As a loadable module, now make use of user# parameter for reading personal email (for the sysop when deleting a user account)

See merge request !254

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: As a loadable module, now make use of user# parameter for reading personal email (for the sysop when deleting a user account)

... not before. This explains why FTP-uploaded actions had a (null) filename.

Requires the latest v3.20a for sytem.matchuserdata() to support deleted and
inactive user record searching.

This is part of the fix for the issue described in issue #513 where the
UEDIT sysop command was falling back (displaying/editing) user #1 because
the sysop-specified user number or alias was not an active user account.

The fallback to display/editing user #1 still happens, but first we try
really hard to find the user that the sysop specified as an argument to
the UEDIT command.

Insert an optional boolean argument to enable a search through deleted and
inactive user records (in addition to active user records). This is part of
the solution to the problem described in issue #513 where the UEDIT sysop
command did not go to a specified user (by alias) automatically, presumably
because the user record was marked as deleted.