Made some other cosmetic improvements/fixes.

for the user-to-user file transfer directory

This appears to be enough to make hatchit.js work again and file
listings in webv4 (not sure beyond that).

This file is now just an unnecessary shim and should go away when
the consumers (hatchit and webv4) no longer need it.

I did not "port" support for the file properties:
- base
- ext
- datoffset
- opencount
- misc
- altpath

They don't appear to be needed.

More use of the "conditional newline" (^A?) code rather than hard-coded
CRLFCRLFs.

This is still broken (errors when updating existing files) and is still planned for deprecation.

I forget who it was that said they were still using this feature in v3.18, but here you go, it's working again (the /D and /U commands). I'm not migrating any file sender/recipient info from v3.18, so only files added after upgrading to this will be downloadable from the "user" directory (if you have one).

Something that I never implemented before but noticed is missing is the removal (or dereferencing) of user-to-user files that were sent from/to a user that is then deleted. So that's still a TODO item.

dir is not a property of lib_list[], appears to be a typo.

Also, in the "lib" scope commands, j was not defined.

The offline_dir property appears to have been deprecated (no longer
enumerable) years ago, in favor of the dir/dir_list[].is_offline
property, so use that property instead for skipping offline dirs.
Reported by xbit (XBITBBS)

Also, make sure the ;upload and other lib/all search commands are
abortable with Ctrl-C.

Even though this is going to be removed / deprecated.

Reported by Daryl Stout (TBOLT)

Return int value for "string not found" rather than crash/segfault. Seems the better option.

Addresses CID 319116 and 319090

This started with a Coverity issue (CID 33230) which got me looking at this function and wondering: why is str2 being NUL-terminated here? Why is the length of str2 to be calculated on successive lines? What is with this (long)((long)((long)((long)) typecast?

This was some of the oldest code in Synchronet (along with a lot of the other functions in this file). I tried to keep as much intact as possible while still improving the logic and readability.

Do nothing if online != ON_REMOTE. Eliminates some if(online == ON_REMOTE) clauses.

Some QWKnet vote messages are failing:
evnt unpackREP <ENSEMBLE> !ERROR 2 (No such file or directory) in qwk.cpp line 1146 (qwk_vote) writing "/sbbs/data/subs/dove-gen" access=-105 info=smb_addvote thread_back field missing

Catch this problem a little higher up (in votemsg()) and log the message's reply-IDs to help determine what's the root-cause here. Don't bother calling smb_addvote() if thread_back is 0.

If a callback deletes the one-shot event that invoked it, the
event pointer in the caller would be to free()d memory with
hilarious results.

Upon connecting, a client will be sent a list of who's online on
the local BBS as well as other systems (if you and they are set
up for instant messaging). Updates will be sent for subsequent
events (logon, update, logoff).

Mostly intended for use by local consumers; you probably don't
need to open any ports for this.

Nothing uses this at the moment and you do not need to add it
to your config. Eventually it'll bring interBBS presence and
messaging back to webv4 and probably introduce a fancier textmode
imsg module.

CID 319108

CID 331092

Properly throw an error instead.

Fixes issue #252.

Just don't check the python version at all.  If your python is older
than 2.5, you're already having other issues.

but round-up non-zero values to 1K.

Appended very important trailing linefeed.

It's a wrapper for filedat.c -> format_filename() which can truncate and pad a filename for display purposes.

Tweak the poll() implementation to match.

Should fix #248

The biggest difference is that you can combine all files from multiple dirs
into a single sorted list and you can sort on any property (field) value.

The byte/credit format is very customizeable, the output format is completely
customizeable.

By default, just the filenames are output, but either use '-ext' or one or
more '-v' values to add more fields. Use -p=list to specify a comma-separated
list of properties to print.