- Dec 29, 2023
-
-
Rob Swindell authored
The old default Win32 console mode is still available via '-iw' option.
-
Rob Swindell authored
As pointed out by echicken: when setting the "cost" property to any value, the actual file's cost would be set to 9223372036854776000 regardless of what number was in the provided file metadata object. Most jsval numbers aren't doubles (they're ints) so need to use JS_ValueToNumber() to do the proper conversion, regardless of underlying type. Noticed the same problem with the "size" property. Thanks for the tests and report echicken!
-
- Dec 28, 2023
-
-
Rob Swindell authored
-
Rob Swindell authored
In Windows 11, "Windows Terminal" is now the default console (though the Windows user can change that to the old conhost.exe). Running UIFC apps (e.g. SCFG) in Windows console mode from within a Windows Terminal console doesn't always display correctly (depending on the width of the console). And even if if the app displays correctly at first in console mode, it's very easy for the user to resize the console window and just totally foobar the display of the app. Windows console mode (previously, the default interface mode) is still available ("-iw" option) if one wants to use it instead. However, stdio/door mode ("-id") and ANSI mode ("-ia") can't be used directly from a console. The help/usage output is sent in Windows console mode (not stdout or GDI mode) so it creates a new window, disables mouse support (so you can copy text from it). stdout doesn't work from GUI apps. Fun times.
-
Rob Swindell authored
This reverts commit fddbd721. Causes MSVC warning: msgtoqwk.cpp(249): warning C4309: 'initializing': truncation of constant value
-
Rob Swindell authored
This reverts commit e90e8f82. Apparently this causes issues with recognition of the QWK newline char (pi symbol, EX-ASCII 227) in QWK messages.
-
Rob Swindell authored
comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
-
- Dec 27, 2023
-
-
Rob Swindell authored
This fixes the issue reported by Nelgin with the [mail] RescanFrequency new default value of "1h" being interpretted as one second intead of one hour.
-
Rob Swindell authored
With this change, it's important you don't try to use a newer text.dat with an older sbbs (and perform a ;UPLOAD sysop operation). Previously, each file's size in (k)ibibytes was displayed, which is not very modern of us. Use the byte estimate (e.g. "1.2M") strings intead.
-
- Dec 26, 2023
-
-
Rob Swindell authored
We were appending .sig files to uploaded text, which may not have ended in an LF or CRLF sequence. This fixes that.
-
Rob Swindell authored
-
Rob Swindell authored
-
Rob Swindell authored
To eliminate confusion with the file-meta-object that this API deals with more than anything else. echicken's suggestion Nothing used this property before now, so this should be fine.
-
Rob Swindell authored
-
- Dec 25, 2023
-
-
Rob Swindell authored
echicken reported this problem: pretty severe filebase corruption as a result of calling FileBase.renew(). The problem seemed pretty obvious (only loading the file's index record), but I do think the underlying SMBLIB functions should be more resilient to misuse and not corrupt the base. So, that's still a TODO. No existing scripts were using FileBase.renew(), so this problem has gone unnoticed since SBBS v3.19.
-
Rob Swindell authored
which were result of QWK_NEWLINE redef to make cppcheck happy
-
- Dec 24, 2023
-
-
Deucе authored
SSH channels, I noticed that I hand't ever finished the terminal type/size "stuff", and while fixing that, I noticed that the hack for SyncTERM was done wrong. Fix the whole thing, and now Synchronet and SyncTERM both properly support terminal type and size over SSH. It also looks trivial to support the SSH window size change message, but I'm not doing that tonight. Unfortunately, this is a patch on a patch, so is a bit fragile. It should really have the patches merged at some point.
-
Deucе authored
-
Rob Swindell authored
-
Rob Swindell authored
netmail.cpp:411:25: error: Invalid strchr() argument nr 2. The value is -29 but the valid values are '0:255'. [invalidFunctionArg] char* tp = strchr(to, QWK_NEWLINE); /* chop off at first CR */
-
Deucе authored
-
Deucе authored
Just a proof-of-concept for right now, there's a couple major changes and some minor changes that will need to be made before this can actually be enabled. Not really testable without some seriously terrible hacks right now, but it has been verified with the sftp client that ships with openssh (which is based on a 20-year-old internet draft that is both expired and superceded).
-
- Dec 23, 2023
-
-
Rob Swindell authored
This was not a real leak, but still, good practice
-
Rob Swindell authored
-
Rob Swindell authored
error: Uninitialized struct member: node.misc [uninitStructMember]
-
Rob Swindell authored
[integerOverflow]
-
Rob Swindell authored
-
Rob Swindell authored
Where ever we assign the realloc() result to the same pointer we pass, use this new function instead to eliminate the cppcheck error reported by Nelgin: Common realloc mistake: 'p' nulled but not freed upon failure [memleakOnRealloc] This isn't going to actually solve any memory leaks, it's just good practice for critical error (e.g. no memory error) handling.
-
Rob Swindell authored
... weird this wasn't required before now. Removed obsolete DSTSEDIT target.
-
Rob Swindell authored
Resolves 'make sexyz' build issue mentioned in issue #690
-
Rob Swindell authored
Fix up the 'utils' target a bit List all the add'l sub-build targets in 'help' output
-
Rob Swindell authored
Add -host=<name> option to set the hostname to use for alternative sbbs.ini file.
-
- Dec 22, 2023
-
-
Rob Swindell authored
Fix CID 471381
-
- Dec 21, 2023
-
-
Rob Swindell authored
The JS objects will still log to the terminal server (regardless of which server created/used the objects) however - so that's still a TODO. Change do_cryptInit() to return bool, since it does. Log detailed error if pthread_once() call fails. Lowered-severity (to DEBUG) the log messages related to TLS private key and cert creation and destruction. FIrst commit from within MSVS, so this might look weird.
-
Rob Swindell authored
... wasn't accounting for length of the 'top' buffer (when supplied). Also, for raw input mode: - flush the input buffer (stray LF) before accepting input - turn off raw input mode if run out of bytes (max lines/length reached) I was investigating the reported error by Nelgin: !ERROR in writemsg.cpp line 1214 (msgeditor) checking "max lines (20) exceeded" access=46 which I was unable to reproduce, when I encountered the issues addressed in this commit.
-
Rob Swindell authored
-
Rob Swindell authored
... for server configuration dialogs
-
Rob Swindell authored
-
Rob Swindell authored
-
- Dec 20, 2023
-
-
Deucе authored
-