Should probably make this a command-line option too, but this will do for
now for Ragnarok to test eternal-september with.

This partially reverts commit 44c3350f where a bunch of read() and write()
return value checking was added.

The proper sentinel value here for "no TLS session" is -1, not 0.

This, at minimum, was causing a lot of extraneous calls to destroy_session()
(from js_socket.c's do_js_close()) with an invalid (hopefully, not
otherwise used) cryptlib session ID of 0.

Nothing checks or logs the return value of destroy_session(), but I'd expect
it to be failing ... a lot.

DDMsgReader configurator: Added a default for displayIndexedModeMenuIfNoNewMessages in case it's not in DDMsgReader.cfg

See merge request !384

DDMsgReader configurator: Added a default for displayIndexedModeMenuIfNoNewMessages in case it's not in DDMsgReader.cfg

Most DOVE-Net subs were already configured this way, but not all.

This was broken one year ago in Commit 9db5d2a2

Thanks for the report (just now) about this bug Max!

The year is 4 digits, so the offsets aren't the same as the other 2 supported
formats. Doh!

Thanks Max for testing!

Merge branch 'ddmr_show_indexed_newscan_menu_after_reading_new_msgs_and_full_indexed_reader_mode' into 'master'

DDMsgReader: New user-toggleable behavior: Show indexed menu after reading all new messages. Indexed reader mode (with -indexedMode command-line parameter) uses all sub-boards instead of just newscan sub-boards

See merge request !383

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: New user-toggleable behavior: Show indexed menu after reading all new messages. Indexed reader mode (with -indexedMode command-line parameter) uses all sub-boards instead of just newscan sub-boards

Fix issue #693

... using WIN_FIXEDHEIGHT mode to limit the list height in wizard mode.

I had a solution using a negative width param value to specify a height limit,
but then I saw this code in ulist():
```
	if(mode&WIN_FIXEDHEIGHT) {
		height=api->list_height;
	}
```

something Deuce added for SyncTERM and I don't think I've ever used before.
It works.

In T2B (top to bottom centering) mode, the 'top' parametr value isn't actually
for the top of the window position (later), so just zero it here in case it
was specified (and non-zero) to correct the calcutation on the next lines:
```
	if(top+height>s_bottom)
		height=(s_bottom)-top;
```

This also addresses the addresses with 65535 in them in the new debug-level
log messages "New packet (type x) created for linked-node" .

Should fix issue reported by Floffy on IRC.

To complete the request from: Max (WESTLINE)

  Is it possible to do a new dateformat in scfg
  In sweden we using YYYY-MM-DD format as standard.

The default will be '/'.  Technically, any separator is possible by editing
the "date_sep" value in the global section of main.ini.  SCFG allows the
most popular separators: /.- and space.

... and YYYY/MM/DD for birthdate input/display.

Now set in SCFG->System (not toggle options) and stored in the "date_fmt" key
(new) in main.ini. The old sys_misc SM_EURODATE flag is deprecated (but used
to determine the default value of date_fmt when not present).

As requested from: Max (WESTLINE)

  Is it possible to do a new dateformat in scfg
  In sweden we using YYYY-MM-DD format as standard.

Merge branch 'dd_msg_reader_indexed_newscan_no_messages_dont_display_if_already_displayed_indexed_menu' into 'master'

DDMsgReader: With the indexed menu, don't show "No new messages" if the indexed menu has already been displayed

See merge request !381

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: With the indexed menu, don't show "No new messages" if the indexed menu has already been displayed

This completes the revert of commit c22063f9 from (Jun-2-2016). The Baja
part of that commit was reverted in commit 932fae30 (Nov-15-2016). This
behavior has proven to be surprising and annoying for JS mod developers
(e.g. the yesnobar.js and Nightfox's file searcher/scanner).

If we still need clearing of abort status after running JS "externals",
that should probably be done in exec_xtrn(), not here.

Should calm the clang warnings reported by Deuce:

e.g.
passing 'char *[18]' to parameter of type 'const char **' discards qualifiers in nested pointer types

CID 476253