This reverts commit fddbd721.

Causes MSVC warning:
msgtoqwk.cpp(249): warning C4309: 'initializing': truncation of constant value

This reverts commit e90e8f82.

Apparently this causes issues with recognition of the QWK newline char
(pi symbol, EX-ASCII 227) in QWK messages.

comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]

This fixes the issue reported by Nelgin with the [mail] RescanFrequency new
default value of "1h" being interpretted as one second intead of one hour.

With this change, it's important you don't try to use a newer text.dat with an
older sbbs (and perform a ;UPLOAD sysop operation).

Previously, each file's size in (k)ibibytes was displayed, which is not very
modern of us. Use the byte estimate (e.g. "1.2M") strings intead.

We were appending .sig files to uploaded text, which may not have ended
in an LF or CRLF sequence. This fixes that.

To eliminate confusion with the file-meta-object that this API deals with
more than anything else.

echicken's suggestion

Nothing used this property before now, so this should be fine.

echicken reported this problem: pretty severe filebase corruption as a result
of calling FileBase.renew(). The problem seemed pretty obvious (only loading
the file's index record), but I do think the underlying SMBLIB functions
should be more resilient to misuse and not corrupt the base. So, that's still
a TODO.

No existing scripts were using FileBase.renew(), so this problem has gone
unnoticed since SBBS v3.19.

which were result of QWK_NEWLINE redef to make cppcheck happy

SSH channels, I noticed that I hand't ever finished the terminal
type/size "stuff", and while fixing that, I noticed that the hack
for SyncTERM was done wrong.

Fix the whole thing, and now Synchronet and SyncTERM both properly
support terminal type and size over SSH.  It also looks trivial to
support the SSH window size change message, but I'm not doing that
tonight.

Unfortunately, this is a patch on a patch, so is a bit fragile.
It should really have the patches merged at some point.

netmail.cpp:411:25: error: Invalid strchr() argument nr 2. The value is -29
  but the valid values are '0:255'. [invalidFunctionArg]
  char* tp = strchr(to, QWK_NEWLINE);  /* chop off at first CR */

Just a proof-of-concept for right now, there's a couple major changes
and some minor changes that will need to be made before this can
actually be enabled.

Not really testable without some seriously terrible hacks right now,
but it has been verified with the sftp client that ships with openssh
(which is based on a 20-year-old internet draft that is both expired
and superceded).

This was not a real leak, but still, good practice

error: Uninitialized struct member: node.misc [uninitStructMember]

[integerOverflow]

Where ever we assign the realloc() result to the same pointer we pass, use this new function instead to eliminate the cppcheck error reported by Nelgin:
Common realloc mistake: 'p' nulled but not freed upon failure  [memleakOnRealloc]

This isn't going to actually solve any memory leaks, it's just good practice for critical error (e.g. no memory error) handling.

... weird this wasn't required before now.

Removed obsolete DSTSEDIT target.

Resolves 'make sexyz' build issue mentioned in issue #690

Fix up the 'utils' target a bit

List all the add'l sub-build targets in 'help' output

Add -host=<name> option to set the hostname to use for alternative sbbs.ini
file.

Fix CID 471381

The JS objects will still log to the terminal server (regardless of which server created/used the objects) however - so that's still a TODO.
Change do_cryptInit() to return bool, since it does.
Log detailed error if pthread_once() call fails.
Lowered-severity (to DEBUG) the log messages related to TLS private key and cert creation and destruction.

FIrst commit from within MSVS, so this might look weird.

... wasn't accounting for length of the 'top' buffer (when supplied).

Also, for raw input mode:
- flush the input buffer (stray LF) before accepting input
- turn off raw input mode if run out of bytes (max lines/length reached)

I was investigating the reported error by Nelgin:
  !ERROR in writemsg.cpp line 1214 (msgeditor) checking
		"max lines (20) exceeded" access=46
which I was unable to reproduce, when I encountered the issues addressed
in this commit.

... for server configuration dialogs