uncrustify nl_split_if_one_liner setting

... using uncrustify mod_paren_on_return config

White-space changes only, exception being the rare insertion of NL before
closing brace (couldn't find the option to disable that behavior).

I excluded some header files (e.g. sbbs.h) since uncrustify seemed to be doing
more harm than good there. I might just end up applying different set of rules
to .h files.

Rob Swindell authored 2 months ago and Deucе committed 2 months ago

No functional change.

Hitting down-arrow key at a pause prompt normally displaye just one more line
of the display text/file, but if you received a node message/telegram/notice
after hitting down arrow, you'd get a screen full of text instead of just a
single (one more) line, as you wanted.

This looks to be because of the anti-recursive protection implemented in
pause() - when it calls nodesync() after the key press, that displays
node/user messages (if there are any) and if pause is called as a result
(e.g. because the line counter was already set to cause a pause after the
next line of output), it'd do nothing since that would be recursive. The fix
is to simply set the line counter as a result of the down-arrow key press
*after* the call to nodesync(), which might display multiple lines, but I
think that's fine.

getnodedat() now performs a non-locked read by default.

Perform more checks of getnodedat() return value before calling putnodedat()
to avoid unintentionally zeroing out node.dab records.

Add/use unlocknodedat() method for unlocking a node.dab record without
writing.

Note: The userdat.c getnodedat() and putnodedat() still return int (i.e. 0 on
success), so that can be confusing.

We want to not expand tilde to attributes when there are any attribute codes
in the mnemonics string. The existene of a non-attribute ctrl-a code should
not have prevented the tilde expansion.

Fix for issue #805 reported by Nelgin (thank you)

Fix for issue #800

... since these methods only feed the keyboard buffer.

Add an optional 'insert' argument to console.ungetkeys() - default is false
(append).

Add a new version of console.ungetstr() which feeds the passed characters
directly to the receive input buffer. Now returns bool indicating success.
Existing scripts (if any) that use console.ungetstr() should continue to work
just fine.

This is anticipation of telgate.js being able to stuff strings (e.g. username,
password) into the input buffer and those chars/keys being passed to the
remote (gatewayed) telnet server. Since the telnet gateway reads directly from
the receive input buffer (ignoring the keyboard buffer), we needed a way to
stuff strings of characters into the receive input buffer directly and that
sort of exposed the weirdness of the existing console.ungetstr() method:
- it didn't return a return value (not indication of failure)
- it didn't support an 'insert' operation (even though the underlying C++
  method does)
- it didn't use the sbbs_t method that already existed for feedding a string
  of characters into the input/keyboard buffer

If a sysop doesn't want this warning to do anything, then no need to save
and restore the current (last displayed) line of text.

WIPterm hasn't been supported in ages and HTMLterm was just an ephemeral
experiment.

Leave the WIP ARS keyword parsing support, for backwards script compatibilty.

The "default" mnemonic string attributes are still set in ctrl/attr.cfg,
but now, each mnemonic string (e.g. from text.dat or passed to JS
console.mnemonics()) can include a "MNE:" @-code to over-ride the default
mnemonic string attributes (low, high, and command). If the "high"
attribute isn't specified, it defaults to the same color as the "low"
attribute with the "high intensity" flag flipped. The "cmd" attribute
defaults to whatever was included in the attr.cfg, if not specified.
Technically, the separator between the attributes can be any non-valid
attribute character (e.g. symbol).

Renamed (really old function) attrstr() to strtoattr() since its usage now
more closely resembles other std C strto* functions (has an 'endptr' arg).

From SCFG->Nodes ... Toggle Options to SCFG->System->Toggle Options

And from a bit flag in node_misc to its own bool member of scfg_t.

getkeys() is actually never (currently) called with a NULL arg, so this
could not actually occur, but better to prepare for that eventuality.

This looks like a case of not following the YAGNI principle.

sbbs_t::mnemonics() now supports @-codes immediately following the tilde
(e.g. ~@Yes@) to use the first character of a dynamically-replaced
(e.g. localized/translated) text string as a command key.
Fixed issue in sbbs_t::mnemonics if multiple @-codes were specified in the
string, but no space characters (just noticed this bug while reviewing).

Created: sbbs_t::expand_atcodes() - used by sbbs_t::mnemonics(), exposed in
JS as bbs.expand_atcodes().

bbs.text and system.text now have properties: each text string ID is the
property name and the text index number (1-based) is the property value -
enabling fast text string lookup without load/require text.js

Constified sbbs_t::atcode() and attrstr() - not too painful

Deprecated YNQP text.dat string in favor of (the first character of)
  "Yes" and "No" text strings and new strings: "Quit", and "PasswordChar"

Other text.dat changes: ListKey->List, AllKey->Unused853
More new text.dat strings: Which, Next, Previous, Language, LANG
Deprecate the "AllKey" text string
Create/use sbbs_t::all_key() - first character of "All" text string

New JS console properties that present common (possibly localized) command
keys: yes_key, no_key, quit_key, all_key, list_key, next_key, prev_key

e.g. when using Ctrl-K or when being prompted for key-press due to inactivity

- New keys in [BBS] section of sbbs.ini:
  MaxLoginInactivity (default: 10 minutes)
  MaxNewUserInactivity (default: 60 minutes)
  MaxSessionInactivity (default: none/unlimited)
- Each configured external program/door in SCFG can have its own maximum inactivity setting (or else the session max inactivity is applied)
- moved node-specific sec_hangup to system-wide/shared max_getkey_inactivity (configured in SCFG->System->Advanced)
- moved node-specific sec_warn (seconds of inactivity before sending warning) to inactivity_warn (a percentage of elapsed max inactivity before sending warning), also configured in SCFG->System->Advanced and used for both socket and getkey inactivity detection
- Renamed JS console.inactivity_hangup to console.max_getkey_inactivity (old name remains as alias)
- Renamed JS console.timeout to console.last_getkey_activity (old name remains as alias)
- Removed JS console.inactivity_warning
- Added JS console.max_socket_inactivity (current input_thread inactivity threshold)
- New text.dat string: InactivityAlert (just contains 3 ^G/BELLs by default) used for non-visual inactive-user warning

The MaxLoginInactivity setting in particular solves the problem of custom scripts (e.g. animated pause prompts) that just poll indefinitely for user input and never time-out  - these will no longer cause nodes to be tied-up with inactive/bot users at login.

You may ask yourself, how did I get here? No, you may ask yourself: why configure these socket inactivity max values in sbbs.ini? The reason is consistency: sbbs.ini is where the MaxInactivity is configured for all the other TCP servers and services.

This fixes issue #534 for Krueger in #synchronet

sbbs_t::pause() and JS console.pause()...
now excepts an optional set_abort argument (default is true) which controls whether this method will set the global console-output aborted flag (sys_status&SS_ABORT in C++, console.aborted in JS) when the user hits the Quit or No key at the pause prompt.

This method now returns a bool: false if the user entered No, Quit, or Ctrl-C  at the pause prompt.

Nothing makes use of either of these new pause() features yet, but its generally better to not set/rely on global state wherever possible.

That's all these macros were doing anyway, so no change.

Does exactly the same thing, no change in behavior and unlikely there's any change in performance.

At one time, Synchronet was a 16-bit DOS project, plagued by the 16-bit [u]int, so long's were used everywhere > 16-bits were known to be needed/wanted (This is before the days of the standard sized types from stdint.h), and they've persisted.

But '[u]long int' is 64-bits on *nix 64-bit builds, 32-bits everywhere else (even 64-bit Windows builds if/when we ever get around to that), so this could lead to insidious bugs that would only show up on one flavor or the other. Since [u]int is 32-bits on everything we currently support, we'll use that instead of [u]long.

This "part 1" because I'm sure there's going to be warnings and errors from the GCC/Clang builds as a result, which I'll get to next.

The internal line editor's quoting feature add some hard-coded strings ("Done" and "All") and the (L)ist key was hard-coded. Use the text.dat string (new and pre-existing) for these now.

Also, use the new sbbs_t *_key() methods for referencing the configured key bindings (via text.dat) for these common key-stroke commands.
Convert the text.dat strings for keys (e.g. YNQP) to uppercase always as well.

I'm fed-up with MSVC assertions in ctype functions (e.g. isdigit, isprint, isspace, etc.) when called with out-of-range (e.g. negative) values.

This problem only affects MSVC debug builds, but if you run them (like I do), these things are like little time bombs that can drive you crazy (knocking your board out of service).

The new macros names are bit more descriptive as well.

The "insert key into keybuf" log line could contain garbage. Apparently
in a release build, the nested scope stack variable is actually invalid
after the end of the scope. Weird.

Define SPINNING_CURSOR_OVER_HARDWARE_CURSOR to enable this experimental
feature. I'm not sure I like it better than the way the spinning cursor
has been displayed for decades (to the left of the hardware cursor).

Also optimization of spinning cursor: don't call strlen() for each spin

Inspired by the cool progress cursor displayed by 'git-size', the spinning
cursors in the Synchronet terminal server are now configurable via text.dat
strings (SpinningCursor0 - 9), no maximum length.
Increased the cursor "spin" rate from 4 to 5 times per second.
The first character of the spin pattern is chosen at random between 0 and 4
but the direction of increment is also from left to right.

If a ~ is present just before a ctrl char or the end of a mnemonics string, create a hungry hotspot for the line that sends CR when clicked (similar to ^A~).

Now that pause() can set a hot-spot, don't inject a Ctrl-C (abort) into the keyboard buffer if it had.

By default, single-char hot-spots do not extend to the end of the row (use the "hungry" attribute to control behavior).

Both hungry/liberal hot-spots and strict hot-spots can be defined now, at the same time. For Nelgin.
Use ^A` to define a single-char strict hot-spot using Ctrl-A codes. Unfortunately, this usurps the "home" Ctrl-A code which nothing seems to use but has now been changed to ^A'.
Use ` instead of ~ in mnemonics to define strict single-char hot-spots (also displays the cmd key in [] instead () on non ANSI/PETSCII terms).
Use @` instead of @~ codes to define strict hot-keys.
Use HOT:STRICT @-code to declare a strict hot-key color.
Use HOT:HUNGRY @-code to toggle back to hungry color-defined hot-keys (the default).
New optional boolean argument to JS console.add_hotkey(), hungry = true by default.

- User Defaults menu mousified
- When all hot spots have scrolled off the screen, clear the hot spot list
- Insert new hot spots in the front of the list so they will take precedence
  over any previously defined duplicate hot spots
- Numeric hot spot commands end in a carriage-return
- No auto-acceptence of numbers when there are keys in the keyboard buffer
- Baja UNGETKEY function now inserts keys into the "front" of the keyboard
  buffer (next to be consumed)
- Hot key @-code command text supports C-style escape sequences
  (allows encoding of ctrl chars, spaces, etc.)

and JS console.keyboard_buffer_space() and keyboard_buffer_level()
... for tracking the number of character spaces used and available in the the (unget)keyboard input buffer.

- hot spots are clickable screen areas (e.g. in menus and prompts) that   generate key-strokes
- commands may be from 1 to 127 ASCII-characters in length
- currently using the X10 mouse reporting mode, may change
- all mnemonics strings (~Example) are automatically hot-spots
- The new ~ @-code defines a hot spot
- Any screen-clear operation clears all hot spots
- sbbs now tracks the current screen (cursor position) row
- eliminated the old "tos" (top-of-screen) boolean (row == 0 indicates "tos")
- created an sbbs_t::ungetstr() method
- keep track if in pause (hit a key) prompt, for special mouse behavior

new JS console object:
- row property
- tos property is now read-only (and deprecated)
- new methods:
  add_hotspot()
  clear_hotspots()
  scroll_hotspots()

redrwstr() gets some UTF8 touch-ups as part of this commit. <shrug>

When inkey() receives an ANSI escape sequence it doesn't need to consume, put the consumed characters into the keyboard buffer *ahead* of whatever else is in the keyboard buffer already. Uses new ungetkey() insert mode option.

"No" in yesno() and noyes(), unless the P_SAVEATR mode flag was specified
(which may be used for the old behavior).

now accept an optional print-mode (a.k.a. pmode) argument to provide more
control over the printing that happens in these functions/methods.
The immediate use is for P_NOCRLF to stop the newline from being printed
after a yes or no response (e.g. in a full-screen UI), but there could be other
uses.