This also addresses the addresses with 65535 in them in the new debug-level
log messages "New packet (type x) created for linked-node" .

To complete the request from: Max (WESTLINE)

  Is it possible to do a new dateformat in scfg
  In sweden we using YYYY-MM-DD format as standard.

The default will be '/'.  Technically, any separator is possible by editing
the "date_sep" value in the global section of main.ini.  SCFG allows the
most popular separators: /.- and space.

... and YYYY/MM/DD for birthdate input/display.

Now set in SCFG->System (not toggle options) and stored in the "date_fmt" key
(new) in main.ini. The old sys_misc SM_EURODATE flag is deprecated (but used
to determine the default value of date_fmt when not present).

As requested from: Max (WESTLINE)

  Is it possible to do a new dateformat in scfg
  In sweden we using YYYY-MM-DD format as standard.

This completes the revert of commit c22063f9 from (Jun-2-2016). The Baja
part of that commit was reverted in commit 932fae30 (Nov-15-2016). This
behavior has proven to be surprising and annoying for JS mod developers
(e.g. the yesnobar.js and Nightfox's file searcher/scanner).

If we still need clearing of abort status after running JS "externals",
that should probably be done in exec_xtrn(), not here.

Should calm the clang warnings reported by Deuce:

e.g.
passing 'char *[18]' to parameter of type 'const char **' discards qualifiers in nested pointer types

CID 476253

The 4th enhancement request of issue #674

The other requests look a bit more involved than I'm willing to explore right
now. And Deuce reassigned this back to me. So that's probably all that's going
to be done.

Go ahead and fix false-positive CID 33482 by adding a NULL check to quotestr()

CID 462234

Even though smb_getmsghdr() just saves and restores the msg.idx_offset value
(not actually using it, but triggering this Coverity issue), this does seem
like better behavior and more consistent with the loadfiles() implementation.

The use from addfiles.js (the -readd option) implies this is what's expected.
And echicken was suprised the 'added' date/time-stamp wasn't udpated.

Nobody's really using this auxdata yet, besides echicken, so no impact for
others.

The Global Login Requirements (default: blank) are used for any sever that doesn't have it explicitly set.

This resolves issue #666 (the issue of the beast) for Keyop

(missed as part of previous commit)

e.g. User.downlaoded_file() will now publish to the appropriate MQTT topic and changes to system.node_list[] will get published to MQTT.

The old default Win32 console mode is still available via '-iw' option.

As pointed out by echicken: when setting the "cost" property to any value, the actual
file's cost would be set to 9223372036854776000 regardless of what number was in the
provided file metadata object. Most jsval numbers aren't doubles (they're ints) so
need to use JS_ValueToNumber() to do the proper conversion, regardless of underlying
type.

Noticed the same problem with the "size" property.

Thanks for the tests and report echicken!

In Windows 11, "Windows Terminal" is now the default console (though the
Windows user can change that to the old conhost.exe).  Running UIFC
apps (e.g. SCFG) in Windows console mode from within a Windows Terminal
console doesn't always display correctly (depending on the width of the
console). And even if if the app displays correctly at first in console
mode, it's very easy for the user to resize the console window and just
totally foobar the display of the app.

Windows console mode (previously, the default interface mode) is still
available ("-iw" option) if one wants to use it instead.

However, stdio/door mode ("-id") and ANSI mode ("-ia") can't be used directly
from a console.

The help/usage output is sent in Windows console mode (not stdout or GDI mode)
so it creates a new window, disables mouse support (so you can copy text from
it). stdout doesn't work from GUI apps. Fun times.

This reverts commit fddbd721.

Causes MSVC warning:
msgtoqwk.cpp(249): warning C4309: 'initializing': truncation of constant value

This reverts commit e90e8f82.

Apparently this causes issues with recognition of the QWK newline char
(pi symbol, EX-ASCII 227) in QWK messages.

comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]

This fixes the issue reported by Nelgin with the [mail] RescanFrequency new
default value of "1h" being interpretted as one second intead of one hour.

With this change, it's important you don't try to use a newer text.dat with an
older sbbs (and perform a ;UPLOAD sysop operation).

Previously, each file's size in (k)ibibytes was displayed, which is not very
modern of us. Use the byte estimate (e.g. "1.2M") strings intead.

We were appending .sig files to uploaded text, which may not have ended
in an LF or CRLF sequence. This fixes that.

To eliminate confusion with the file-meta-object that this API deals with
more than anything else.

echicken's suggestion

Nothing used this property before now, so this should be fine.

echicken reported this problem: pretty severe filebase corruption as a result
of calling FileBase.renew(). The problem seemed pretty obvious (only loading
the file's index record), but I do think the underlying SMBLIB functions
should be more resilient to misuse and not corrupt the base. So, that's still
a TODO.

No existing scripts were using FileBase.renew(), so this problem has gone
unnoticed since SBBS v3.19.

which were result of QWK_NEWLINE redef to make cppcheck happy

SSH channels, I noticed that I hand't ever finished the terminal
type/size "stuff", and while fixing that, I noticed that the hack
for SyncTERM was done wrong.

Fix the whole thing, and now Synchronet and SyncTERM both properly
support terminal type and size over SSH.  It also looks trivial to
support the SSH window size change message, but I'm not doing that
tonight.

Unfortunately, this is a patch on a patch, so is a bit fragile.
It should really have the patches merged at some point.