Kayz authored 4 years ago and Rob Swindell committed 4 years ago

The hardcoded external.bat file has been moved to a templated
/exec/external.bat which can be modified by the sysop. ENV
vars are in there to be able to customize as needed. emusetup.bat
is no longer needed, but still supported. The actual dosemu command line
is now stored in /exec/dosemulaunch.ini and can be customized for
fossil or i/o command lines. the keystroke is now only sent for i/o, and
only sent as \n instead of \r which would trigger undesired behavior in
certain programs. The above 2 files can also be placed in door dirs
to override. ansi.com has been removed as it was not needed. default
external.bat includes cmd lines for share, x00, etc. (user will still
need to provide these in xtrn/dosutils).

This reduces the number of unnecessary recompiles of ver.cpp -> ver.o.

Gave up on trying to isolate socket-enabled (networked) and non-socket apps. Just link everything that uses xpdev (which is everything, I think) with the WinSock import library. Fixes the current master branch build issue on Windows. I'll get around to removing the old NO_SOCKET_SUPPORT macro eventually.

Might as well, could be useful to display in something like umonitor in the future.

when selecting a node (data comes from node#/client.ini). For Nelgin.

One weird thing is that client_t:
- has just a const char* for the protocol, so that's strdup/free'd here (consider making this a char array to simplify this API)
- does not have a socket descriptor, so that value is returned
- does not have local addr/port info

Was using <data_dir>/temp to check for free space. data/temp is
not a normally created directory, so usually this check would fail
and just report 0 bytes free space. Instead, lets check the data
directory itself.

Paves the way for utilities like umonitor to show client details for node connections (e.g. IP address, hostname, connection duration, etc.)

Recompiling ver.cpp only now, so need link ver.obj/o with the various targets now. I'll need to update the objects.mk for the *nix builds, next.

Fixes the scrolled/selected position when the sysop has more than screen-full of xtrn program sections. As reported by mlong.

These are only used if you don't have a ctrl/text.dat file (it's 0-bytes in size), so I do delay committing these changes some times, nobody notices.

New @-codes: GIT_HASH and GIT_BRANCH
New JS system properties: git_hash and git_branch

To be sure these buggers are always created for every build that includes the
'all' target. Perhaps these should be creatd in build or an output dir and
maybe for all projects (not just sbbs3) - but will ponder tomorrow.

Allows reporting of branch/commit that was used to build the code.

If for some reason building without 'git', you'll need these 2 files to
already exist somehow - still need to work that out (e.g. for daily
built-source archives).

Need to update the Windows build to generate these files now.

This fixes issue #194 reported by mlong.

Always use the return value of term_supports(), which correctly supports pre-logon and auto-terminal-capability-detection, rather than useron.misc for all door drop file generation.

This should resolve the issue recently discussed in #synchronet with regards to a user getting non-ANSI output from door games even when using an ANSI-capable terminal.

When forwarding a single-part MIME-encoded HTML email, the preamble (original message header info) and any user comments, need to be HTML-encoded.

Add the commonly-used "Fwd: " prefix to the default message subject, when forwarding.

This required that smb_getplaintext() no longer always-NULLify the message's text_subtype (e.g. "html"). For single-part messages, this element was getting freed and NULLed.

Add/use a new SMBLIB convenience function to add a string header field, but only if non-NULL: smb_hfield_string()

Since we're calling smb_getplaintext() manually here, and its not going to return the comment headers as part of the plain-text (the way smb_getmsgtxt() can), so we need to display find/display the comment headers first.

even when GETMSGTXT_PLAIN mode flag is used and the message contains a MIME-encoded plain-text portion. Obviously the GETMSGTXT_NO_HFIELDS exception still applies.

The fixed problem was when forwarding a MIME-encoded email, the forwarding information (and user comment, if supplied) could be suppressed/lost.

The new messages subject may be passed into forwardmail(). If it isn't, it'll be prompted for (defaulting to the original message subject).

Also, fix forwarding to QWKnet (look-up full-route/to-user-number).

‘%s’ directive writing up to 255 bytes into a region of size between 103 and 128
reported by Nelgin.

smb_getmsgtxt() returns any "comment" headers as part of the message body text, and has since 2003.
When I added mail->netmail (stored message) export support to SBBSecho v3, I duplicated this logic, so comment headers were added *twice* to exported netmail messages. Oops. I didn't notice until today when playing with forwarding-to-netmail (FTN).

Also noticed and fixed: any comment headers in posted messages (unlikely/uncommon) would not be exported to EchoMail messages. Use the correct smb_getmsgtxt() mode flags ("NO_TAILS" instead of "BODY_ONLY") - I know, not great names.

No longer derive the new message header from the original - too many problems. Simplified the forwarding support smblib (multiple SENDER* and RECIPIENT* header fields no longer expected/supported). Technically, the FORWARDED header field really serves no important purpose now.
A comment can be passed into forwardmail() or (if NULL), will be prompted for. There is an issue where the added comment can be obscured by the receiving mail program if the original message is a multi-part MIME message. Not sure the best solution for that. Still a WIP in that regard.

Only do the local user notification when appropriate.
Signal the FTN netmail semaphore when appropriate.

Closes #83, #108, #141.
Still to do: expose via JS (e.g. for use in msglist.js).

Copy some code from atcodes.cpp to show all the aux and network attributes.

Also, the MsgAttr text.dat string only contains 17 %s's but we were passing 18, so the last attribute (KillSent) would never be shown.

Instead, split this into 3 strings and just pass those 3 strings to the MsgAttr format string along with a ton of blank strings. So we don't have to keep updating the MsgAttr text.dat string every time we add more attribute flags (that was kind of ridiculous).

Use ctime_r() to dump the forwarded date/time.
Correct some other unsafe uses of ctime() here (replace with cime_r).
Fix the accidental reference to the GPL license (it's actually LGPL for smblib).

The convenience pointers to_ext and to_net need to be invalidated (nullified) if we are going to allow forwarding from local email boxes to network mail and keep all the original message header fields in tact.

The "Forwarded" field must now be added *before* any new recipient information (local user extension or network address of the forwarding destination).

This is part of the solution to request #83, #108, and #141.

New JS User.stats properties:
- read_mail_waiting
- unread_mail_waiting
- spam_waiting

New @-codes:
- MAILR (read mail waiting)
- MAILU (unread mail waiting)

And the corresponding MAILR# and MAILU# codes (for non-current user's stats).

Addresses feature request #191.

... as pointed out by Nelgin. You can toggle more than one sub-board/directory's "template" option to "Yes". But only the first such sub/dir is actually the template, so only indicate the first such sub with a splat ('*').

There is no actual TCP-client when a timed event is executing, so don't create one in the JS context when the socket is invalid.