JS) which will be executed when a users uses the the (L)ist msgs command from
the "Reading" sub or "Reading E-mail" prompt.
The arguments passed to the module are: <sub-code> [which]  [usernum]  [lm_mode]
The additional optional arguments are the same values as would be passed to a
readmail_mod, if one were to be used instead.

src\sbbs3\js_global.c(3703): warning C4018: '<': signed/unsigned mismatch
src\sbbs3\js_global.c(3761): warning C4018: '<': signed/unsigned mismatch
src\sbbs3\js_global.c(3779): warning C4018: '<': signed/unsigned mismatch

MsgBase.get_msg_header or get_all_msg_headers), the message header object's
private data (used internally in these C source functions) would be freed and
NULL'd, apparenty as a form of optimization. This would cause some methods
which can accept a msg header object as an argument (e.g.
MsgBase.put_msg_header, bbs.show_msg/show_msg_header) to fail or behave
in strange ways.

Instead of freeing/NULLing the private data (and depending on that as an
indication that the header has been enuemrated), just set a member variable
indicating that the header has been enumerated (once) already.

This is the bug that has been tripping me up with my message lister JS mod
(see YouTube video). I can finally get that committed to CVS for testing now.
:-)

As reported by Ragnarok (DOCKSUD)

(said port 0) since the port had not been bound yet.
So fix the display order of that msg (after listen() is called)
and lower the log level to debug.

We don't need PCI DSS compliance I hope, we just want people doing things.

only (you can still use them from JS etc).

Areafix requests to unlink a node from an area would corrupt the list of
linked nodes: the *last* listed node would always be removed. If this was
not the node that submitted the areafix request, then 2 nodes would be
removed from the list of linked-nodes for an echo.
To simplify this, we're just going to not write the removed node back to
the area file, but leave it in the in-memory list. So technically, the node
won't be unlinked until the next run of SBBSecho when the area file is
re-parsed. If that's a problem, we can always add run-time removal from
the in-memory list later. Reported by Alterego (ALTERANT).

*.msg).

non-deleted and active user records.
Renamed the old "User List" menu option: "List All User Records"
The online help probably needs fixing now: TODO

SBBSCTRL env var isn't set (defualts to "/sbbs/ctrl" instead, like the other
utils).

This allows redirect targets from paths that don't exist.  Required to
implement hard-coded API endpoints via ssjs.

not set (or blank), use the default ("/sbbs/ctrl") and print a warning to
stderr. This resolves a FAQ for sysops that struggle with setting the SBBSCTRL
env var, but do have sbbs install in /sbbs or a symlink from /sbbs to where
sbbs is actually installed.

Note: this function is different than the one previously defined in getctrl.c
but never used. If/when we ever really need to support PREFIX, then perhaps
we'll use that one (which copies a string to a buffer).

-r    = display raw message body text (not MIME-decoded)

conn_telnet.c: In function 'telnet_output_thread':
conn_telnet.c:95:56: warning: passing argument 6 of 'telnet_expand' from incompatible pointer type
../sbbs3/telnet.h:168:18: note: expected 'unsigned char **' but argument is of type 'char **'

bbslist.c: In function 'get_emulation_str':
bbslist.c:2105:1: warning: control reaches end of non-void function

Only retain the last (most recent) 10 data/<id>.qwk.*.bad files and
data/file/<user-num>.rep.*.bad files.

newsgroup name (as is standard per RFC3977).
Add missing 'control.dat' description to help text.
Add a newsgroup.lst option to the "Export Area File Format" menu.

(configured or auto-generated): getsubnewsgroupname().

file (one newsgroup name per line). The newsgroup name is used for all the
area fields/names, removing the group name if applicable. Any additional text
following the first word of each line is ignored.
Also sets the INET/NTTP networked flag for all the imported subs.

Also, fixed apparently long-standing bug where QWK name of imported subs was
always overwritten with sub's short name.

targets.mk:8: *** missing separator (did you mean TAB instead of 8 spaces?).  Stop.

terminated with either a double-quote or a semicolon character. If not
enclosed in quotes, terminate on the first white-space char following the
filename=.

(e.g. for Hold status) even if/when it's a point off of us.

Don't ever route netmail when the destination zone/net/node matches a local
AKA (ignoring the point value).

If a packed messages contains no PATH or SEEN-BY lines, we can still detect
and prevent a message loop by comparing the origin address in the packet header
against the downlink's address and if it's a match, skip that downlink.
It is still possible that a packed message header contains a different origin
address than the packet header, and we're actually over-writing the packed
messge header variable with the parsed Origin: line address (if there is one),
so perhaps we'll want to compare the (actual) packed message header origin
address too at some point in the future, if loops continue to be a problem.

write_to_pkts():
If for some weird reason a downlink's address is in the PATH, but not in the
SEEN-BYs, detect as a loop and don't send to (add to an outbound pkt for) the
downlink.

This is an experimental change to see if it addresses the issue reported by
Richard Williamson and Mark Lewis with regards to dupes in the COOKING
echo from point nodes off 1:396/45.

running a JavaScript module would crash (e.g. segfault) sbbs:
Create and use a separate JS runtime, context, and global object/scope for
global hotkey events. This means that the hotkey won't benefit from any
previously loaded/required scripts, possibly effecting the performance of the
first invocation of the hotkey handler. Subsequent JS hotkey events will reuse
the same runtime/context/global, so they'll execute fast(er).

One questionalbe change to js_execfile():
With the JS_GC (garbage collection) call *before* the JS_ENDREQUEST() call, the
process would crash in libmozjs. Moving the JS_GC() call to *after* the
JS_ENDREQUEST() resolved this issue and I'm not clear why. This 'js_cx'
parameter here is not always sbbs_t::js_cx. When called to handle a JS hotkey
event, it's sbbs_t::js_hotkey_cx, so it shouldn't interfere with the
sbs_t::js_cx being used by the currently executing JS module (shell or door).
<scratches chin>

brought down [cvs.]synchro.net this weekend. It's hard to believe we still
have unchecked calls sprintf() around, but we do.

in case something (e.g. Argus mailer) deleted it while we were waiting our
turn to use it. As reported by Alterego (ALTERANT)