Since we're calling smb_getplaintext() manually here, and its not going to return the comment headers as part of the plain-text (the way smb_getmsgtxt() can), so we need to display find/display the comment headers first.

even when GETMSGTXT_PLAIN mode flag is used and the message contains a MIME-encoded plain-text portion. Obviously the GETMSGTXT_NO_HFIELDS exception still applies.

The fixed problem was when forwarding a MIME-encoded email, the forwarding information (and user comment, if supplied) could be suppressed/lost.

The new messages subject may be passed into forwardmail(). If it isn't, it'll be prompted for (defaulting to the original message subject).

Also, fix forwarding to QWKnet (look-up full-route/to-user-number).

‘%s’ directive writing up to 255 bytes into a region of size between 103 and 128
reported by Nelgin.

smb_getmsgtxt() returns any "comment" headers as part of the message body text, and has since 2003.
When I added mail->netmail (stored message) export support to SBBSecho v3, I duplicated this logic, so comment headers were added *twice* to exported netmail messages. Oops. I didn't notice until today when playing with forwarding-to-netmail (FTN).

Also noticed and fixed: any comment headers in posted messages (unlikely/uncommon) would not be exported to EchoMail messages. Use the correct smb_getmsgtxt() mode flags ("NO_TAILS" instead of "BODY_ONLY") - I know, not great names.

User number is not always relevant (e.g. could be #0) when sending
netmail, so don't show that. And the CRLF at in the Forwarded string
appears extraneous.

No longer derive the new message header from the original - too many problems. Simplified the forwarding support smblib (multiple SENDER* and RECIPIENT* header fields no longer expected/supported). Technically, the FORWARDED header field really serves no important purpose now.
A comment can be passed into forwardmail() or (if NULL), will be prompted for. There is an issue where the added comment can be obscured by the receiving mail program if the original message is a multi-part MIME message. Not sure the best solution for that. Still a WIP in that regard.

Update comments on jsonclient

See merge request !58

Only do the local user notification when appropriate.
Signal the FTN netmail semaphore when appropriate.

Fix bug that corrupts the menu after deleting menus

See merge request !59

Closes #83, #108, #141.
Still to do: expose via JS (e.g. for use in msglist.js).

Copy some code from atcodes.cpp to show all the aux and network attributes.

Also, the MsgAttr text.dat string only contains 17 %s's but we were passing 18, so the last attribute (KillSent) would never be shown.

Instead, split this into 3 strings and just pass those 3 strings to the MsgAttr format string along with a ton of blank strings. So we don't have to keep updating the MsgAttr text.dat string every time we add more attribute flags (that was kind of ridiculous).

Use ctime_r() to dump the forwarded date/time.
Correct some other unsafe uses of ctime() here (replace with cime_r).
Fix the accidental reference to the GPL license (it's actually LGPL for smblib).

The convenience pointers to_ext and to_net need to be invalidated (nullified) if we are going to allow forwarding from local email boxes to network mail and keep all the original message header fields in tact.

The "Forwarded" field must now be added *before* any new recipient information (local user extension or network address of the forwarding destination).

This is part of the solution to request #83, #108, and #141.

New JS User.stats properties:
- read_mail_waiting
- unread_mail_waiting
- spam_waiting

New @-codes:
- MAILR (read mail waiting)
- MAILU (unread mail waiting)

And the corresponding MAILR# and MAILU# codes (for non-current user's stats).

Addresses feature request #191.

Barren Realms Elite 3rd party install config

See merge request !57

Just like the exec and eval sections, except executed/evaluated *before*
any external programs are installed.
New optional 'fail' key to specify a custom failure message.
Example:
[pre-eval:file_exists(startup_dir + 'test.txt')]
prompt = false
required = true
fail = You must create text.txt before you can install.

... as pointed out by Nelgin. You can toggle more than one sub-board/directory's "template" option to "Yes". But only the first such sub/dir is actually the template, so only indicate the first such sub with a splat ('*').

There is no actual TCP-client when a timed event is executing, so don't create one in the JS context when the socket is invalid.

Don't display the text.dat SelectItemHdr if an xtrn_sec_head.* file was shown.
Center the sections and the "Which" prompt when the "center=true" modopts.ini
option is set.

Add support for modopts.ini "center=true" option to center single-column
program listing in the terminal.

When a custom section header files (xtrn<sec>_head.*) is displayed, don't
print the XtrnProgLstHdr string from the text.dat.

xp_inet_pton() now sets the socket errno value, doing as instructed by the TODO.

- FREESPACEM - Mebibytes
- FREESPACEG - Gibibytes
- FREESPACET - Tebibytes

Mr. Millionaire's request.

printfile() assumes you want the file displayed starting in column 0, so will send a CRLF to insure that it does (unless the P_NOCRLF mode flag is specified). But this CRLF printing was happening before the file was opened and when the P_NOERROR mode flag is specified, this should be a silent failure with no print output. So move the CRLF printing to *after* the file is opened.

This expose an issue in the latest xtrn_sec.js where it makes several calls to bbs.menu() with the P_NOERROR mode flag set, expecting nothing to happen if/when the optional display files (e.g. xtrn*_tail.*) don't exist.

Reported by JC via IRC.

When system.new_user() was called but the current "client" object is uninitialized (e.g. has NULL protocol, host or IP address fields because there is no active client, e.g. because is was called from a timed event with active user online) - this code would dereference a NULL pointer and crash the b0rad. Reported by Mortifis.

- MSG_THREAD_ID
- MSG_THREAD_BACK
- MSG_THREAD_NEXT
- MSG_THREAD_FIRST

for John (JCBBS). Not sure what you're going to use these for, but there you have them. <shrug> :-)

Update sutils.js to format properly inside bbs (reported by jc)

See merge request !55

Rename the portable inet_pton() to xp_inet_pton() and define a wrapper macro (for all Widows builds) to use it instead of inet_pton() as not all supported Windows systems (e.g. WinXP) have an inet_pton() implementation.

This allows the HAProxy mod to be re-enabled by default without preventing executing on WinXP.

This reverts commit 6a8a2b9b.

This should fix the binkd issue.

This code does not currently work on WinXP:
"The procedure entry point inet_pton could not be located in the dynamic link library WS2_32.dll"

That could likely be addressed using GetProcAddress(), but for now, I want to get to the bottom of a *different* issue reported on a WinXP system, so need to this disabled.
Define HAPROXY_SUPPORT in your build if you need this feature compiled in right now.