Kayz authored 4 years ago and Rob Swindell committed 4 years ago

Synchronet Utilities...a master script to make it easier for new sysops to understand and use the myriad command line scripts that are available

Don't regenerate the newsgroup_list for *every* authenticated NNTP command.

These options are to attempt to address the issue (#178) reported by Michael J. Ryan
with regards to a Thunderbird error:
"Sending of the messages failed. You can only send to one news server at a time."
when attempting to reply to a message that was posted to multiple newsgroups,
but the server has not actually advertised that it serves that newsgroups (because
it doesn't or the names a different than one the server uses for the same area).

-force will force the export "Newsgroups" header field to contain only the name
of the locally selectec newsgroup.
-filter will remove any Newsgroup names from the exported "Newsgroups" header
if they don't exist on the local server.

Some padding bytes are expected to be 0xff's (not 0x00's) when
unused by configuration properties.

Also, this insures that this library is compatible with future .cnf files
(i.e. it won't over-write new configuration properties with 0's).

- min_pwlen
- textsec_mod
- automsg_mod
- xtrnsec_mod
- nodelist_mod
- whosonline_mod
- privatemsg_mod
- logonlist_mod

Since cnflib.js doesn't save/restore padding areas (yet), this explains
why using scripts that use cnflib to update/modify configuration files
could result in some settings being reverted to default or blank values
unexpectedly.

Next-up: fix cnflib so it saves and restores padding areas in .cnf files.

Originally, the "pause on exit" was implemented in the C++ version of
sbbs_t::xtrn_sec() and not sbbs_t::exec_xtrn(). This meant that the pause
option was only implemented when the prgoram was invoked from the menu and
not when invoked directly (e.g. via Baja or JS exec_xtrn function).

When sbbs_t::xtrn_sec() was ported to JS, that functionality was also moved
to JS. But it really should have been implemented in exec_xtrn() to begin
with so that regardless of how the program is invoked, that SCFG setting takes
effect.

Thanks to Michael Long for pointing this out.

Using the xtrn program section internal code protects against renumbering upon
configuration changes (inserting/removing program sections).
At Nelgin's suggestion/request.

Error objects are much easier to trace back to the offending line of code.
This was a pretty automated search/replace, so in some cases, it's a
commented-out instance that was changed. I did not convert *all* the load/*.js
files.

Don't display the new network's domain if it's not defined.

1. You can't include % specifiers in the string passed to system.exec()
   - this is just a wrapper for system(), it doesn't recongize Synchronet
     command-line specifiers.
   - so I just prepend the exec_dir for Win32, leave off for *nix.
   - it appears this wasn't tested since that command-line would not work.

2. Added 'j' option to unzip. We don't want the extraction of infopacks with
   sub-directories to be creating sub-directories under our ctrl dir.
   We should consider extracting to a temp dir instead of the ctrl dir if
   we don't have absolute control over what's being extracted from downloaded
   zip files. This could be dangerous if we're not extremely careful.

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

Improvements to init fidonet. Add and update network list. Add ability to download infopack (for manual .NA extraction). Ask for and save tic and packet passwords. Handle domains.

This reverts commit abee4472.

This reverts commit 73e3ec42.

This reverts commit 710a7ee6.

This reverts commit b39bdab3.

Fix lbshell crashing if no available items in an external menu. Also fix not honoring the "pause after execution" setting on an external program.

<nelgin> Oct 12 16:05:41 bbs synchronet: srvc 0099 IMAPv4-TLS RECV: a UID SEARCH FROM "Michiel"
<nelgin> Oct 12 16:05:41 bbs synchronet: srvc 0099 IMAPv4-TLS !JavaScript  /sbbs/exec/imapservice.js line 1867: SyntaxError: missing ; before statement
<nelgin> I got a different type of error

As poinsted out by Mlong, these constant names got out of sync with uifc.h
over the years. WIN_HLP isn't used UIFC in jsexec (js_uifc.c).

The directory list is catpured *before* the lock file is "taken", so it can
happen that another process (e.g. instance of binkit) has dealt with one or
more of the files by the time we take the lock and attempt to open the file.

Also, updated error log messages a bit.