getnodedat() now performs a non-locked read by default.

Perform more checks of getnodedat() return value before calling putnodedat()
to avoid unintentionally zeroing out node.dab records.

Add/use unlocknodedat() method for unlocking a node.dab record without
writing.

Note: The userdat.c getnodedat() and putnodedat() still return int (i.e. 0 on
success), so that can be confusing.

Since this script already sets an on_exit() handler to call uifc.bail()
it doesn't have to call it again (technically, before) in the "Done" block.
This results in "UIFC is unitialized" error displayed, as reported by
Fernando Toledo. Fixing issue #830

Set WIN_ESC (remains active, but greyed when ESC key pressed) mode flag
on main menu while we're here. That looks better.

There's no need to be unnecessarily redundant in the From header, e.g.
From: "scan-admin@coverity.com" <scan-admin@coverity.com>

This fixes the display of gitlab pushes from Deucе in conforming news readers.

It's possible now for clients to easily exceed the configured max concurrent
connections limit, even though they just get an error 429 page. Let's at least
track and log when a new highwater mark is reached.

Some of the NNTP commands (e.g. LIST) aren't supposed to change the "currently
selected newsgroup". Had to use a different variable name (e.g. mb versus
msgbase) since these message base variables share the function scope).

GROUP and LISTGROUP commands are supposed to set the "current article number"
to the first article in the group. We weren't doing this.

The HEAD, BODY, STAT, and ARTICLE commands aren't *required* to have arguments
and yet, we required they had at least one argument (an article number). Now
fixed.

Enabled "strict mode" even though that didn't catch the colliding 'msgbase'
variable definitions.

Incremented the revision to 1.2

DDLightbarMenu: When clearing the remainder of the screen after drawing the menu, ensure the console attributes are reset. Also, refactored that section of code.

See merge request !478

Eric Oulashin authored 3 months ago and Rob Swindell committed 3 months ago

DDLightbarMenu: When clearing the remainder of the screen after drawing the menu, ensure the console attributes are reset. Also, refactored that section of code.

Use it in newsutil get_news_subject() when no original (RFC822)
Subject header field exists.

This should fix issue #817.

Can't backup (make copies of) an open file.

We can't send a 4xx error (ie: client did something wrong) in
plaintext on a TLS connection.

Untested beyond a basic compile check.

Clean-up the web server config menu quite a bit by condensing options.

You can also disable filebase access by setting the vpath prefix to blank.

We need to negate the negative return value to get the number of errors.

We have this feature for the FTP, Mail, and Terminal servers (with no default
limit) but crazy abuse of my Synchronet web servers has now made this a
necessity for Vertrauen. A limit of 2 used to be considered reasonable long
ago. Today, 10 seems fair enough. Setting to 0 will impose no max-connections
per IP address (other than the total client limit per server).

Similar problem as PulseAudio, but even grosser.

The macro was only define in the xpdev GNUmakefile, not in Common,
so bbslist.c did not know if it was enabled or not, and always
showed it as disabled.

Use the fully-formed "From" header field in responses to NNTP
OVER/XOVER and HDR/XHDR requests.

This should fix issue #829 reported by Accession

Apparently JSVAL_IS_STRING() can return true even when argv[1] is out of range
(I guess I assumed it'd alwasy be NULL or VOID/undefined) and this can lead to
crash when calling JS_ValueToString() on it.

As seen on MacOS, an SMB shared file can cause the Mac SMB client to report EIO
error on locked-file read or lock attempts. So retry.

DDMsgReader & SlyVote: WHen viewing polls, for the person who posted it, show who voted on what (mimicking the Synchronet behavior which shows new votes when the user logs in)

See merge request !477

DDMsgReader & SlyVote: WHen viewing polls, for the person who posted it, show who voted on what (mimicking the Synchronet behavior which shows new votes when the user logs in)

This makes more sense.  Also, ones that are meaningless are hidden
now.

Use 0 for "no held mosaic" to avoid confusion around printable bytes.
Store the state of the current cell *before* updating in fix_line()

Top/bottom detection was somewhat broken.
Interestingly, now the previous commit isn't working anymore.
So issue 172 is not quite fixed yet.

This was due to two main bugs... the simple one was a type where
the cutoff between separated and contiguous mosaics was incorrect,
which caused the first four separated mosaics to not be displayed.

The second was due to a number of bugs in the Hold Mosaic
implementation.

This fixes the first half of issue 172.

We want ASCII to map directly, and unicode values need to be sorted
ascending for bsearch() to work properly.

Fixes Prestel keyboard input not working in GDI mode.

If the remote sends 8-bit C1 codes, handle them as though they were
properly escaped.  Since Prestel terminals are 7-bit, these will
never be sent by a proper Pretel system, but apparently some systems
do weird non-standard things.

to notify sysop (user #1) that they were paged. Previously, this was
a hard-coded string. The new string in text.dat is the same, but adds
2 BELs (CTRL-G chars) and is now customizable.

Created an sbbs_t::notify() method to make this easier to use and that
method supports @-code expansion, so this text.dat string supports @-codes
(which I used).

This addresses the feature request in issue #828 (beep the sysop in the
telegram/short message, when they're paged).

DDMsgReader bug fix: For the indexed-mode newscan, when showing only sub-boards that have new messages, ensure the selected item index is correct when re-populating the menu so that it doesn't skip a sub-board. Reported by Amessyroom.

See merge request !476

Eric Oulashin authored 3 months ago and Rob Swindell committed 3 months ago

DDMsgReader bug fix: For the indexed-mode newscan, when showing only sub-boards that have new messages, ensure the selected item index is correct when re-populating the menu so that it doesn't skip a sub-board. Reported by Amessyroom.

DDFileLister: When editing file information, check whether cost and times_downloaded exist in the metadata before accessing them. Reported by Ragnarok

See merge request !475