When a user has a "default download protocol" selected (configured for their
user account), don't display a menu of file transfer protocols when we're
just going to auto-select their default anyway (e.g. when downloading a QWK
packet).

This change also introduces an argument (%s, the protocol name) in the
StartXferNow text.dat string, so that if/when the user forgets which default
download transfer protocol they had selected, they'll be reminded ("oh yeah,
I need start an XMODEM download!").

This fixes issue #767

As was discovered as part of investigation into issue #769, a JavaScript
could crash SBBS (cause a segfault) due to a NULL pointer dereference when
the script passes 'null' to native JS functions where an object is expected.

The issue raised was with console.gotoxy(), but it turns out that *many*
Synchronet native JS functions would call JSVAL_TO_OBJECT() and then, without
checking for NULL/nullptr, pass its return value to JS api functions such as
JS_GetPrivate, JS_GetProperty, JS_GetClass, JS_ObjectIsFunction,
JS_IsArrayObject, JS_GetArrayLength, JS_DefineProperty, JS_Enumerate, etc.
All of these JS API functions dereference the passed object pointer without
NULL/nullptr checking.

The fix here is to either call JSVAL_IS_NULL() or JSVAL_NULL_OR_VOID() and
if true, not call JSVAL_TO_OBJECT() and/or check the return value for the NULL
value before using as an argument to any other JS API functions.

The calling script will still terminate if it does this, but at least the
caller will get a useful JS exception.

Related to fix for issue #769

I'm not sure under what script conditions this could happen, but apparently
Nelgin was able to produce this null pointer deref (and segfault) using
DDMsgReader. This should fix issue #769

Fix messages with blank bodies not showing up on iphone

See merge request !449

DDMsgReader Fix: Indexed newscan mode for new users now shows the number of new messages in sub-boards like it's supposed to. Reported by Nelgin.

See merge request !448

DDMsgReader Fix: Indexed newscan mode for new users now shows the number of new messages in sub-boards like it's supposed to. Reported by Nelgin.

Overrides whatever is passed on the command-line. Works around issue of '%'
character included in password bein interpretted as a command-line specifier
(e.g. %s).

Increment revision to 2.0.

See issue #765 for background.

to the getkey inactivity timeout.

By setting a socket timeout shorter or equal to the getkey timeout, the getkey
timeout effectively does nothing.

If a sysop doesn't want this warning to do anything, then no need to save
and restore the current (last displayed) line of text.

We've had this value as the default in sbbs.ini for a while now, so should be
safe to use as the upgrading-sysop (who wouldn't have this value in their
sbbs.ini file, most likely) setting.

Not all default sbbs.ini values are true "defaults" (meaning, if they don't
exist in the file, then same value would be used) - but we should do an audit
and correct those mismatches at some point.

Missing quote mark added.

See merge request !446

Add ssl support for server to server connections.

See merge request !445

So that hitting 'N' at pause prompt will abort the loop.
Reported by phigz via irc.synchro.net

Add ssl support for server to server connections.

See merge request !443

... in strftime format (https://cplusplus.com/reference/ctime/strftime/)

If you (sysop) have last_few_callers_fmt set to a custom value in your
modopts.ini, you'll need to update that format as a result of this change:
the number and type of arguments have now changed: instead of the logon
time be passed as hours and minutes (integers), it's now passed as a single
a string. That string is the result of a call to strftime() with the time_fmt
or (by default), "%H:%M".

This change was made to accommodate request by NeoArata (THEREALM)

If -p (or -P) is the last option given with no argument following, then no
password would be sent to the server (via PASS message).

For Odusseus71

... for non-sysops

looks better, more consistent with the log messages before/after it.

We removed the large-scope 'i', but didn't update the Unix-only blocks of code
(dealing with UNIX domain spy sockets).

This is just a code quality (readability) improvement. No functional change.

The other server stats (e.g. error_count, served) are zeroed upon startup, so
the highwater mark should be zeroed too.

Like the other servers.

A sysop likely would want to know which services/protocols had what
utilization (as a portion of the total highwater mark), so that'll have to
be added later.

We don't log highwater valeus of 1, though those are published to MQTT.

Not dealing with 'services' server yet, cause that's kind of tricky with the
sysop likely wanting to know per-service stats (served counter, highwater
mark, etc.)

Only log the hightwater mark when it's > 1. :-)

... for (soon) reuse in fileman.js

Also updated log output format, avoid redundancy

... since that messes up the bulletin->file numbering which is often
hard-coded in bullseye.asc

Use console.uselect() to list the bulletin files, if the menu file
(e.g. bullseye.asc) doesn't exist. For Amessyroom.

Don't replace the Pause (hit a key) prompt, since that messes up
localizaton support (reverts to the text.dat Pause prompt, instead of the
text.*.ini translated Pause prompt). The replace/revert text buffers should
really be a stack for a full fix for this.

Missing bulletin files are automatically excluded from the bulletin list.

The rest is just clean-up from the conversion from Baja.

This is still a very old/basic script, but at least it's not quite as hideous
and outdated as before.

Increment the version to 3.00.

DDMsgReader: When listing messages via lightbar, check if the subject is UTF-8, which now helps the lightbar menu display the line properly, particularly for UTF-8 terminals

See merge request !442

Eric Oulashin authored 8 months ago and Rob Swindell committed 8 months ago

DDMsgReader: When listing messages via lightbar, check if the subject is UTF-8, which now helps the lightbar menu display the line properly, particularly for UTF-8 terminals