Previously, a ZRINIT frame would be sent even after a failed file download, and this could be misinterpreted by the sender as a successful file receipt 
 acknowledgement. 'lrz' just completely aborts the receive "batch" under the same conditions, so we'll just do the same to prevent the sender (e.g. BBS) from mistakenly counting this as a successful transfer (download).

A lot of log message updates: additions, removals, and use of the __FUNCTION__ macro.

Call this one "2"
Flashbacks to manually editing zone files here.
I may end up going with YYYYMMDD numbers like I sometimes did in
zone files, but maybe I'll just do the single number thing... not
really sure yet.

These frames were already not allowed in the binkp/1.0 protocol,
and it is mentioned in the spec (issued in 2005) as "Some old
implementations do send empty frames as the last frame.".

It's certainly not allowed now, and any mailer which does it is
broken.

For zero-length data packets, it will be seen as a frame containing
zero data bytes which will also be logged as being after the file
if it comes after the file has already been completely transferred.

A zero-length command packet will abort with M_ERR, logging an error
regarding command number NaN or something like that.

This may fix #185 since attempting a recv() of zero bytes and
succeeding is the only way I can see for a zero second timeout to
have been logged in receving frame data.  The software assumed that
receiving zero bytes was a timeout, but if that's what you asked for,
it's actually success.

Only observed on Windows, the option value variable (val) was uninitialized so querying byte-sized options using WinSock getsockopt() would leave the MSB of the value as undefined (garbage), resulting in sockinfo.js output like this:
KEEPALIVE = -858993663
instead of this:
KEEPALIVE = 1

Ctrl-A codes that cause cursor movement or attribute changes or anything except toggling the console output will now be ignored when console output is off.

Only in Socket I/O mode. This will allow us to tweak the SNDBUF size (to account for slow ZMODEM downloads - sends from sexyz) and frob other socket knobs.

Also added a line feed to Windows OutputDebugString() messages since MSVC's debug log viewer now assumes that you will.

we assume it's 1.1 anyway.

This has been fixed upstream for some time.

This restores the meaning of remote_ver and still has a hack for
broken, unfixable mailers that don't advertise protocol v1.1
correctly (ie: Irex)

According to both FTS-1026 and FSP-1024, the "mailer version" portion of this
msg may contain spaces. Some mailers (e.g. Internet Rex), provide their version
information with spaces, e.g. "Internet Rex 2.67 beta 1a OS/2 (binkp/1.1)",
which also include a non-conformant protocol version indicator:
 " (binkp/1.1)" instead of " binkp/1.1".
Additionally, only require that "binkp/" exist in the string, to find and
parse the protocol version number, which is apparently critical to the proper
operation of the protocol. This should resolve issue #185 reported by altere.

I'm also storing the entire VER response in the binkp.remote_ver property and
this will break the older Mystic/BinkP work-arounds in binkit.js. I dont' think
we really need those workarounds any longer however. We'll soon see I guess.

Don't complain that exec/<modname>.bin can't be opened. Instead, complain that <modname> doesn't exist and therefore can't be executed. The old message could be misleading/confusing if the expected module is a JS mod (not Baja-compiled .bin mod).

ARS = Access Requirement String
Spaces aren't allowed in the <ars> so you might have to get creative with ARS symbols instead of keywords.
SHOW by itself will re-enable display output for all users.
- for Nelgin

Make it clear that if it's not a 16-bit DOS program, it's "native".

Changed "New Shell / New Context" to "New Shell or New Context"

- for Nelgin

JavaScript modules are intuitively "native" and have not historically required
the "native" option to be set to "yes" in SCFG.

Testing my commit hook more than anything.

Support temp_dir (%g) and text_dir %(z) expansion to magic DOSemu drives/paths.
Use DOSemu-compatible temp_dir and text_dir paths in drop files.
Automatically recognize native node_dir paths in %f (e.g. editor temp files) and replace with DOSemu equivalent.

... when running DOS programs on Linux with a DOSEMU-enabled build.

Allows %f (drop file) and %s (startup-directory) to be specified on the external program's command-line and expand to the paths that DOSEMU will understand. No more hard-coding "D:\" or "E:\" and the drop filename on the command-line required.

Also (for all builds), include the door's startup directory for %s specifier on the clean-up command-line. This just seems like an oversight.

Update modopts.ini due to section changes in xtrn_sec.js

See merge request !38

Use the text.dat strings that corresponded with the previous behavior
(used by console.uselect()). The defaults include new-lines, so removed
some hard-coded console.crlf() calls that were added. If you have a
custom section_header_fmt, you'll likely need to add a \r\n to it.

Allow the "External Program Section" title string to be customized
(separately from section_header_fmt, e.g. for localization).

Save/use the current section.

Mouse-enable the program section list.

Add missing options (clear_screen, multicolumn_separator, and singlecolumn_margin) for xtrn_sec in modopts.ini

See merge request !37

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

Add missing options (clear_screen, multicolumn_separator, and singlecolumn_margin) for xtrn_sec in modopts.ini

The argument to JS_NewContext that we were allowing to be configured was not the contest stack size, but rather:
"The size, in bytes, of each "stack chunk". This is a memory management tuning parameter which most users should not adjust. 8192 is a good default value." - per Mozilla.

So we're just going to use the suggested default, hard-coded.