Synchronet Utilities...a master script to make it easier for new sysops to understand/use command line scripts

See merge request sbbs/sbbs!27

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

Synchronet Utilities...a master script to make it easier for new sysops to understand and use the myriad command line scripts that are available

not just for Borland.

Don't regenerate the newsgroup_list for *every* authenticated NNTP command.

These options are to attempt to address the issue (#178) reported by Michael J. Ryan
with regards to a Thunderbird error:
"Sending of the messages failed. You can only send to one news server at a time."
when attempting to reply to a message that was posted to multiple newsgroups,
but the server has not actually advertised that it serves that newsgroups (because
it doesn't or the names a different than one the server uses for the same area).

-force will force the export "Newsgroups" header field to contain only the name
of the locally selectec newsgroup.
-filter will remove any Newsgroup names from the exported "Newsgroups" header
if they don't exist on the local server.

Some padding bytes are expected to be 0xff's (not 0x00's) when
unused by configuration properties.

Also, this insures that this library is compatible with future .cnf files
(i.e. it won't over-write new configuration properties with 0's).

- min_pwlen
- textsec_mod
- automsg_mod
- xtrnsec_mod
- nodelist_mod
- whosonline_mod
- privatemsg_mod
- logonlist_mod

Since cnflib.js doesn't save/restore padding areas (yet), this explains
why using scripts that use cnflib to update/modify configuration files
could result in some settings being reverted to default or blank values
unexpectedly.

Next-up: fix cnflib so it saves and restores padding areas in .cnf files.

This allows us to ignore markup codes in a string like: "/sbbs/ctrl/*cnf*"

Addresses false-positive matches in URLs (e.g. https://minftn.net/) where the second slash was being interpreted as a the beginning of an italic markup.

In preparation for node-spy applications that can support multiple terminal sizes/types (none exist yet). The file is updated whenever there is new/updated information about the client's terminal.

Exposed as JS method: console.term_updated().

The "MAIL FROM" command argument must always be enclosed in angle-brackets. Some mail servers (e.g. gmail, aol) would reject messages not delivered in this manner, e.g.:
mx-aol.mail.gm0.yahoodns.net replied with:
"501 Syntax error in parameters or arguments tnmpmscs"
instead of the expected reply:
"250 ..."
gmail-smtp-in.l.google.com replied with:
"555 5.5.2 Syntax error. o6si11103060plk.317 - gsmtp"
instead of the expected reply:
"250 ..."

I'm fed-up with MSVC assertions in ctype functions (e.g. isdigit, isprint, isspace, etc.) when called with out-of-range (e.g. negative) values.

This problem only affects MSVC debug builds, but if you run them (like I do), these things are like little time bombs that can drive you crazy (knocking your board out of service).

The new macros names are bit more descriptive as well.

It kinda sorta works, but needs more love.

The "insert key into keybuf" log line could contain garbage. Apparently
in a release build, the nested scope stack variable is actually invalid
after the end of the scope. Weird.

As reported by WitNik, on 32-bit rPi builds, the loop would not
terminate and display transfer count down values after hitting 'H'
to hang-up.

This reverts commit 9fd06985.

ERROR 2 (No such file or directory) in logout.cpp line 189 (backout) opening "/sbbs/node1/backout.dab"

format '%ld' expects argument of type 'long int', but argument 7 has type '__off64_t'

'%lu' expects argument of type 'long unsigned int', but argument 5 has type 'off_t

For non-authenticated SMTP clients, if the "From:" header field contains a "name" which appears to be an email address (i.e. it has an '@' in it), and that address does not match the *actual* address in the "From:" field, reject the mail with an error message about the forged/mismatched address.

So use check for the USE_XPDEV definition instead of CTRL_A.

This reverts commit 8223b075

This reverts commit 1e7b6626

I noticed that when executing an external JS with the new "Use Shell / New Context" option set to "Yes", that any expressions (strings) installed via js.on_exit() were not being executed upon exit from the script. These on-exit strings are important for restoring global state information (e.g. control key pass-through, console mode) to the original state before the JS mod made any changes.

I'm not sure why the special treatment of "scope == NULL" is through-out this function. Going back to v3.16, it appears this was special treatment for JS mods invoked via global hot key event (when scope != NULL). When invoking an xtrn JS mod with the new Context option, the scope argument is not NULL, so this check was defeating the parsing of the "exit_code" and the evaluation of any js.on_exit() installed expressions for no apparent reason. I can't think why global hot key events should be excluded from this logic either.

These are defined in xpdev/gen_defs.h, but not all xsdk doors #include that
(e.g. SBJ).

Originally, the "pause on exit" was implemented in the C++ version of
sbbs_t::xtrn_sec() and not sbbs_t::exec_xtrn(). This meant that the pause
option was only implemented when the prgoram was invoked from the menu and
not when invoked directly (e.g. via Baja or JS exec_xtrn function).

When sbbs_t::xtrn_sec() was ported to JS, that functionality was also moved
to JS. But it really should have been implemented in exec_xtrn() to begin
with so that regardless of how the program is invoked, that SCFG setting takes
effect.

Thanks to Michael Long for pointing this out.