Hopefully not introducing any bugs in the process.

The new subject line parsing (with quoted-filename support) had a NULL-pointer deref built-in.

Also fixed a few Coverity-reported issues.

Caught by Coverity.

Addresses Coverity's NEGATIVE_RETURNS bug-checker issue.

Identified by Coverity.

To make Coverity and my adult-self happy.

As tested and reported in FIDONEWS by Michiel van der Vlist, 2:280/5555, SBBSecho would use the "best match" FidoNet AKA for the originating address when replying to PING netmail messages and not necessarily the original destination address of the ping request. For systems that have multiple addresses (AKAs) that could be considered appropriate originating addresses for the requesting node address (e.g. multiple addresses in the same zone or zone/net), this could cause a confusion for the PING requester.

The create_netmail() function now accepts an optional source (orig) address parameter and the PING response logic passes the netmail's destination address for the reply message's originating (source) address.

I noticed that AreaMgr responses also follow the same logic as PING responses (just use the best-fit AKA, not necessarily the same address as the original request's destination address) - but I did not choose to address that "issue" at this time.

The sysop (or any user with the irc_seclevel or the C-exemption) can still
manually change the IRC server (and port).

For Mike Powell (CAPCITY2)

Don't return an error if the node#/node.cnf file can't be opened for all uses of load_cfg() except from the terminal server. This fixes #214 for Tracker1

add exportcfg, importcfg, and xtrnmenucfg

See merge request !109

The previous committed fix/issue raised some additional concerns about this "parity" bit:

Something I didn't notice before from the ZMODEM spec:
"The hex header receiving routine ignores parity."

And looking at lrzsz's zm.c, I see it goes even further and ignores the "parity" bit on the ZPAD and ZDLE bytes proceeding the frame encoding byte as well as in the frame encoding byte itself (so ZHEX, 'B' 0x22 and 0xC2 should be treated as equivalent).

I find it strange that some ZMODEM implementations (e.g. chuck's zshhdr()) would send the terminating LF with the even-parity bit set, but not set the even-parity flag for any of the frame content bytes. And then, expect that the parity flag may be set on incoming hex headers. I suppose it makes sense for 7-E-1 connections, but then the transmitted terminating LF would have had its parity flag set automatically (would not need to be set manually in the code). Add to the mysteries of ZMODEM that will likely never be solved.

Some ZMODEM implementations set the high bit (even parity?) when sending this '\n' terminator.
As reported via IRC:
<Keyop> sexyz: !zmodem_recv_hex_header HEX header not terminated with LF: 138 (8Ah)

Bug fix for changing message area with lightbar

See merge request !108

user's current sub-board is a high-numbered sub-board and they select a message
group with fewer sub-boards, the highlighted sub-board in that group would be
set to that high number and would be incorrect.  That has been fixed.  Copied a
fix from my stand-alone message area chooser.  In that scenario, the current
highlighted sub-board in the other group will be the first one.

3rd party door install: netrunner and exdx doors

See merge request !107

Make it possible to import xtrn and xtrnsec from another system (with different indexes)

See merge request !106

After calculating i (offset in list to top of window), if it's less
than zero, apply it to bar and set i = 0.

Fixes #218

Feature requested (?) by u/jumbotronjim on https://www.reddit.com/r/synchronet/:

If the client connection is from a blocked IP address (in ip[-silent].can), but still manages to get through the web server and websocketservice and have their correct IP address reported via Telnet Location, terminate the connection. Seems dubious.

Fix issue reported WitNik (BGGRSCYN) on DOVE-Net:
```
sbbs@raspberrypi:~ $ /sbbs/exec/umonitor -iC
...
sh: 1: /sbbs/exec/syncterm-iC: not found
```

Update readme to warn sysops about adult ship names on scoreboard

See merge request !105

Update readme.txt to warn sysops about echickens' ship naming convention on the interBBS scoreboard. Seemed easier than trying to setup a self-hosted scoreboard or requiring 18+ on program execution.

Fix issue with overriding inv format per item, cleanup options code, fix prog menu sort, turn off pausing

See merge request main/sbbs!102

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

Fix issue with overriding inv format per item, cleanup options code, fix prog menu sort, turn off pausing

fix typo

See merge request main/sbbs!104

For mlong to test/chew-on. Uses matt's cnflib.js (of course).

These configuration properties were not previously exposed via JS.