Skip to content
Snippets Groups Projects
  1. Apr 10, 2024
    • Rob Swindell's avatar
      Resolve CID 492287 - we don't care about the fexistcase() return value here · 76b5c7f4
      Rob Swindell authored
      We're just using it to "fix" the case, if the file indeed exists.
      76b5c7f4
    • Rob Swindell's avatar
      Create/use sbbs_t::flush_output(timeout) · 424dfe10
      Rob Swindell authored
      If client socket is connected, wait up to the specified timeout period (in ms)
      for the output buffer to be emptied.
      
      This is much preferred over blindly calling mswait() after sending some data
      (e.g. a file) and possibly waiting much longer than necessary.
      424dfe10
    • Rob Swindell's avatar
      Reduce the Terminal Server thread outcom timeout from 80 seconds to 800 ms · 221507a8
      Rob Swindell authored
      Since the Terminal Server is a single thread, let's not block for long
      periods of time trying to send bytes to a client (e.g. send the badip.msg
      file contents to a client with a blocked IP address), effectively DoSing the
      terminal server.
      
      This should address the problem reported via IRC:
      <theviper4> │Apr  9 15:38:11 viper-bbs synchronet: term Terminal Server timeout(outcom) 0000 0000
      <theviper4> │Apr  9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 110 sending on socket 39
      <theviper4> │Apr  9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 32 sending on socket 39
      <theviper4> │Apr  9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 32 sending on socket 39
      <theviper4> │Apr  9 15:38:36 viper-bbs synchronet: term 0039 Telnet !CLIENT BLOCKED in ip.can: 117.95.153.33
      
      Also, make the outcom timeout error message more helpful (e.g. include the
      sock descriptor of the client) and don't use the old rioctl() function
      here any more.
      221507a8
  2. Apr 09, 2024
  3. Apr 08, 2024
  4. Apr 07, 2024
  5. Apr 06, 2024
    • Rob Swindell's avatar
      Introduce system.git_time · bf772802
      Rob Swindell authored
      This is the time_t (seconds since Unix epoch, Jan-1-1970 UTC) date/time of the
      current (most recent) Git commit used to build the running binary.
      
      If a JS developer wants to check if a build is recent-enough to include some
      change, this is the property they should use to check (with >= comparison).
      bf772802
    • Rob Swindell's avatar
      Add support for -v (verbose) option · 1d0dcbac
      Rob Swindell authored
      Displays messages about non-existing files when in verbose mode
      1d0dcbac
    • Rob Swindell's avatar
      Clean up the old filebase data files from all the configured data_dir's · 3d9f3a92
      Rob Swindell authored
      De-duplicate the data_dirs first (most sysops use a single data dir for all
      file directories).
      
      Also, don't print non-existing old files when run with -q (quiet) option.
      3d9f3a92
    • Rob Swindell's avatar
    • Rob Swindell's avatar
      Save/restore js.scope property value in sbbs_t::js_execfile() · c3b47aca
      Rob Swindell authored
      This solves the problem of exit() values (e.g. non-zero return codes) not
      getting propagated to callers when nest-called (e.g. via bbs.exec()).
      
      I think it was kk4qbn that pointed this out via IRC: an exit(1) call from
      prextrn.js did not stop the external program from running (as it should, for
      any non-zero exit code). This only happened when the prextrn.js called another
      JS script (e.g. via bbs.exec() or as was the case here, indirectly via "EXEC"
      @-code in the YesNoBar text.dat string (which executed yesnobar.js). This
      nested JS script invocation via sbbs_t::js_execfile() would clobber the stored
      js.scope property value (where the "exit_code" property is written).
      
      Script invoked in their own context (e.g. via js.exec()) wouldn't have this
      issue in the first place.
      c3b47aca
    • Rob Swindell's avatar
      First pass at making a useful top-level build doc. A lot of content from the... · f7771613
      Rob Swindell authored
      First pass at making a useful top-level build doc. A lot of content from the wiki should likely be moved here.
      f7771613
  6. Apr 05, 2024
  7. Apr 04, 2024
  8. Apr 03, 2024
  9. Apr 01, 2024
  10. Mar 31, 2024
  11. Mar 30, 2024
    • Rob Swindell's avatar
      Save and restore the js.exec_path, exec_dir, and exec_file properties · 9013f866
      Rob Swindell authored
      When invoking a nested JS script, these properties of the "js" object would
      be overwritten and not restored, as discovered/reported by Nightfox when his
      trivial game script would indirectly execute yesnobar.js, his subsequent use
      of js.exec_dir would point to the wrong location (the "exec" directory, parent
      of yesnobar.js, and not the direcctory where his game script was located).
      The exec_path and exec_file properties had the same problem as demonstrated
      by a simple test.js placed in (and executed from) a directory other than the
      "exec" dir:
      	function f() {
              print("js.exec_path = " + js.exec_path);
              print("js.exec_dir = " + js.exec_dir);
              print("Js.exec_file = " + js.exec_file);
      	}
      	f();
      	console.yesno("test");
      	f();
      
      This would only trigger the problem when executed from the BBS and whebn the
      YesNoQuestion text.dat string invokes the "yesnobar" module via EXEC @-code and
      yesnobar.js exists (in exec or mods dir), superceding yesnobar.bin which does
      not trigger this issue (not a JavaScript mod).
      9013f866
    • Rob Swindell's avatar
      Remove CVS keywords from (not all) .ini files · ceb315be
      Rob Swindell authored
      ceb315be
    • Rob Swindell's avatar
      Merge branch 'gttrivia_js_exec_dir_change_workaround' into 'master' · 679fe5cf
      Rob Swindell authored
      Good Time Trivia: Make a copy of js.exec_dir on startup and use the copy, since js.exec_dir could change indirectly (i.e., console.yesno() running yesnobar.js in sbbs/exec)
      
      See merge request !430
      679fe5cf
    • Eric Oulashin's avatar
      Good Time Trivia: Make a copy of js.exec_dir on startup and use the copy,... · 91babf1d
      Eric Oulashin authored and Rob Swindell's avatar Rob Swindell committed
      Good Time Trivia: Make a copy of js.exec_dir on startup and use the copy, since js.exec_dir could change indirectly (i.e., console.yesno() running yesnobar.js in sbbs/exec)
      91babf1d
    • Deucе's avatar
      Unconditionally call sftp_end() when input thread exits. · 0a397616
      Deucе authored
      Hopefully fixes issue where certificate file is left open and so
      can't be deleted.
      0a397616
  12. Mar 29, 2024
  13. Mar 28, 2024
Loading