Skip to content
Snippets Groups Projects
  1. Aug 09, 2022
  2. Aug 08, 2022
  3. Aug 05, 2022
  4. Aug 04, 2022
  5. Aug 03, 2022
    • Rob Swindell's avatar
      Check max_files value in extract_files_from_archive() better · bff68ad0
      Rob Swindell authored
      Address issue reported by Nightfox via DOVE-Net:
      Today I was using the Archive class to extract exactly one file from a zip
      file, and I'm a little confused on the exception throwing behavior regarding
      the max_files parameter.  When calling extract(), I gave it a filename pattern
      and expected exactly 1 file to be extracted, so I also gave a max_files
      argument as 1.  It extracted the one file, but it threw an exception with the
      error "Error: maximum number of files (1) extracted (after extracting 1 item
      successfully)".
      
      Should that be an error condition to throw an exception? I expected 1 file to
      be extracted, and that file was extracted successfully.  If I specify max_files
      as 2, then it doesn't throw an exception.   
      bff68ad0
  6. Jul 23, 2022
  7. Jul 19, 2022
  8. Jul 17, 2022
    • Rob Swindell's avatar
      Don't treat Enter as choosing default section when no prompt was shown · 8651f2af
      Rob Swindell authored
      As pointed out via DOVE-Net by DesotoFireflite (VALHALLA):
      When xtrn_sec.* display file/menu is used, there's no auto-generated
      prompt (with a default section number indicated). So hitting Enter
      in this case and having the previous/default program section selected
      would be surprising behavior to a user. So, only support a default
      section selection when there was no xtrn_sec.* menu/display file.
      8651f2af
  9. Jul 15, 2022
  10. Jul 14, 2022
  11. Jul 10, 2022
  12. Jul 08, 2022
  13. Jul 07, 2022
  14. Jul 06, 2022
Loading