I noticed when setting a security level's lines per message value > 32767
in SCFG->System->Security Level Values, the value would be read back as 1 or
or some other crazy value. That was because we were writing this value
(and all the security level 16-bit values) using iniSetShortInt(). These are
*unsigned* 16-bit values, so that we should have been using iniSetUShortInt().
We'll just use iniSetUInteger() instead to fix that/those issues.

And since promotion/conversion from uint16_t or uint32_t to uint has no impact
when creating a decimal representation of a number, just use iniSetUInteger()
everywhere we're setting unsigned integer settings in the main config .ini
files. If/when these fields are made larger in the future, this code will just
work.

When reading .ini integers, use the more appropriate iniGet[U]Int16 functions
instead of iniGet[U]Short and use iniGetUInteger for reading enums or any
values that are immediately typecast to a uchar/uint8_t.

Replaced some other use of [u]short that I found when searching with stdint.h
types.

Rather than recomputing (possibly differently) the max lines in multiple
places.

This also enables the possibility that editfile() could be used to edit files
of > 10K lines in the future. <shrug>

If a user's security level lines per message was set to '0', bad things would
happen to the heap if the user posted/sent a message. '1' is a reasonable
minimum value. If you don't want a user/group of users to send/post messages,
there are restrictions for achieving that. Also this setting is (currently,
at least) 16-bit, so clamp it there too on the high end.

Also clamp the expire-to security level setting between 0 and 99, while we're
here and noticed that this value wasn't being sanitized either.

If the top already ends in a blank line, no additional CRLF is warranted
(between the 'top' and the raw-input message 'body').

Replace the suspicious strcpy/strcat's in msgeditor(), the built-in line
editor, with bounds-enforced snprintf() calls.
Also, properly define MAX_LINE_LEN to account for the trailing \r\n on each
line. It appears we've been under allocating the total possible message buffer
size (by 2 bytes per line) for a while now.
These 2 changes together should fix issue #547: apparent heap corruption due
to 'buf' overflow in msgeditor().
Also added a line count check/cap-enforcement with logged error message if
exceeded (should never happen).

Also fixed in this commit: off-by-one when enforcing max message length in
msgeditor().

Also added checks that the 'cols' (used in MAX_LINE_LEN) are reasonable values
(40+), 2 was below the threshold of what would be expected to work since
there is logic that deducts 4 from cols, for example.

This bug only impacted non-passive FTP connections. Using an FTP client
with active (not passive) data connections over an IPv6 connection would
false-trigger the "bounce attack" detection and the FTP server responded with
"504 Bad port number" and logged a hack attempt in data/hack.log.

The issue was that we were comparing the socket address structure (which
contains other fields besides the address itself) between the control and
proposed-data connections. While this logic worked okay for IPv4,
it did not for IPv6 (the 2 structs contained some non-address differences).
Rather than modify the socket address structures to match where needed, I'm
just comparing the string representation of the addresses, since that's
what we really care about anyway.

Thank to "mark i" of Truck Stop BBS for alerting me to this issue

Sometimes F1 doesn't work, Ctrl-Z isn't documented, but there is a '?' displayed
when help is available, so it's reasonable to assume someone might try/use it.

For Dasme.

Minor beautifications

Initial commit for The Outhouse IGM.

See merge request main/sbbs!283

DDMsgReader: Check console.aborted instead of ctrl-C keypress for aborting searching and scanning

See merge request !282

This lowercase's the entire path.

Fixes issue #543

The sbbs_t::wordwrap[] buffer was 81 characters (80 printable characters, plus
NUL terminator) and sbbs_t.getstr(), when used with the K_WRAP mode flag could
potentially write more than 81 characters to this buffer (e.g. when using a
wider than 80 column terminal and writing a message with the internal line
editor which calls sbbs_t::getstr(... K_WRAP)) - would corrupt sbbs_t members
after wordwrap[], which included pointers that would be freed in the sbbs_t
destructor (~sbbs_t) and subsequently page/segfault as seen in issue #545.

This change increases the wordwrap buffer to likely twice the same needed
(maximum columns + NUL terminator) and adds wordwrap bounds checking to
sbbs_t::getstr().

There were comments indicating crash sightings in the sbsb_t destructor going
back to 2002, so this commit removes those comments.

Thanks to Nelgin for providing the gdb dump details ('print *this') that was
the clue needed to reach the root-cause determination.

This fixes issue #545.

Useful when debugging mail issues, e.g. with MIME-encoded mail

Fixes issue #544

Need to use this for creating nightly sbbs_src.tgz file

Also suppress the diff errors when the git_*.h files don't exist

DDMsgReader: Ctrl-C is now supported for message searches to abort the search.

See merge request !281

To be consistent with sbbs's utf8_normalize_str() function behavior.

MRC enhancements: Nicklist toggle, timestamps, and improved default alias

See merge request !280

Removed backup_level option from save_cfg()

This seems kind of circular doesn't it? Anyway, add a new SCFG->System->
Advanced->Configuration Backup option to set the number of config (.ini)
file backups to keep (default is 5).

Eliminate the scfg -b option (used to manually over-ride the default
backup level of 5).

Fix for issue #542

DDMsgReader: Added default color definitions for indexed reader mode in case they aren't specified in the theme .cfg file

See merge request !279

DDMsgReader: Added default color definitions for indexed reader mode in case they aren't specified in the theme .cfg file

DDMsgReader: Added "indexed" reader mode and made a fix to print utf-8 characters properly on non utf-8 terminals. Fixes issue #354 and issue #541

Closes #354 and #541

See merge request !278

DDMsgReader: Added "indexed" reader mode and made a fix to print utf-8 characters properly on non utf-8 terminals. Fixes issue #354 and issue #541

Added key buffer flush to prevent auto skipping prompts. Version updated to 1.1.

See merge request !277