CID 331092

It's a wrapper for filedat.c -> format_filename() which can truncate and pad a filename for display purposes.

Prevents weird issues with getting remote address.

When only reading the index (detail = file_detail_index), smb_getfile() just sets the file->name convenience pointer to point to the name in the index. Then when loadfiles() would sort the list, these pointers would not be adjusted (so they would point to the wrong names) resulting in a corrupted file list (e.g. name/size mismatches and no logical sort order).

The solution is to call smb_getfile() on each file *after* the read index records have been sorted.

This also means that the sort-by-name routines needed to always sort using the index name and not the convenience pointer (which is NULL in this case).

While fixing this, I noticed there was no bounds checking in the loadfiles() and loadfilenames() read-loops, so if the indexes happened to be longer than the total_files value from the status header, a buffer under-alloc/overflow would occur and a likely crash as a result. So stop reading the index when the expected maximum number of index records have been read.

Adds from/tags/desc/extdesc properties, even when absent or blank.

When parsing a file object, set the from, desc, tags and cost properties only if they already have been set or the new values is non-blank/0.

So just always assume that no "user" directory has been configured. At least for now while I ponder whether this is a feature worth restoring and if so, how.

Previously, these both used gettimeofday() which is both expensive
to call, and not monotonic.

This fixes system.clock_ticks in JS and various internal bits. for
when the UTC wall clock jumps.

While we're here, fix the documention of system.clock_ticks

warning: format not a string literal and no format arguments

Caught by CID 331001

The use of SAFECAT() with a typecast to a pointer is not going to work as expected. This change broke line-based telnet-gateway functionality (unconfirmed, but pretty obvious).

Likely the cause of the crash that killed cvs.synchro.net last night

Specifically, have errors mean the fd is "ready".

Also, fix some extra revent clearing and a spy socket issue while
we're looking at this code.

Should fix issues with CGI scripts that close stdin/stdout but do
not terminate, and maybe deal with some other corner cases at the
same time.

Tabs are the shit.

For easier use of the auto-generated echo-tags in JS.
And a helper function sub_area_tag(), now used in SCFG too.

Previously, timed or polled callbacks were required to keep the
event loop running.

This should allow callbacks to not interfere between (say) shells
and doors.

I haven't added a clearImmediate() because there's currently no way
of manipulating the run queue, and I can't come up with a reason
someone would actually need it.

Was terribly broken.

This macro has expanded to nothing for a while now and even before, the usage was misguided and unnecessary as explained in this video: https://www.youtube.com/watch?v=cjotPqQxxAY

Non-poll used the wrong value for calculating the high socket (which
is ignored on Win32, the only non-poll() user), and the socket was
being set in the wrong union member.

CID 319112