DDFileLister: Filenames too long for the menu now displayed above the (extended) description. User can now toggle extended descriptions by pressing X within DDFileLister. Requested by Nelgin.

See merge request !504

Eric Oulashin authored 1 month ago and Rob Swindell committed 1 month ago

DDFileLister: Filenames too long for the menu now displayed above the (extended) description. User can now toggle extended descriptions by pressing X within DDFileLister. Requested by Nelgin.

Fix that, and also fix the cpstr_to_utf8() implementation that
bypasses the lookup function.

C128 used CGA monitors, and at least the 1902 output yellow.
An argument could be made that it should be the default.

For the three codepages with fonts that do both broken and unbroken
vertical bars, add a _B variant for the one with the broken vertical.

This allows the broken vertical to be "correctly" in the codepage
mapping.

Some different fonts in the same codepage use different glyphs, so
this can't be a per-codepage setting.

Not sure how I'm going to actually implement this properly, but at
least the data is there now.

DDFileLister: New configuration option, displayNumFilesInHeader. Forgot to include it in the .cfg file in my last commit.

See merge request !502

DDFileLister: New configuration option, displayNumFilesInHeader. Forgot to include it in the .cfg file in my last commit.

Resolve GCC warning: case value ‘124’ not in enumerated type
  ‘enum unicode_codepoint’

View images in a smaller viewport (I'm no CSS expert here, obviously)

- loadfile
- addfile
- removefile
- updatefile

As discovered via ftp server "error updating" file log message, no details
could be logged since these functions just returned a simple bool. So, we
now support passing an optional output parameter to capture the result/error
value to be displayed or logged when these functions return false.

Unrelated fixes to start_batch_download():
When passing a list of files on the command to the file transfer protocol
driver (e.g. sz), if any filename contains spaces, that filename must be
quoted or else sz will fail with error 'sz: can read only one file from stdin'.
Also, the trailing whitespace from the list of filenames must be removed or
else sz will report errors 'sz: cannot open : No such file or directory'
and 'sz: Transfer incomplete'.

If the first specified file in the list had a wildcard pattern, multiple
ZRQINIT (request init) frames would be sent (one for each file matching
the first list item file pattern).

This was just found via code review, not in the wild.

DDFileLister: Now optionally displays the number of files in the header at the top of the list, confirtable with the displayNumFilesInHeader option in the config file

See merge request !501

Atari ST modes are 25 rows, they don't need to have the status
line turned off by default.

DDFileLister: Now optionally displays the number of files in the header at the top of the list, confirtable with the displayNumFilesInHeader option in the config file

It's not clear exactly what will happen if I don't, so add it just
in case.

CP437 0x7C is U+00A6

It's likely this is true for a bunch of other codepages as well,
so I'll need to dig through them soon.

Contrary to pouplar belief CP437 does not encode US-ASCII.
US-ASCII has UNICODE_VERTICAL_LINE (U+007C) there (which does match
Unicode)

Aren't you glad your C compiler didn't use CP437?
if (x ??!??! y) is so much uglier than if (x || y)

Of course, with C99 (or C90 with the 1995 ammendment), we would have
seen a lot of iso646.h and the use of the or, bitor, and or_eq macros,
and maybe that would have gotten that whole list of 11 macros promoted
to keywords eventually (Likely in C23) since it's hard to eat just one
peanut.

Of course, that's all alternate history... it's unlikely that any
compiler vendor would actually care, and | and ¦ (or | and ³ for those
using CP437) would be "the same".

DDMsgReader: After replying to a message, when status is shown and pauses for user input, Q or Ctrl-C will now exit, and not be ignored.  Requested by Keyop.

See merge request !500

DDMsgReader: After replying to a message, when status is shown and pauses for user input, Q or Ctrl-C will now exit, and not be ignored.  Requested by Keyop.

Looks like an unintentional debug-inclusion with commit 2064f3a4
as pointed about by Deuce in IRC.

When the option is not set, messages "READ" flag is set when the message is
retrieved via POP3. Setting this option defeats that behavior - as requested
by Keyop via IRC.

Since I'm out of option flags, remove the "receive by user number" option.
The receive by user number option was never a good idea and hopefully no
one is actually depending on/using that setting. Uesr numbers in the alias.cfg
file still work.

As a result of recent change to netwrap.c

Since that's the most used/assumed byte order for IP addresses, let's make
that the default and eliminate a lot of unnecessary byte-swapping.

This fixes the issue reported by Keyop in IRC, introduced in commit 29b93c32

It's a bit different than straight 4:3 due to Mode 7 not using the
full line period or all the lines.

For non-Guest users (without the 'U' restriction), if the FTP client
sends the MKD or XMKD command, just return the proper succcess result
and do nothing (don't log as a hack attempt or return a syntax error
result).

Some FTP clients (e.g. Reolink Doorbell camera) just always try to
blindly create a directory before uploading files, but if that command
fails (as we would), the upload is aborted. So pretend to create the
diretory whether it already exists or not, just so the client will
proceed with the upload.

For G or U restricted users, treat (log) as hack-attempt, as before.

<@Deuce> Filenames are always assumed to be DOS programs, despite not being able to run them.
<nelgin> If sbbs was smart, it would know that if it's not a dos program then to use jsexec or whatever.

There: sbbs is now more smarter

We need to provide an address family "hint" to getaddrinfo() to limit the
results to IPv4 addresses.

Regression introduced in commit 29b93c32

Reported by Keyop via IRC

That's what Commstar uses in Prestel mode after all.

This mostly just changes the arrow key bindings and adds support
for Ctrl+Fx and Shift+Fx, and makes End Copy.

The big change though is that Page Down, not Tab now toggles reveal
mode.  Sorry all you guys with 60% keyboards.

For use by SyncTERM in Mode 7/Prestel modes.

It seems some of the Shift+x codes were incorrect (had unshifted
as high byte and shifted as low byte).

Basically, the only thing the SAA5050 enforces is that characters
on a bottom row need to be double-height, or they're displayed as
spaces.

The Prestel terminal now has an extra bit that indicates it is a
prestel terminal, and the bitmap console hacks up the second row.

While we're poking this, use macros for magic bits in FG/BG colours.

Needs clean-up still

No other changes

Since we do Mode7