Nobody will really care though.

This partially reverts commit 03b84df8.

I observed deadlocks on Linux attempting locks of user.tab on Samba share,
which also deadlocked my Windows nodes. Interestingly, the Windows nodes
never deadlocked on their own (after a week of testing) when using blocking
locks.

Double the frequency of lock retries - this has helped reduce the observed
user.tab lock failures on Vertrauen.

As Deon pointed out in DOVE-Net / Synchronet Discussion, having a local time
zone configured with a different UTC offset than your system time zone can
produce strange/unexpected results (e.g. displayed age of messages). Since
it's possible that not all sysops will complete the configuration wizard or
actually set their timezone to the correct value (and ignore the startup
warning message), we now make the default Local Time Zone to be
"automatic" - query the OS every time the local time zone is needed/used.

This has the downside of only storing (e.g. in message headers) the UTC
offset of the current time zone (not the time zone abbreviation/name as
encoded by SMB). I considered making an option to dynamically figure out
the actual time zone (not just the UTC offset) and while I think that's
doable, Deon just wanted his UTC offset (e.g. UTC+11:00) and not his
time zone name (e.g. AEDT) stored in message headers, so this setting
w...

Make the scheme ("http://" or "https://") configurable via rss.ini, default is
now "https://".

Make the message link format somewhat configurable via rss.ini (hopefully to
support some other/future web message reading interface should there be one).

Reportedly, the MsgBase.get_msg_header/body() calls of the "total_msgs" offset
were logging errors? I was not able to reproduce this (the !hdr check seemed
to be successfully ignoring such cases), but in any case, message offsets are
0-based, so this was definitely an off-by-one issue, even if it was a silent
failure for everyone else. <shrug>

... when current timezone is negative offset from UTC, but not a US time zone,
the default should be "No".

DDMsgReader bug fix: In the scrolling message reader interface, it now exits on user input timeout (as it should). This should fix issue #844, reported by Keyop

Closes #844

See merge request main/sbbs!483

DDMsgReader bug fix: In the scrolling message reader interface, it now exits on user input timeout (as it should). This should fix issue #844, reported by Keyop

Presumably it's because I'm not using std=gnu11 or whatever

Use the same hack as for strerror_r()

The non-standard strerror_r() is glibc specific, musl doesn't do
that.  It *appears* that __USE_GNU implies glibc.

Looking into potential causes of issue #843, I found several instances where
we call getuserdat() without checking the return value and restoring the
useron.number to the current user number upon error: getuserdat() zeroes out
the user struct/number upon error, a bad API choice made 23 years ago.

Replace those instances with calls to sbbs_t::getuseron() which logs any
open/lock/read failures of the user.tab and does not modify/zero-out the
sbbs_t::useron struct upon error.

... since all (almost all) callerd do a config check first.

Also, some callers of openuserdat() were expecting -1 on failure (always).

Functions that returned the return value of openuserdat() upon failure, now
return USER_OPEN_ERROR instead, to be consistent.

A copy/paste from websrvr.c

... that is working (for me at least) to auto load/rerun sbbs

This needed a custom solution (not errprintf) since the filename is passed-in
is likely from dynamically allocated memory, so a pointer comparison isn't
enough - and we don't get the function name.

This is a solution for issue #842, but only for messages posted/sent from the
terminal server using built-in functions and not via JS or other means. A more
universal/generic solution would be nice (beyond just always storing message
headers and bodies in UTF-8), but nothing has come to mind.

This reverts commit 79fa3c0b.

Differently than all other types, the length must be set before
parsing because the BPP does not contain the length data, instead
the length is specified by the message definition.

The expectation is now that there will be a single copy of SSH BPP
contents and arrays and buffers will be pointers into that.

This avoids another allocation/free requirement.

All consumers are expected to only #include deucessh.h now.  Individual
headers should not be included.

So require(..., 'node_status') instead. The function we actually use here.

and we weren't using that function here anyway, so require(..., 'node_status')
instead.

Looks like this feature (commit d661427e) never really worked correctly
since it counted the files removed from each sub-dir and then stopped deleting
when the count reached the number of files in the base directory. This was
done to accommodate the 'keep' feature (part of previous commits).
So make 'keep' check conditional on it being non-zero and just don't ever use
a non-zero keep value with a recursive delete and we should be good! :-)

This fixes issue #841

part of fix for issue #619

Part of solution for issue #619 (for the web server)

Part of solution for issue #619 (for the mail server)