Since "NODE*" is a match for a node number status (ugh), and this comparison
happened before the comparison for "NODE_USER", we'd never hit that condition.
Thought I tested this before original commit, but I guess I did not. Oops.

This recent enhancement (Commit b27bd426) introduced security and usability
concerns.

So I created (and am now using where requested) a wrapper for formatting
text.dat/ini strings which will automaticlaly detect @-code encoded strings
and expand/use them *only* (instead of printf %-specifiers).

This might impact issue #696 since although unintentionally, it actually was
possible to mix @-codes and %-specifier usage in certain (node status)
text.dat/ini strings, but that should not be possible now. It's either/or:
@-codes or %-specifiers, not both.

Needed for exactly reproducing built-in node status string formatting using
@-codes (only).

Note: format specifiers (e.g. %s) cannot be combined with @-codes (use one or
the other, not both).

Fixes issue #696

If you need additional text strings to support @-codes, you'll have to specify
them explicitly in feature request issues.

We have checks/loops/timeouts waiting for active clients to disconnect and
child thread threads to terminate whenever shutting down or recycling already,
so this should be safe. This pretty simple change fixes issue #236 (can't
terminate server under heavy load).

Also as part of this commit, introduced the ability to "pause" a server
(prevent it from accepting new connections) with the ctrl/pause semaphore
file or via the MQTT server/pause (and resume) topics. This feature is useful
when debugging server issues where you don't necessarily want to fully
shutdown/terminate the server, but don't want any new connections to be
accepted (the listen backlog will fill up with incoming connections though).
Unlike a server shutdown, a server pause can be "undone" via MQTT (by
publishing a message to the "resume" topic).

The "pause" semaphore file is just an "existence" semaphore file - its
date/time stamp doesn't matter. If the file exists, the server will enter
a paused state (and periodically log messages to that fact) until the semfile
is deleted.

This server pause feature is not the same as the pause button function in
sbbsctrl, which just pauses server log output.

In this case, we don't care what the time stamp on the file is.

that doesn't log an error

Support was accidentally removed as part of commit 0d01544d, meaning
the ftpalias.cfg wasn't used at all in responses to the MLSx commands as
reported by Max (WESTLINE) using Total Commander, FileZilla and Directory
opus. The traditional "LIST" commands still worked fine with ftpalias.cfg
contents just fine.

The reason this code was accidentally removed was due to the errant
copy/pasted comparison with startup->html_index_file that did not belong here
and made the block appear related to HTML index file generation. It was not.
This was just a bug in the initial implementation of MLSx support in
commit d4deb4b3.

Also included in this commit:
- Return the date/size of the user's QWK packet file, if it exists, in MLSx
  response.
- send_mlsx_entry() won't report negative time_t values as file modify dates
 (flength returns -1 upon failure/file-not-found).
- get_owner_name() returns the string, making it easier to use in function
  calls.

There appears to still be some work to do to make the MLSx commands fully
compliant with RFC 3659 (e.g. "mlst filename" from ftpalias.cfg should work
but does not), but at least FileZilla displays ftpalias.cfg files and
directories correctly now.

Reusing the variable 'str' here for multiple purposes meant the QWK packet
filename was overwritten by the owner name (the system's BBS-ID):

 ftp> mlsd
 229 Entering Extended Passive Mode (|||2001|)
 150 Opening ASCII mode data connection for MLSD.
 Type=file;Perm=r;UNIX.ownername=VERT; 00index
 Type=cdir;Perm=elc;UNIX.ownername=VERT; /
 Type=file;Perm=r;UNIX.ownername=VERT; VERT

That last file there should have been "VERT.qwk"

Since lock_ssl_cert() is a reader lock, there shouldn't be a whole
lot of contention on aquiring it anyway, and we can thundering herd
our way out of it when it clears.

without locking!  That's chaos!

DDMR fix for indexed mode reading (not newscan): Showing the first unread message when selecting a sub-board, updating scan pointer, and selecting the next sub-board when done with the current sub-board

See merge request !385

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMR fix for indexed mode reading (not newscan): Showing the first unread message when selecting a sub-board, updating scan pointer, and selecting the next sub-board when done with the current sub-board

This ancient bit of was re-writing node.ini files needlessly

Expanded to CRLF or just CR (if strip LFs is enabled).

It is possible for someone to stuff LF-terminated text in a message, so let's
account for that possibility upon export to FTNs where LFs are supposed to be
ignored.

Hopefully help debug why HTTPS isn't working for him

area.length is an object, not an array, so it's length will always be 0

Should probably make this a command-line option too, but this will do for
now for Ragnarok to test eternal-september with.

This partially reverts commit 44c3350f where a bunch of read() and write()
return value checking was added.

The proper sentinel value here for "no TLS session" is -1, not 0.

This, at minimum, was causing a lot of extraneous calls to destroy_session()
(from js_socket.c's do_js_close()) with an invalid (hopefully, not
otherwise used) cryptlib session ID of 0.

Nothing checks or logs the return value of destroy_session(), but I'd expect
it to be failing ... a lot.

DDMsgReader configurator: Added a default for displayIndexedModeMenuIfNoNewMessages in case it's not in DDMsgReader.cfg

See merge request !384

DDMsgReader configurator: Added a default for displayIndexedModeMenuIfNoNewMessages in case it's not in DDMsgReader.cfg

Most DOVE-Net subs were already configured this way, but not all.

This was broken one year ago in Commit 9db5d2a2

Thanks for the report (just now) about this bug Max!

The year is 4 digits, so the offsets aren't the same as the other 2 supported
formats. Doh!

Thanks Max for testing!

Merge branch 'ddmr_show_indexed_newscan_menu_after_reading_new_msgs_and_full_indexed_reader_mode' into 'master'

DDMsgReader: New user-toggleable behavior: Show indexed menu after reading all new messages. Indexed reader mode (with -indexedMode command-line parameter) uses all sub-boards instead of just newscan sub-boards

See merge request !383

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: New user-toggleable behavior: Show indexed menu after reading all new messages. Indexed reader mode (with -indexedMode command-line parameter) uses all sub-boards instead of just newscan sub-boards

Fix issue #693

... using WIN_FIXEDHEIGHT mode to limit the list height in wizard mode.

I had a solution using a negative width param value to specify a height limit,
but then I saw this code in ulist():
```
	if(mode&WIN_FIXEDHEIGHT) {
		height=api->list_height;
	}
```

something Deuce added for SyncTERM and I don't think I've ever used before.
It works.

In T2B (top to bottom centering) mode, the 'top' parametr value isn't actually
for the top of the window position (later), so just zero it here in case it
was specified (and non-zero) to correct the calcutation on the next lines:
```
	if(top+height>s_bottom)
		height=(s_bottom)-top;
```