Skip to content
Snippets Groups Projects
  1. Feb 20, 2023
    • Rob Swindell's avatar
      All loadable modules can now be configured as full command-lines · add79f03
      Rob Swindell authored
      Previously, many/most loadable modules were limited to just 8 chars,
      so while technically you could include a command-line option with a
      very short module name, now all modules can be configured with full
      (up to 63 char) command-lines.
      add79f03
    • Rob Swindell's avatar
      Fix warning about signed/unsigned compare · 3cca779f
      Rob Swindell authored
      3cca779f
    • Rob Swindell's avatar
      Fix (false pos?) warnings in use of JSVALUE_TO_ASTRING only in RELEASE builds · 90dc709d
      Rob Swindell authored
      using gcc version 12.2.0 (Debian 12.2.0-14), e.g.
      
      js_console.cpp: In function ‘JSBool js_handle_ctrlkey(JSContext*, uintN, jsval*)’:
      sbbs.h:230:56: warning: writing 8 bytes into a region of size 2 [-Wstringop-overflow=]
        230 |                                         (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
            |                                         ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
        242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \
            |         ^~~~~~~~~~~~~~~~~~~
      js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
        670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
            |                 ^~~~~~~~~~~~~~~~~~
      In file included from sbbs.h:255:
      /home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:36: note: destination object of size 2 allocated by ‘__builtin_alloca’
         77 | #define alloca(sz) __builtin_alloca(sz)
            |                    ~~~~~~~~~~~~~~~~^~~~
      sbbs.h:228:43: note: in expansion of macro ‘alloca’
        228 |                         if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) { \
            |                                           ^~~~~~
      sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
        242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \
            |         ^~~~~~~~~~~~~~~~~~~
      js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
        670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
            |                 ^~~~~~~~~~~~~~~~~~
      sbbs.h:230:56: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
        230 |                                         (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
            |                                         ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
        242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \
            |         ^~~~~~~~~~~~~~~~~~~
      js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
        670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
            |                 ^~~~~~~~~~~~~~~~~~
      /home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:36: note: at offset 2 into destination object of size 2 allocated by ‘__builtin_alloca’
         77 | #define alloca(sz) __builtin_alloca(sz)
            |                    ~~~~~~~~~~~~~~~~^~~~
      sbbs.h:228:43: note: in expansion of macro ‘alloca’
        228 |                         if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) { \
            |                                           ^~~~~~
      sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
        242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \
            |         ^~~~~~~~~~~~~~~~~~~
      js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
        670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
            |                 ^~~~~~~~~~~~~~~~~~
      /home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:36: note: at offset 2 into destination object of size 2 allocated by ‘__builtin_alloca’
         77 | #define alloca(sz) __builtin_alloca(sz)
            |                    ~~~~~~~~~~~~~~~~^~~~
      sbbs.h:228:43: note: in expansion of macro ‘alloca’
        228 |                         if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) { \
            |                                           ^~~~~~
      sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
        242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \
            |         ^~~~~~~~~~~~~~~~~~~
      js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
        670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
            |                 ^~~~~~~~~~~~~~~~~~
      /home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:36: note: at offset 2 into destination object of size [1, 2] allocated by ‘__builtin_alloca’
         77 | #define alloca(sz) __builtin_alloca(sz)
            |                    ~~~~~~~~~~~~~~~~^~~~
      sbbs.h:228:43: note: in expansion of macro ‘alloca’
        228 |                         if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) { \
            |                                           ^~~~~~
      sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
        242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \
            |         ^~~~~~~~~~~~~~~~~~~
      js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
        670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
            |                 ^~~~~~~~~~~~~~~~~~
      sbbs.h:230:56: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
        230 |                                         (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
            |                                         ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
        242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \
            |         ^~~~~~~~~~~~~~~~~~~
      90dc709d
    • Rob Swindell's avatar
      Fix insufficient 'mode' string length in init() method · 440bc585
      Rob Swindell authored
      Limited to 6 chars, yet some values are as long as 12 chars.
      
      Also, eliminates this warning from RELEASE builds (only) using gcc version
      12.2.0 (Debian 12.2.0-14):
      js_uifc.c: In function ‘js_uifc_init’:
      sbbs.h:230:56: warning: writing 8 bytes into a region of size 7 [-Wstringop-overflow=]
        230 |                                         (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
            |                                         ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
        242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \
            |         ^~~~~~~~~~~~~~~~~~~
      js_uifc.c:609:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
        609 |                 JSVALUE_TO_ASTRING(cx, argv[1], mode, 7, NULL);
            |                 ^~~~~~~~~~~~~~~~~~
      In file included from sbbs.h:255:
      /home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:20: note: destination object of size 7 allocated by ‘__builtin_alloca’
         77 | #define alloca(sz) __builtin_alloca(sz)
            |                    ^~~~~~~~~~~~~~~~~~~~
      sbbs.h:228:43: note: in expansion of macro ‘alloca’
        228 |                         if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) { \
            |                                           ^~~~~~
      sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
        242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \
            |         ^~~~~~~~~~~~~~~~~~~
      js_uifc.c:609:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
        609 |                 JSVALUE_TO_ASTRING(cx, argv[1], mode, 7, NULL);
            |                 ^~~~~~~~~~~~~~~~~~
      440bc585
    • Rob Swindell's avatar
      Add an 'enabled' property for QWKnet hubs, defaults to true, part 2 · 51d4a1af
      Rob Swindell authored
      Missing part of yesterday's commit, whoops
      51d4a1af
    • Rob Swindell's avatar
      Add an 'enabled' property for QWKnet hubs, defaults to true · 4656c07c
      Rob Swindell authored
      Move the pack and unpack commands to an "Advanced" sub-menu since they
      are completely optional now.
      
      Set QWKhub 'VERT' to disabled by default in a new install.
      
      Fixes issue #506
      4656c07c
    • Rob Swindell's avatar
      Resolve GCC warning · d20d7fd0
      Rob Swindell authored
      warning: passing argument 1 of ‘ra’ discards ‘const’ qualifier from
      pointer target type
      d20d7fd0
    • Rob Swindell's avatar
      7d7f6d48
  2. Feb 19, 2023
  3. Feb 18, 2023
  4. Feb 17, 2023
Loading