Don't display remote host name/addr unless -v option is specified or
verbosity=1 is set in modopts.ini.

Allow the displayed messages to be customized or disabled as the sysop wishes
via modopts.ini keys:
- help_msg
- connecting_msg
- failed_connect_msg
(e.g. set to a blank string to disable)

The following settings are also now configurable via modopts.ini:
- quiet (correlates with -q option)
- pause (correlates with -P option)
- clear (correlates with -C option)
- timeout (correlates with -T option)
- verbosity (correlates with -v option)

... a sysop can control the default behavior of all invocations of telgate.js
or rlogin.js via a single file now (modopts.ini).

The rlogin.js module will first look ing for the [rlogin] section in
modopts.ini and if it doesn't exist, then [telgate] section. telgate.js just
looks for the [telgate] section.

For the #synchronet irc crew: Nelgin and Keyop

I'm not clear why Coverity suddenly thinks that getstr() doesn't
nul-terminate strings, but whatever: NUL-terminate the buf before passing it
to getstr(). <shrug>

HANDLE_PENDING() macro returns from the calling function (without freeing
allocated resources), so don't use that here.

Only the last node number specified would be listed before this fix.

Telnet requires CRLF or CR/NUL instead of bare CR.

This is a rewrite of the Bullshit bulletin lister. Should have all
the same features as v3, but much faster at lightbar navigation
and especially better at scrolling large files. (frame.js has been
replaced here by my new screen management library, 'swindows'.)

Sysops don't need to concern themselves with the files in this
commit; the build generated from these has been placed in the same
location as the old 'bullshit.js' script. Just copy that one to
wherever you normally run this from and it'll take over. Or you
could run Bullshit from the repo if you like to live dangerously.

bullshit v4 build as in-place replacement for v3. On first run under the terminal server, your old bullshit.ini settings will be migrated to ctrl/modopts.d/bullshit.ini in a slightly different format.

Fix issue #773

No longer claim that 'list' is the default action (it's not).

If you want to list nodes, you need to specify the 'list' action.

Fix for issue #772

bbs.telnet_gate() is not tolerant of receiving an undefined parameter value
(while bbs.rlogin_gate() is), so this messed up the subsequent argument
parsing which caused the strings pushed with the '-s' or '-S' options to
not work.

Fixes issue #774

Includes new feature to optionally send string(s) to remote server after
connecting (for Nelgin).

The -q option addition fixes issue #771.

If an array argument is passed to these methods, the stringified contents of
each array element value will be sent to the remote server after connecting.

This is to support Nelgin's request of sending some strings to a server after
connecting. There's no way to insert pauses between the sent strings or wait
for certain output from the remote - that's beyond this scope/capability.

DDMsgReader: New msgSaveDir option to specify a default dir to save messages to (for the sysop)

See merge request !450

... since these methods only feed the keyboard buffer.

Add an optional 'insert' argument to console.ungetkeys() - default is false
(append).

Add a new version of console.ungetstr() which feeds the passed characters
directly to the receive input buffer. Now returns bool indicating success.
Existing scripts (if any) that use console.ungetstr() should continue to work
just fine.

This is anticipation of telgate.js being able to stuff strings (e.g. username,
password) into the input buffer and those chars/keys being passed to the
remote (gatewayed) telnet server. Since the telnet gateway reads directly from
the receive input buffer (ignoring the keyboard buffer), we needed a way to
stuff strings of characters into the receive input buffer directly and that
sort of exposed the weirdness of the existing console.ungetstr() method:
- it didn't return a return value (not indication of failure)
- it didn't support an 'insert' operation (even though the underlying C++
  method does)
- it didn't use the sbbs_t method that already existed for feedding a string
  of characters into the input/keyboard buffer

Calling exit() causes JS_ExecuteScript() to return false (same return value
as if there's a syntax error) - so if we always set exit_code in exit()
(even when not passed a parameter) and then use that exit code if the property
is defined, then we get the -1 return value from js_execfile() if the script
is terminated prematurely without using exit().

This fixes the issue introduced in the previous commit where scripts that
call exit() - without any parameters, were causing errors to be logged about
scripts (e.g. timed events) returning -1.

js_execfile() now returns -1 when JS_ExecuteScript() return false (failure).

The main command-shell loop will now terminate when js_execfile() returns
anything but 0 (success), similar to how PCMS (Baja-compiled) command-shell
.bin file parse errors are handled.

This is a fix for issue #340

Another idea would be to store a history of mail save paths and allow the user
to scroll through them/choose with the up and down arrow keys, but that goes
beyond the original feature request. So this just stores/reuses the last
successfully used path/filename.

Some users may have unintentionally added files to their batch download queue
and not know how to clear the queue manually, so prompt here for user
friendliness/convenience.

... as appears to have been the intent

And really, more importantly, the msg header field_list array length would
always be interpretted as 0-length!

... introduced in commit 54523145

... introduced in commit 54523145

Include -pause and -loop options in usage help output.

Don't delay (sleep) one second when looping and -pause option is used.

Flush the output before waiting for key-press (-pause option is used).

This should all address issue #365. Sorry for the long wait.

This is helpful when auto-starting a download using the user's pre-selected
default download protocol, reminds the user to start the appropriate transfer
protocol on their end (when necessary).

Goes along with the previous commited fix to issue #767

When a user has a "default download protocol" selected (configured for their
user account), don't display a menu of file transfer protocols when we're
just going to auto-select their default anyway (e.g. when downloading a QWK
packet).

This change also introduces an argument (%s, the protocol name) in the
StartXferNow text.dat string, so that if/when the user forgets which default
download transfer protocol they had selected, they'll be reminded ("oh yeah,
I need start an XMODEM download!").

This fixes issue #767

As was discovered as part of investigation into issue #769, a JavaScript
could crash SBBS (cause a segfault) due to a NULL pointer dereference when
the script passes 'null' to native JS functions where an object is expected.

The issue raised was with console.gotoxy(), but it turns out that *many*
Synchronet native JS functions would call JSVAL_TO_OBJECT() and then, without
checking for NULL/nullptr, pass its return value to JS api functions such as
JS_GetPrivate, JS_GetProperty, JS_GetClass, JS_ObjectIsFunction,
JS_IsArrayObject, JS_GetArrayLength, JS_DefineProperty, JS_Enumerate, etc.
All of these JS API functions dereference the passed object pointer without
NULL/nullptr checking.

The fix here is to either call JSVAL_IS_NULL() or JSVAL_NULL_OR_VOID() and
if true, not call JSVAL_TO_OBJECT() and/or check the return value for the NULL
value before using as an argument to any other JS API functions.

The calling script will still terminate if it does this, but at least the
caller will get a useful JS exception.

Related to fix for issue #769

I'm not sure under what script conditions this could happen, but apparently
Nelgin was able to produce this null pointer deref (and segfault) using
DDMsgReader. This should fix issue #769

Fix messages with blank bodies not showing up on iphone

See merge request !449

DDMsgReader Fix: Indexed newscan mode for new users now shows the number of new messages in sub-boards like it's supposed to. Reported by Nelgin.

See merge request !448

DDMsgReader Fix: Indexed newscan mode for new users now shows the number of new messages in sub-boards like it's supposed to. Reported by Nelgin.

Overrides whatever is passed on the command-line. Works around issue of '%'
character included in password bein interpretted as a command-line specifier
(e.g. %s).

Increment revision to 2.0.

See issue #765 for background.

to the getkey inactivity timeout.

By setting a socket timeout shorter or equal to the getkey timeout, the getkey
timeout effectively does nothing.