... as reported by Mike Powell, and amessroom and root-caused by Nightfox

A '-' is a valid QWK-ID character since it is a valid DOS filename character.

dd_lightbar_menu: str_is_utf8() seems to return true sometimes when a string doesn't have UTF-8, so that is now commented out for now

Eric Oulashin authored 8 months ago and Rob Swindell committed 8 months ago

dd_ligbtar_menu.js: Fix for behavior with the item color when printing the last portion of an item. Also, UTF8 detection improvement.

Sort of the opposite of the "Offline Files" search, find files copied into
the directory storage paths but not yet added to the filebase, with a
"Add File..." option (and tagging support) along with DELete files option.

Auto-ignore listing files (e.g. FILES.BBS, etc.) when searchign for new
files to add to a directory's filebase.

If an argument is passed to fileman.js, use that as the UIFC mode (for testing
purposes only).

Fix case-sensitive file compares (on *nix OSes) when adding files (now
case-insensitive).

Fix issue with get file paths for files not yet in a filebase (using
FileBath.get_path unnecessarily).

Display virtual paths to files in many place, when available (> SBBS v3.19).

(instead of file name), which would have issues in SBBS v3.19 for filenames
> 64 chars in length.

Also, remove extraneous calls to format().

to work around recently-fixed bug with > 64 char filenames parsed from
file-meta-objects. Although this bug was fixed in [lib]sbbs[.so|.dll] might
as well use the backward-compatible method to set a better example that works
as expected with SBBS v3.19.

Text files with recognized plain text file names/extensions can be viewed from
within fileman now.

Some extended descriptions may only be terminated with LF (instead of CRLF),
so deal with those accordingly. Some auto-translation from LF to CRLF terminated
extended description lines may occur when editing extended descriptions.

(yes, I know, unzip for DIZ can corrupt the TUI display when adding files)

Add ability to display and edit extended file descriptions (including
inserting and deleting lines.

Fixed bug with moving files between dirs.

F2 is now just a shortcut for renaming files, ENTER is the main edit/display
option key now.

This really requires an updated sbbs/jsexec to work fully correct (e.g.
display/edit extended descriptions that contain blank lines).

A bunch of other improvements, cosmetic and functional (viewing archives,
editing more File fields, etc.).

This is likely the cause of the vauge logged error that I and other
sysops see from time to time:
srvc 0000 JSON SyntaxError: JSON.parse

... so log the function name and the contents of the string that's
failing to parse.

This is a new TUI-style filebase browser/editor for sysop use. Sysops can
search files, descriptions/metadata, uploader names, offline files and then
easily remove/delete or edit those file's names, description, uploader.

Ideas for improvements (e.g. file tagging/bulk deleting) may require updates
to UIFC. This is a proof of concept at least and provides some functionality
already.

If the quote file contained a Ctrl-Z (ASCII 26) char, it would be truncated
at that point. Some UTF-8 messages that include a "right arrow" unicode code
point are translated to ASCII Ctrl-Z (ASCII 26) char, which is interpretted
by Windows as "EOF" (end of file) marker for files open in "text mode" and
the file won't be read beyond that char. Open the file in binary mode to
more closely match the *nix fopen() before.

Accession reported that (sometimes?) his NNTP logins show up in his
logon.jsonl files. This is most likely just a race condition when logging
in close to the same time with multiple protocols (e.g. Telnet and NNTP
in this case). So, let's log the client.protocol as a separate JSON property
and not require on the user.connection property (which is overwritten for
*every* login, for almost all connection/server types, not just the terminal
server). The client.protocol is always correct for the current session running
the script.

An NNTP login should never appear in the logon.json file.

Insert (using unshift) to the beginning of the list, rather than append (using
push) to the end of the list.

This fixes issue #761

Similar to -y option, but supports going further back than just yesterday.

As reported by Keyop

Eric Oulashin authored 9 months ago and Rob Swindell committed 9 months ago

dd_lightbar_menu: Added KEY_F* defines in there that were referenced in getKeyWithESCChars().  Refactored the includes in SlyEdit, since SlyEdit uses getKeyWithESCChars()

Pass-through only really does anything useful if the BBS user's client is a
Telnet client and it responds as the server expects. Since the user's
Telnet client (when using one) has already negotiated Telnet options, they
won't ACK options that the server expects them to, so this doesn't really
work. The proxy fixes that issue.

Also arrange section writing order to match scfglib2.c

This problem doesn't happen with the .bin version of these scripts.

Thanks for the reminder, Keyop

The extra characters (comments) are ignored when parsing this particular file,
so though this is not how we normally add comments to .ini files, it still
works fine in this case.

SlyEdit: In SlyEdit_Misc.js, check to see that xtrn_area.editor[user.editor] is an object before using it.  Should help with #755.

Eric Oulashin authored 10 months ago and Rob Swindell committed 10 months ago

SlyEdit: Don't line-wrap poll messages for quoting. Also, minor fix for the 'to' name length in DCT mode.

Though the FILES.BBS might have filenames with dashes, the filenames actually
have underscores. Consider converting any other valid DOS filename characters
that are not allowed in ISO 9660 filenames as well (but to what?).

More logging of missing and renamed files (e.g. fixed case, dashes replaced
with underscores).

Eric Oulashin authored 10 months ago and Rob Swindell committed 10 months ago

SlyEdit quote line wrapping update: When re-wrapping quote lines, use the quote wrap settings from xtrn.ini, or default to 79 columns, as many terminals are 80 columns wide.

The "RemoteAccess emulation" flag can be set by other shells, so be sure to
clear it when using (e.g. switching back) to this shell.

dd_lightbar_menu.js: Changed the older KEY_PAGE_UP to KEY_PAGEUP and KEY_PAGE_DOWN to KEY_PAGEDN, as defined in key_defs.js