1. 24 May, 2022 5 commits
  2. 19 May, 2022 1 commit
    • Rob Swindell's avatar
      Fix loop limit (system.stats.total_users != system.lastuser) · ddd4d10b
      Rob Swindell authored
      When looping to highest user number, use system.lastuser, not
      system.stats.total_users.
      
      This explains why not all userbases would be affected by the just-fixed
      issue in js_user.c. If the total_users happens to equal lastuser, then
      you would have hit the issue in js_user.c. If you had at least one
      deleted or inactive user account, then system.stats.total_users would
      be less than system.lastuser and your system would *not* have triggered
      that bug.
      ddd4d10b
  3. 18 May, 2022 1 commit
    • Rob Swindell's avatar
      Fix User.number increment beyond lastuser issue · 65e93897
      Rob Swindell authored
      When the 'number' property of an instance of User was incremented beyond the last user, the call to fgetuserdat() on subsequent property 'get' operation would fail and zero-out the user structure (including the user number). This resulted in an infinite loop in load/birthdays.js where the user number would go from lastuser to 1 in one operation (u.number++).
      
      Reported by DesotoFireflite (VALHALLA)
      65e93897
  4. 17 May, 2022 7 commits
  5. 16 May, 2022 4 commits
  6. 11 May, 2022 2 commits
  7. 10 May, 2022 4 commits
  8. 09 May, 2022 1 commit
    • Rob Swindell's avatar
      Add "Disable Local Display" option for doors, parse DOSXTRN.ERR · dc0d401d
      Rob Swindell authored
      New option to disable local screen display for door programs: sets the 'Screen' value appropriately in door.sys or pcboard.sys drop files and on Windows, doesn't create a new console window.
      
      Also, now parsing the DOSXTRN.ERR file created by the latest/greatest dosxtrn.exe when failing to execute the child/DOS program and log the parsed error details (errno value and description), helpful in debugging the reason why a DOS program may not have been successfully executed by DOSXTRN.
      dc0d401d
  9. 08 May, 2022 5 commits
    • Rob Swindell's avatar
      Remember the last 'first_msg' property value after msgbase is closed · 323ff1e8
      Rob Swindell authored
      The other msgbase property values are stored in the smb.status or other private_t members which retain their value when the message base is closed, unlike the 'first_msg' property which required a read of the message base index to get the value (and that doesn't work when the message base is closed, so would return 0).
      
      for deon (ALTERANT)
      323ff1e8
    • Rob Swindell's avatar
      Synchronet Virtual DOS Modem for Windows · b70d5898
      Rob Swindell authored
      First commit.
      
      Right now it just connects/accepts-connections using raw TCP. As demonstrated in YouTube video:
      https://www.youtube.com/watch?v=fxp38Nde3fg
      b70d5898
    • Rob Swindell's avatar
      Improvements to virtual UART driver for Windows · 7791b698
      Rob Swindell authored
      In the process of creating/testing the new Synchronet Virtual DOS Modem (SVDM) project, I made the following significant improvements:
      
      - Don't default the log level to DEBUG for debug builds
      - Add a "carrier change" event so carrier low to high transitions can be tracked too
      - Replace several lprintf() calls with lputs() for performance reasons
      - Specify 'volatile' storage for pending_interrupts
      - Interrupts are re-asserted if there are any pending interrupts after reading IIR register
      - Emulate FIFO enablement
      - Support RTS flow control signal
      - Remove conditional/configurable yields when polling LSR and MSR register, would just unnecessarily slow down terminal programs
      - Report "DCD change" in MSR correctly
      - Clean-up (e.g. close handles) in VDD_CLOSE handler
      - VDD_LOAD_INI_FILE allows an optional ini filename (instead of directory) as its argument - for loading an ini filename other than sbbsexec.ini (e.g. svdm.ini).
      
      Initialize log level in VDDInitialize(). For versions of Windows/NTVDM that use/call the "init proc" (this function), we just re-initialize global variables here.
      7791b698
    • Rob Swindell's avatar
      Support an optional ini filename argument, write to DOSXTRN.ERR · 5e9cc98f
      Rob Swindell authored
      If a 4th optional argument is provided, use that as the ini filename for virtual UART/FOSSIL driver settings instead of "sbbsexec.ini". Using this feature requires an updated sbbsexec.dll that supports an ini-filename argument (instead of a directory) to the VDD_LOAD_INI_FILE command.
      
      If DOSXTRN fails to execute the passed command-line, _spawnvp() returns -1, log the errno value and description to DOSXTRN.ERR (in the same directory as DOSXTRN.ENV). This will help diagnose issues executing DOS command-lines (e.g. file not found).
      
      Upon failure to open/create DOSXTRN.RET, don't prematurely terminate as that would skip a lot of important cleanup.
      5e9cc98f
    • Rob Swindell's avatar
      Print the upload TCP protocol (when available) w/user name, not host/IP · 066c4bd3
      Rob Swindell authored
      Long hostnames would prevent the protocol from being shown. Also, non-operators should be able to see the protocol used to upload files.
      066c4bd3
  10. 01 May, 2022 1 commit
  11. 30 Apr, 2022 2 commits
    • Rob Swindell's avatar
      Fix DIZ extraction/use for FTP uploads · b1449b27
      Rob Swindell authored
      1. Was not setting f->dir to the correct directory number, so only ftp-uploads to the *first* directory (dirnum = 0) would extract DIZ files of uploaded files.
      
      Removing the 'dirnum' parameter to addfile() since that implied that you did not have to initialize the 'dir' element of the passed file_t, but you do: to get the correct file path for file size/date detection and the DIZ extraction.
      
      2. Was getting heap-corruption when freeing the imported/formatted DIZ text on Windows once the above problem was fixed: can't free() in one DLL memory that was allocated in another DLL. Created and now using free_diz() to free the memory allocated in read_diz().
      
      format_diz() handles a NULL 'lines' argument correctly/gracefully, so no need for the NULL lines check in sbbs_t::uploadfile().
      
      Added FTP server log messages for successful file upload or update by user.
      b1449b27
    • Rob Swindell's avatar
      Fix CID 174496: Integer handling issues (BAD_SHIFT) · bf1cae28
      Rob Swindell authored
      Don't repeat call atoi() unnecessarily.
      bf1cae28
  12. 29 Apr, 2022 3 commits
    • Rob Swindell's avatar
      Give the timed event config menu the left/right arrow key treatment · f0b0e4ef
      Rob Swindell authored
      Allows quick traversing through timed events (e.g. for comparison of settings).
      f0b0e4ef
    • Rob Swindell's avatar
      Add "Native" option for QWKnet call-out cmd-lines · bb43c70b
      Rob Swindell authored
      This really shouldn't be necessary to toggle (at least now) on Windows, since we treat all off-line executions as "native", but for *nix, it could make a big difference if trying to invoke a native program or shell script for a QWKnet call-out and it would either fail due to no DOS support or try to executing using Linux-DOSEMU (unless the command's program name was in the global "native program list" configured in SCFG->External Programs).
      bb43c70b
    • Rob Swindell's avatar
      When running 16-bit DOS commands "offline" on Windows, don't use dosxtrn · 47e60472
      Rob Swindell authored
      We shouldn't need a virtual UART/FOSSIL driver to execute "offline" program (e.g. timed events) in the first place, and our virtual UART/FOSSIL for Windows wouldn't work right in the scenario anyway even if it did load successfully.
      
      This resolves the reported issues with timed events configured as not "native" returning error 255 (and not running successfully) on Windows with SBBS v3.19. I'm not even sure what changed exactly in xtrn.cpp, dosxtrn.c, and sbbexec.c between v3.18 and v3.19 that's causing this to now fail, but it (using DOSXTRN to run offline DOS programs) really shouldn't have been attempted in the first place. So that was just a design issue that happened to kind of sort of work up until v3.19.
      47e60472
  13. 28 Apr, 2022 4 commits