prextrn.js keys off of the current node action to detect if the user is
currently in the logon process. Defeat that check in this case (there is no
logon process for auto-xtrn's).

use options.clear_screen for clear instead of hardcoded value in SelectItemHdr
remove redundant code for input in main section menu

Previously, the xtrn*_tail menu was only displayed in the programmatic menu
mode.

Also, using the P_NOERROR mode flag for bbs.menu() to simplify all the if/else
logic.

And use require() instead of load().

Nigel Reed authored 4 years ago and Rob Swindell committed 4 years ago

display the file after the list of external programs.

Thanks for pointing that out mlong.

Call this one "2"
Flashbacks to manually editing zone files here.
I may end up going with YYYYMMDD numbers like I sometimes did in
zone files, but maybe I'll just do the single number thing... not
really sure yet.

These frames were already not allowed in the binkp/1.0 protocol,
and it is mentioned in the spec (issued in 2005) as "Some old
implementations do send empty frames as the last frame.".

It's certainly not allowed now, and any mailer which does it is
broken.

For zero-length data packets, it will be seen as a frame containing
zero data bytes which will also be logged as being after the file
if it comes after the file has already been completely transferred.

A zero-length command packet will abort with M_ERR, logging an error
regarding command number NaN or something like that.

This may fix #185 since attempting a recv() of zero bytes and
succeeding is the only way I can see for a zero second timeout to
have been logged in receving frame data.  The software assumed that
receiving zero bytes was a timeout, but if that's what you asked for,
it's actually success.

we assume it's 1.1 anyway.

This has been fixed upstream for some time.

This restores the meaning of remote_ver and still has a hack for
broken, unfixable mailers that don't advertise protocol v1.1
correctly (ie: Irex)

According to both FTS-1026 and FSP-1024, the "mailer version" portion of this
msg may contain spaces. Some mailers (e.g. Internet Rex), provide their version
information with spaces, e.g. "Internet Rex 2.67 beta 1a OS/2 (binkp/1.1)",
which also include a non-conformant protocol version indicator:
 " (binkp/1.1)" instead of " binkp/1.1".
Additionally, only require that "binkp/" exist in the string, to find and
parse the protocol version number, which is apparently critical to the proper
operation of the protocol. This should resolve issue #185 reported by altere.

I'm also storing the entire VER response in the binkp.remote_ver property and
this will break the older Mystic/BinkP work-arounds in binkit.js. I dont' think
we really need those workarounds any longer however. We'll soon see I guess.

Use the text.dat strings that corresponded with the previous behavior
(used by console.uselect()). The defaults include new-lines, so removed
some hard-coded console.crlf() calls that were added. If you have a
custom section_header_fmt, you'll likely need to add a \r\n to it.

Allow the "External Program Section" title string to be customized
(separately from section_header_fmt, e.g. for localization).

Save/use the current section.

Mouse-enable the program section list.

Often you may only want the plain-text portion of a message (e.g. for
printing).

If there's no 'id' property, don't display "Message-ID: undefined".
If the new default_content_type argument is false, don't display
a default content-type and content-transfer-encoding.

New modopts.ini [chat_sec] options:
- imsg_requirements (default: blank)
- irc_requirements (default: blank)
- finger_requirements (default: blank)

For DesotoFireflite (VALHALLA)

Set the following in the modopts.ini [avatars] section:
msghdr_draw_top (default is true)
msghdr_draw_above (default is true)
msghdr_draw_right (default is true)

Set any of these to false to override the default behavior -
for DesotoFireflite (VALHALLA).

This commit also includes a couple of changes I've been apparently
sitting on:
- display avatars even for non-ANSI/non-CP437 terminal users
- cache the smbdefs.js in bbs.mods.smbdefs (I don't recall why)

Enable the option to ask for continuation/enter door when displaying info/intro ans/msg file. This could be useful when displaying info about a door, showing rules, etc.

As reported by plt from the I, the R, and the C.

Also, abort menu upon Ctrl-C.

Then, add JSDOC support to crypto class constant objects.

Also, since crypto stuff is almost half of all the docs, move all
the crypto classes and objects to the end. It would be nice if these
massive lists were hidden by default line the menu tree at the start.

By simply installing a supported 3rd party door game into your
"xtrn" directory, install-xtrn.js or xtrn-setup.js can automatically
discover and configure your newly installed door for Synchronet. Easy peasy.

Resolves issue #181 (great idea) by Michael Long. Deuce and others have had
similar ideas in the past.

Now, we don't have to rely on the authors of potentially-abandoned door games
to create and include a Synchronet install-xtrn.ini file. We can just do that
for ourselves and make installing all (known) door games super easy.

Many more xtrn/3rdp-install/*.ini files will be forthcoming!

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

allows more flexibility in formatting xtrn program menus by allowing one to remove the titles or underline headings by setting them to 'none' in the ini file

Use the new "blanks" option with File.iniGetAllObjects().
This means that keys specified in the modopts.ini with no value
will now be represented as blank strings ("") instead of undefined values,
in JS modules.

Kayz authored 4 years ago and Rob Swindell committed 4 years ago

change the program var in xtrn.js to prog to be compatible with any existing uses of eval_before_exec

By default, displays users of the BBS born in the current month.

Remove birthdate.js - not needed or used anywhere (anymore).

Don't load() things unnecessarily (use require() instead).
Fix the X-restriction issue (is not supposed to limit the execution of
programs configured to run as logon events).

Throw exceptions rather than just loggin an "Unable to open" error
(easier tracking fo the soruce of the error). Log the description and
errno value associated with the file open failure.

Create the .ini files if they don't already exist (rather than crashing
out with an error).

Replace the deprecated 'e' file open mode flag with 'x'.

This should help to root-cause any future msgbase open failures like those
that I suspect were a result of Issue #4.

This should address the issue raised by Michael J. Ryan in issue #4.
The command in question ("GROUP") would attempt to open the message
base associated with the specified newsgroup name without closing
the currently open/selected message base (if there was one). This would
result in multiple simultaneously open message bases and could result
in an exhaustion of open file descriptors leading to a failure to open
any additional files (includign message bases) and thus a subsequent
"GROUP" command would fail with the wrong "!no such group" error.