When no files with extensions are found, though they matched the glob()
pattern, a NULL pointer deref would result (segfault).

This could happen if the only files matching the pattern had no extenions or
were directories (not files).

Fix for issue #779

... this was the cause of some observed unnecessarily high disk/file server
(Samba) utilization, as we call getnodedat() a lot. utime() opens and closes
the file, which was already open - and we're not modifying the file, so
updating the 'modification time' here is wrong anyway.

Disabling this 21-year old bit of logic resulted in a pretty dramatic
reduction in Samba (smbd) CPU utilization on Vertrauen.

If a BBS actually needes this hack (e.g. for NFS compatibility, as Deuce
eluded in the comment), they'd be better off just setting the "Keep Node File
Open" node setting (in SCFG->Nodes) to "No".

I'v been getting errors locking user.tab (for read) for a while (over samba),
so hopefully this helps. The lockuserdat() total timeout duration extends from
about 5 seconds to about 45 seconds (with an incremental back-off).

Implement the same lock-retry logic/limit in putuserdat().

... requested by someone in #synchronet

Apparently, Mike Dippel's actual FidoNet address is 3:712/1321.5

DDFileLister: Now supports editing file info (with the E key).

See merge request !453

At least 512 bytes per call.

Eliminates GCC warning about not checking return value of write/sendsocket()

Includes swindows with unborked home/end key handling in lightbar. Fixes problem reported by Nightfox.

browser. Should be feature-equivalent with the old one, though
the navigation is a bit different.

If you don't like it, dig the old one out of git and run it from
some other location.

This is a build of:
https://gitlab.synchro.net/echicken/nodelist-browser
and it will be maintained there for now. I'll try to remember to
update this copy as needed. Do not edit / commit changes to this
file; it's transpiled from TypeScript and not meant to be edited
by hand. Do not read this file if you value your sanity.

The expansion of LF to CRLF (with TG_EXPANDLF) is on receive.

For Nelgin

DDMsgReader: Updates to fix new user newscan, depending on the scan_ptr value

See merge request !452

Don't display remote host name/addr unless -v option is specified or
verbosity=1 is set in modopts.ini.

Allow the displayed messages to be customized or disabled as the sysop wishes
via modopts.ini keys:
- help_msg
- connecting_msg
- failed_connect_msg
(e.g. set to a blank string to disable)

The following settings are also now configurable via modopts.ini:
- quiet (correlates with -q option)
- pause (correlates with -P option)
- clear (correlates with -C option)
- timeout (correlates with -T option)
- verbosity (correlates with -v option)

... a sysop can control the default behavior of all invocations of telgate.js
or rlogin.js via a single file now (modopts.ini).

The rlogin.js module will first look ing for the [rlogin] section in
modopts.ini and if it doesn't exist, then [telgate] section. telgate.js just
looks for the [telgate] section.

For the #synchronet irc crew: Nelgin and Keyop

I'm not clear why Coverity suddenly thinks that getstr() doesn't
nul-terminate strings, but whatever: NUL-terminate the buf before passing it
to getstr(). <shrug>

HANDLE_PENDING() macro returns from the calling function (without freeing
allocated resources), so don't use that here.

Only the last node number specified would be listed before this fix.

Telnet requires CRLF or CR/NUL instead of bare CR.

This is a rewrite of the Bullshit bulletin lister. Should have all
the same features as v3, but much faster at lightbar navigation
and especially better at scrolling large files. (frame.js has been
replaced here by my new screen management library, 'swindows'.)

Sysops don't need to concern themselves with the files in this
commit; the build generated from these has been placed in the same
location as the old 'bullshit.js' script. Just copy that one to
wherever you normally run this from and it'll take over. Or you
could run Bullshit from the repo if you like to live dangerously.

bullshit v4 build as in-place replacement for v3. On first run under the terminal server, your old bullshit.ini settings will be migrated to ctrl/modopts.d/bullshit.ini in a slightly different format.

Fix issue #773

No longer claim that 'list' is the default action (it's not).

If you want to list nodes, you need to specify the 'list' action.

Fix for issue #772

bbs.telnet_gate() is not tolerant of receiving an undefined parameter value
(while bbs.rlogin_gate() is), so this messed up the subsequent argument
parsing which caused the strings pushed with the '-s' or '-S' options to
not work.

Fixes issue #774

Includes new feature to optionally send string(s) to remote server after
connecting (for Nelgin).

The -q option addition fixes issue #771.

If an array argument is passed to these methods, the stringified contents of
each array element value will be sent to the remote server after connecting.

This is to support Nelgin's request of sending some strings to a server after
connecting. There's no way to insert pauses between the sent strings or wait
for certain output from the remote - that's beyond this scope/capability.

DDMsgReader: New msgSaveDir option to specify a default dir to save messages to (for the sysop)

See merge request !450

... since these methods only feed the keyboard buffer.

Add an optional 'insert' argument to console.ungetkeys() - default is false
(append).

Add a new version of console.ungetstr() which feeds the passed characters
directly to the receive input buffer. Now returns bool indicating success.
Existing scripts (if any) that use console.ungetstr() should continue to work
just fine.

This is anticipation of telgate.js being able to stuff strings (e.g. username,
password) into the input buffer and those chars/keys being passed to the
remote (gatewayed) telnet server. Since the telnet gateway reads directly from
the receive input buffer (ignoring the keyboard buffer), we needed a way to
stuff strings of characters into the receive input buffer directly and that
sort of exposed the weirdness of the existing console.ungetstr() method:
- it didn't return a return value (not indication of failure)
- it didn't support an 'insert' operation (even though the underlying C++
  method does)
- it didn't use the sbbs_t method that already existed for feedding a string
  of characters into the input/keyboard buffer