netmail.cpp:411:25: error: Invalid strchr() argument nr 2. The value is -29
  but the valid values are '0:255'. [invalidFunctionArg]
  char* tp = strchr(to, QWK_NEWLINE);  /* chop off at first CR */

Just a proof-of-concept for right now, there's a couple major changes
and some minor changes that will need to be made before this can
actually be enabled.

Not really testable without some seriously terrible hacks right now,
but it has been verified with the sftp client that ships with openssh
(which is based on a 20-year-old internet draft that is both expired
and superceded).

This was not a real leak, but still, good practice

error: Uninitialized struct member: node.misc [uninitStructMember]

[integerOverflow]

Where ever we assign the realloc() result to the same pointer we pass, use this new function instead to eliminate the cppcheck error reported by Nelgin:
Common realloc mistake: 'p' nulled but not freed upon failure  [memleakOnRealloc]

This isn't going to actually solve any memory leaks, it's just good practice for critical error (e.g. no memory error) handling.

... weird this wasn't required before now.

Removed obsolete DSTSEDIT target.

Resolves 'make sexyz' build issue mentioned in issue #690

Fix up the 'utils' target a bit

List all the add'l sub-build targets in 'help' output

Also updated some durations, lowercase unit designator, and added some
more server section comments.

Add -host=<name> option to set the hostname to use for alternative sbbs.ini
file.

Fix CID 471381

Using MsgBase.get_all_msg_headers() which didn't exist when this module was
originally written.

Also, include "use strict";

Apparently some Gopher clients prepend a slash to all requests

Fix issue #688

The JS objects will still log to the terminal server (regardless of which server created/used the objects) however - so that's still a TODO.
Change do_cryptInit() to return bool, since it does.
Log detailed error if pthread_once() call fails.
Lowered-severity (to DEBUG) the log messages related to TLS private key and cert creation and destruction.

FIrst commit from within MSVS, so this might look weird.

... wasn't accounting for length of the 'top' buffer (when supplied).

Also, for raw input mode:
- flush the input buffer (stray LF) before accepting input
- turn off raw input mode if run out of bytes (max lines/length reached)

I was investigating the reported error by Nelgin:
  !ERROR in writemsg.cpp line 1214 (msgeditor) checking
		"max lines (20) exceeded" access=46
which I was unable to reproduce, when I encountered the issues addressed
in this commit.

From: Carlos Navarro (2:341/234.1)

Messages that use CHRS: LATIN-1 are not displayed properly in newsreaders
(Synchronet's NNTP server renders them with the default charset=IBM437).

This fix may work: edit exec/load/newsutil.js, at line 77 insert

        case "LATIN-1 2":
                charset = "ISO-8859-1";
                break;

If you want to test: ßΘφ≤· ± (accented aeiou, n with tilde)

... for server configuration dialogs

I'm doing this manually with String.replace() because the "built-in"
strip_ctrl_a() function doesn't expand ^A/ (conditional line-break) as it
would need to.

DDMsgReader: Copy-paste fix for section(s) of code for editing a local user account while reading

See merge request !378

Private key objects in cryptlib are not copied into sessions when
they're added, only the refcount is incremented.  These objects
contain a bignum context, which therefore ends up shared across all
instances of the private key.  Unfortunately, the locking is on the
session context, not the private key objects, so shared bignum contexts
can cause memory corruption.

Further, even if the locking issue was fixed, the performance handbrake
would still exists... activating sessions that use the same private key
would be serialized, with the results we've been seeing lately.

With this, each session gets a unique private key, which is loaded
from the file.  When a session is finished with the key, it is cached
in a list with an epoch, so when the date on the key file changes, old
private keys will be eliminated.

While this solves a lot of issues, logging of certificate generation
and loading issues has regressed to the point where it's effectively
not done at all. Logging was previously passed back to the caller,
but given the much longer call chain to get to where a cert is created,
the extra parameters was just too much. Something better should be
done here at some point.

02:23:11 <DigitalMan> maybe a button/link to expand/collapse all the extended comments? Would make text searching easier

We need to get the NextItem *before* we delete the current one.

I'm not sure why this was in there, but removed it as appears to have
no effect:
	if(ListView->Selected == NULL)
		break;

Only change cursor if desc td has div child; exit desc click handler if no extdesc div; only add div child to desc td if extdesc present;