Skip to content
Snippets Groups Projects

IMAPS error

    • Closed Issue created by Keyop Troy @Keyop

    Sun Apr 17 02:43:16 2022 master/632e51d8 srvc 0079 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

    Designs

      Child items ...

      2. Activity

      • Rob Swindell assigned to @Deuce

        assigned to @Deuce

      • Keyop Troy
        Keyop Troy @Keyop ·
        Author Developer

        Still getting this error - any chance of a fix?

        Sat May 14 21:35:35 2022 master/6de0ebc0 srvc 0575 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:35 2022 master/6de0ebc0 srvc 0614 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:35 2022 master/6de0ebc0 srvc 0590 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:35 2022 master/6de0ebc0 srvc 0604 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:36 2022 master/6de0ebc0 srvc 0615 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:36 2022 master/6de0ebc0 srvc 0610 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:36 2022 master/6de0ebc0 srvc 0592 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:36 2022 master/6de0ebc0 srvc 0584 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:36 2022 master/6de0ebc0 srvc 0578 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:36 2022 master/6de0ebc0 srvc 0590 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:36 2022 master/6de0ebc0 srvc 0594 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:35:38 2022 master/6de0ebc0 srvc 0575 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

        Sat May 14 21:42:15 2022 master/6de0ebc0 srvc 0617 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1861: TypeError: args.shift().toUpperCase is not a function

      • Keyop Troy
        Keyop Troy @Keyop ·
        Author Developer

        As per nelgin's suggestion - after adding this line at 1861:

        log(LOG_INFO, "args.shift() is " + args.shift());

        I get:

        May 16 17:58:58 lr08 synchronet[2362]: srvc 4048 IMAPS args.shift() is NOT

        May 16 17:58:58 lr08 synchronet[2362]: srvc 4048 IMAPS args.shift() is DELETED

        May 16 17:58:58 lr08 synchronet[2362]: srvc 4048 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1862: TypeError: args.shift() is undefined

        May 16 17:59:01 lr08 synchronet[2362]: srvc 4048 IMAPS args.shift() is UNSEEN

        May 16 17:59:01 lr08 synchronet[2362]: srvc 4048 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1862: TypeError: args.shift() is undefined

        May 16 17:59:01 lr08 synchronet[2362]: srvc 4051 IMAPS args.shift() is UNSEEN

        May 16 17:59:01 lr08 synchronet[2362]: srvc 4051 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1862: TypeError: args.shift() is undefined

        Edited by Keyop Troy
      • Keyop Troy
        Keyop Troy @Keyop ·
        Author Developer

        May 16 17:59:01 lr08 synchronet[2362]: srvc 4048 IMAPS Logging in Keyop

        May 16 17:59:01 lr08 synchronet[2362]: srvc 4048 IMAPS args.shift() is UNSEEN

        May 16 17:59:01 lr08 synchronet[2362]: srvc 4051 IMAPS Logging in Keyop

        May 16 17:59:01 lr08 synchronet[2362]: srvc 4048 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1862: TypeError: args.shift() is undefined

        May 16 17:59:01 lr08 synchronet[2362]: srvc 4051 IMAPS args.shift() is UNSEEN

        May 16 17:59:01 lr08 synchronet[2362]: srvc 4051 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1862: TypeError: args.shift() is undefined

        May 16 17:59:02 lr08 synchronet[2362]: srvc 4048 IMAPS Logging out Keyop

        May 16 17:59:02 lr08 synchronet[2362]: srvc 4048 IMAPS service thread terminated (3 clients remain, 2 total, 5143 served)

        May 16 17:59:02 lr08 synchronet[2362]: srvc 4051 IMAPS Logging out Keyop

        May 16 17:59:02 lr08 synchronet[2362]: srvc 4051 IMAPS service thread terminated (2 clients remain, 1 total, 5143 served)

        Edited by Keyop Troy
      • Deon George
        Deon George @leenooks ·
        Developer

        Using log(LOG_INFO, "args.shift() is " + args.shift()); is not a good idea, because it will remove the next item from args (and thus a subsequent call to it could yield an empty result).

        I suggest you use log(LOG_INFO, "args is " + JSON.stringify(args)); instead - that way you can see what the contents of args is (and then manually determine what args.shift() may yield).

      • Keyop Troy
        Keyop Troy @Keyop ·
        Author Developer

        We had a debate about this on the irc #synchronet channel, and the code we've gone with (as suggested by Deuce) is:

                    log(LOG_INFO, "args type: " + typeof(args));

            log(LOG_INFO, "args toSource: " +  args.toSource());

        Hopefully this will help track down the issue.

        Let me know your thoughts :)

        Edited by Keyop Troy
        • Keyop Troy
          Keyop Troy @Keyop ·
          Author Developer

          Ok we have a trigger on the 28th with the logging code added:

          Extra Code:

          log(LOG_INFO, "args type: " + typeof(args));

          log(LOG_INFO, "args toSource: " + args.toSource());

          syslog:

          May 28 20:26:38 lr08 synchronet[1198426]: srvc 0125 IMAPS args type: object

          May 28 20:26:38 lr08 synchronet[1198426]: srvc 0125 IMAPS args toSource: [["OR", "TO", "Premier inn", ["OR", "CC", "Premier inn", ["OR", "FROM", "Premier inn", ["OR", "SUBJECT", "Premier inn", [["OR", "FROM", "P remier", ["OR", "SUBJECT", "Premier", ["OR", "TO", "Premier", "CC", "Premier"]]], ["OR", "FROM", "inn",

          May 28 20:26:38 lr08 synchronet[1198426]: srvc 0125 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1864: TypeError: args.shift().toUpperCase is not a function

          May 28 20:26:38 lr08 synchronet[1198426]: srvc 0138 IMAPS args type: object

          May 28 20:26:38 lr08 synchronet[1198426]: srvc 0138 IMAPS args toSource: ["DELETED"]

          May 28 20:26:38 lr08 synchronet[1198426]: srvc 0128 IMAPS Logging out Keyop

          Does this help?

          Edited by Keyop Troy
        • Andre Robitaille
          Andre Robitaille @andreMKE ·
          Contributor

          What specifically did you do to trigger that search for a bunch of variations of premier inn? Are you able to recreate it, and if so you should describe the steps to recreate it.

        • Keyop Troy
          Keyop Troy @Keyop ·
          Author Developer

          Hi Andre, yes just worked out the trigger event.

          Searching for any string within the iOS mail client.

        • Please register or sign in to reply
        • Deucе
          Deucе @Deuce ·
          Maintainer

          Aha! Yeah, it looks like the parenthesis support is only half-baked. I'll dig into this when I have more time, thanks for tracking this down!

        • Keyop Troy
          Keyop Troy @Keyop ·
          Author Developer

          Hi Deuce - any further thoughts on this one, as my error.log fills up when I search for text on my iPhone?

        • Please register or sign in to reply
      • Keyop Troy
        Keyop Troy @Keyop ·
        Author Developer

        Latest error.log related to this issue:

        Tue Sep 12 23:23:56 2023 master/c9e64372

        srvc 0159 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1859: TypeError: args.shift().toUpperCase is not a function

        Tue Sep 12 23:24:37 2023 master/c9e64372

        srvc 0153 IMAPS !JavaScript /sbbs/exec/imapservice.js line 1859: TypeError: args.shift().toUpperCase is not a function

      • Rob Swindell mentioned in commit bbe3042a

        mentioned in commit bbe3042a

      • Keyop Troy
        Keyop Troy @Keyop ·
        Author Developer

        This issue has been resolved.

      • Keyop Troy closed

        closed

      • Deucе mentioned in issue #730 (closed)

        mentioned in issue #730 (closed)

      • Rob Swindell mentioned in commit de03c0c6

        mentioned in commit de03c0c6

      • Deucе mentioned in commit e997e293

        mentioned in commit e997e293

      Please register or sign in to reply