Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Synchronet Synchronet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 224
    • Issues 224
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

This GitLab instance has migrated as of Nov-5-2022 to a new server: hardware, OS, SSH key

The v3.20a development branch has now been merged to the master branch. Sysops upgrading from earlier versions must run 'jsexec update'

  • MainMain
  • SynchronetSynchronet
  • Merge requests
  • !128

SlyEdit v1.75: Refactored the quote selection menu and cross-post selection

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eric Oulashin requested to merge slyedit_175_crosspost_and_quote_menu_refactor_ddlightbarmenu into master Dec 11, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 6

SlyEdit v1.75: Refactored the quote selection menu and cross-post selection menus to use DDLightbarMenu instead of SlyEdit's own lightbar code. This allowed the elimination of most of the rest of SlyEdit's own lightbar code, reducing the size of SlyEdit.js by about 40Kb. It also provides some consistency in behavior by using a common menu component.

Also, to support some additional required behaviors by SlyEdit, added the following 'event' functions to the DDLightbarMenu class: ValidateSelectItem(pItemRetval): For validating that the user can select an item. Takes the item's return value, and returns a bool to indicate whether the item can be selected.

OnItemSelect(pItemRetval, pSelected): A function that is called when an item is being selected (or de-selected, when multi-select is enabled). The parameters are the item's return value and a boolean to indicate whether the item was selected or de-selected.

Also, added an explicit DoKeyDown() function to DDLightbarMenu to support scrolling the menu down when desired (special case for SlyEdit's quote selection window).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: slyedit_175_crosspost_and_quote_menu_refactor_ddlightbarmenu