warning: passing argument 2 of ‘mosquitto_message_callback_set’ from incompatible pointer type

Interestingly, not required for successful MSVC build. <shurg>

I suspecte the circular dependency and include-guards around mqtt.h
and startup.h were going to be a problem.

Now support subscriptions (e.g. recycle topics, node input topics) in SBBSCTRL.
This required a lot of search/replace and fun with circular struct pointers.

Doing this via manual edits to this bpr file don't seem to work.

Fix issue #470 reported via IRC: timed event "mdays" values were read and written as 16-bit values, meaning any setting for days > 15 would do weird things.

The only difference in the data/scheme is that the "error" topic (error log) is now under each server rather than each host. I don't *think* there are any other changes from the MQTT consumer side.

Still not done: subscribing (e.g. support for recycle or node-spy-input via MQTT) and NT services support.

This change also includes a cool feature that will prompt the sysop if there's a timeout (30 seconds) while waiting for servers to shutdown gracefully and giving the sysop the option to abort (Cancel) the wait (and shutdown ungracefully) or continue the wait (OK).

And export a simple ver() function to be used in MainFormUnit.cpp (for mqtt stuff)

e.g. sbbs.dll

Turned of "Use dynamic RTL" and "Build with runtime packages" under
Project options.

This should resolve the UserEdit.exe runtime issue reported by Diamond Dave
via DOVE-Net.

Bug introduced in the systemd integration (commit 7e320d92)
and reported by Dan_C via #synchronet at irc.synchro.net

This reverts commit 0280050f.

This reverts commit 0ee77637.

This seems to stop the CI build and I haven't found any other solution.
So just copy/paste the contents of makelibs.bat into this batch file. <sigh>

when run from Gitlab-Runner (CI) using shell="cmd"

CID 433272

Some trailing whitespace clean-up too.

Previously, many servers and services didn't support login by real name
(e.g. issue #469) even if the sysop had that option enabled in SCFG.

Move login control settings from node.ini to system (main.ini -> login)

The 3 node toggle options:
- Allow Login by User Number
- Allow Login by Real Name
- Always Prompt for Password

... have been now moved from SCFG->Nodes->Node x->Toggle Options to
SCFG-System->Toggle Options.

If you upgraded to v3.20a before now, you'll want to double-check these
settings to make sure they're how you want them set. New upgraders that run
upgrade_to_v320.js (e.g. via 'jsexec update') will get these settings migrated
automatically.

Added some error detection/logging to upgrade_to_v320.js when failing to open
.cnf files.

Constified some more user/login related function args and return types.

Oversight probably during the new filebase overhaul in v3.19. Reported by Nelgin.

No immediate use, but I thought I had one. I didn't. Still, will probably need these one day.

As apparently these happen a lot when a client disconnects right
away after connecting.

Need to start the MQTT init/thread-start stuff after daemonizing.

Thanks to Nelgin for letting me know this was recently broken.

I'm not sure what purpose this global variable once had, but it wasn't needed
now and it was masking copy/paste issues in some of the sbbs_t methods in this
file. Just make an 'sbbs' local to bbs_thread(), since there's where it's
legit-used.

FYI: All the Cryptlib-SSH macros assume there's an 'sbbs' in scope.

The MSS detection will set this to the best value on a per-connection
basis.  This will allow larger packets to be sent from the BBS.

If something else sets these events, and they never get cleared,
this will fall into a tight loop.

This came about through the realization that the global 'sbbs' in main.cpp
can (and was/is) hiding some copy/pasta bugs.

When the system checks for an incoming byte, if there's any pending
output, send it immediately, bypassing the outbuf highwater mark.

This allows the final non-full packet to be sent without waiting
for the OutbufDrainTimeout (default 10ms), and makes a big difference
when doing a large number of ANSI queries (send an ANSI code, wait
for a response).  There's a small but noticable placebo effect as
well that makes everything feel smoother.

This commit also cleans up the output thread where it pulls from
the ring buffer into the linear buffer to take advantage of the new
event-based ring buffers.  Much easier to read now.

Speaking of easier to read, this also includes some whitespace
fixups.