Ah, that's better. Actually would work correctly on big-endian platforms (should we ever support one) and with way less code.

(e.g. those stored in files, e.g. EXITINFO.BBS).

So I did a search through the code for sizeof.*long and was surprised to find some remaining (harmless) assumptions that a long is 32-bit.

long is 64-bits (8 bytes), not 32-bit on some target platforms (e.g. Linux-x64), so don't assume sizeof(long)==4.

It appears we weren't using these "automatic" integer-size macros anywhere that I can see, so no harm, but might as well fix them.

Also remove BYTE_SWAP_SHORT and BYTE_SWAP_LONG since they're terribly named. Retain the LE/BE_SHORT/LONG macros since we're using them currently in SBBS (e.g. js_file.c).

The default (when no argument to the '-l' option is provided) is to use
the last_few_callers value from the modopts.ini file. This was broken.

If modopts.ini [logonlist] last_few_days is set (to a number), that will
dictate the maximum number of previous days to pull last few callers from
(e.g. set to '0' for previous behavior).

Also, '-l' can now be used with a command-line option (e.g. '-l <num>')
to specify the number of callers to display (overriding the modopts.ini
last_fwe_callers value).

This should address issue (feature request) #371.

If days_ago argument is undefined (as is the case when performing
a "last few callers" query/list), then pull upto the maximum last
number of callers from previous days as necessary.

Part of fix for issue #371

DD File Lister bug fix: Now successfully formats filenames without extensions when listing files.

See merge request !155

Version 2.04 - Bug fix: Now successfully formats filenames without extensions when listing files.
This addresses issue #369.

So I was working on re-writing some of this door file generation code and noticed that the EXITINFO.BBS files generated by SBBS:

1. had a lot of garbage data filling unused string characters (no "harm", but potentially leaking information)
2. had the wrong total file length due to 64-bit logontime (time_t)
3. had the wrong total file length due to writing 19 GosubData elements (instead of 20)

The first and last issues appear to be some of those "forever" (20+ year old) bugs.

So I'm guessing no regularly used door games actually use these portions of the EXITINFO.BBS, so most likely: no harm, no foul. But still, best to fix this before I commit the rewrite.

p (which is used after this) points into 'str', so we can't use 'str' as a temporary variable here.

DDMsgReader: Fix for bogus messages when changing to an empty sub-board

Closes #367

See merge request !154

Fix: When changing to an empty sub-board from within the reader (either from
read mode or list mode), it now properly says there are no messages and exits,
rather than showing a list of bogus messages.
Unsure when this bug was introduced.
The version is now 1.46.

Fix handling of IRC color control sequences

See merge request !153

Nelgin's suggestion to support quick searching/scanning through message and file areas (e.g. comparing settings or whatever) without having to ESC then arrow key, ENTER, for each.

Uses Deuce's WIN_EXTKEYS UIFC mode flag, which I don't think I've used before now and uses the special -CIO_KEY value - 2 trick.

Also expanded the width of the sub-board and directory info windows to show more information (including full long name).

Fixes issue (wishlist item) #349 by Nelgin

As Andre pointed out, these checks perform no function because a user with a level lower than the user being edited cannot enter the related command-key anyway.

This was just effectively dead code that was held-over from ancient SBBS days, seemingly before I learned to effectively use the || operator:
if(!(atoi(str)>useron.level && console&CON_R_INPUT))

:-)

Fixes issue #361

An extra comma was being added after the control sequences
An empty color control sequence was not handled. It is supposed to
remove all color schemes.

SlyEdit now remembers the quote line window selection between openings.

See merge request !152

When selecting quote lines in a reply message, SlyEdit now remembers the
position in the quote selection menu so that the quote menu isn't always
at the top whenever it's opened again.  This issue may have been introduced
when SlyEdit was refactored to use DDLightbarMenu for its lightbar stuff.

At least, I think this fixes it.

At the suggestion/request of Andre Robitaille.

This option was originally added for debugging use, but may as well move it if it's useful in another way.

This only works on little endian systems (which is all we support currently).

Fixes CID 174261: Wrong size argument

This binary drop file writing code is pretty terrible and inefficient, but I remember being really proud of it (supporting so many drop files). This really should be re-written to use structures and/or buffered file I/O.

e.g. CID 229593: Negative loop bound

Fix CID 33266: Negative loop bound

e.g. CID 33631: Unbounded source buffer

Triggered by CID 33630: Unbounded source buffer